darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-01 04:08:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix tests that expect to be rate limited (which is off if redis is disabled)

Browse Source
This commit is contained in:
Leo Hemsted
2017-12-04 14:13:43 +00:00
parent 88c878c83e
commit 5bb6b68e57
3 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/app/notifications/rest/test_send_notification.py
View File

@@ -16,7 +16,10 @@ from app.models import (
from app.dao.templates_dao import dao_get_all_templates_for_service, dao_update_template
from app.dao.services_dao import dao_update_service
from app.dao.api_key_dao import save_model_api_key
from app.v2.errors import RateLimitError
from app.errors import InvalidRequest
from app.models import Template
from app.v2.errors import RateLimitError, TooManyRequestsError
from tests import create_authorization_header
from tests.app.conftest import (
sample_notification as create_sample_notification,
@@ -28,9 +31,6 @@ from tests.app.conftest import (
sample_service,
sample_template_without_sms_permission,
sample_template_without_email_permission)
from app.models import Template
from app.errors import InvalidRequest
from tests.app.db import create_service, create_reply_to_email
@@ -414,6 +414,10 @@ def test_should_block_api_call_if_over_day_limit_for_live_service(
mocker):
with notify_api.test_request_context():
with notify_api.test_client() as client:
mocker.patch(
'app.notifications.validators.check_service_over_daily_message_limit',
side_effect=TooManyRequestsError(1)
)
mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
service = create_sample_service(notify_db, notify_db_session, limit=1, restricted=False)
@@ -446,6 +450,10 @@ def test_should_block_api_call_if_over_day_limit_for_restricted_service(
with notify_api.test_request_context():
with notify_api.test_client() as client:
mocker.patch('app.celery.provider_tasks.deliver_sms.apply_async')
mocker.patch(
'app.notifications.validators.check_service_over_daily_message_limit',
side_effect=TooManyRequestsError(1)
)
service = create_sample_service(notify_db, notify_db_session, limit=1, restricted=True)
email_template = create_sample_email_template(notify_db, notify_db_session, service=service)

9
tests/app/service/test_rest.py
View File

@@ -2163,18 +2163,17 @@ def test_search_for_notification_by_to_field_returns_content(
assert notifications[0]['template']['content'] == 'Hello (( Name))\nYour thing is due soon'
def test_send_one_off_notification(admin_request, mocker):
service = create_service()
template = create_template(service=service)
def test_send_one_off_notification(sample_service, admin_request, mocker):
template = create_template(service=sample_service)
mocker.patch('app.service.send_notification.send_notification_to_queue')
response = admin_request.post(
'service.create_one_off_notification',
service_id=service.id,
service_id=sample_service.id,
_data={
'template_id': str(template.id),
'to': '07700900001',
'created_by': str(service.created_by_id)
'created_by': str(sample_service.created_by_id)
},
_expected_status=201
)

6
tests/app/service/test_send_one_off_notification.py
View File

@@ -151,9 +151,13 @@ def test_send_one_off_notification_raises_if_cant_send_to_recipient(notify_db_se
assert 'service is in trial mode' in e.value.message
def test_send_one_off_notification_raises_if_over_limit(notify_db_session):
def test_send_one_off_notification_raises_if_over_limit(notify_db_session, mocker):
service = create_service(message_limit=0)
template = create_template(service=service)
mocker.patch(
'app.service.send_notification.check_service_over_daily_message_limit',
side_effect=TooManyRequestsError(1)
)
post_data = {
'template_id': str(template.id),