mirror of
https://github.com/GSA/notifications-api.git
synced 2026-04-12 05:09:35 -04:00
code review feedback
This commit is contained in:
@@ -789,6 +789,17 @@ def _update_template(id, name, template_type, content, subject):
|
||||
db.session.commit()
|
||||
|
||||
|
||||
@notify_command(name="clear-redis-list")
|
||||
@click.option("-n", "--name_of_list", required=True)
|
||||
def clear_redis_list(name_of_list):
|
||||
my_len_before = redis_store.llen(name_of_list)
|
||||
redis_store.ltrim(name_of_list, 1, 0)
|
||||
my_len_after = redis_store.llen(name_of_list)
|
||||
current_app.logger.info(
|
||||
f"Cleared redis list {name_of_list}. Before: {my_len_before} after {my_len_after}"
|
||||
)
|
||||
|
||||
|
||||
@notify_command(name="update-templates")
|
||||
def update_templates():
|
||||
with open(current_app.config["CONFIG_FILES"] + "/templates.json") as f:
|
||||
|
||||
@@ -1717,8 +1717,6 @@ class Notification(db.Model):
|
||||
pass # do nothing because we don't have the message id yet
|
||||
else:
|
||||
fields[column.name] = value
|
||||
current_app.logger.warning(f"FIELDS {fields}")
|
||||
print(f"FIELDS {fields}", flush=True)
|
||||
|
||||
return fields
|
||||
raise ValueError("Provided object is not a SQLAlchemy instance")
|
||||
|
||||
@@ -38,9 +38,8 @@ class RedisClient:
|
||||
active = False
|
||||
scripts = {}
|
||||
|
||||
@classmethod
|
||||
def pipeline(cls):
|
||||
return cls.redis_store.pipeline()
|
||||
def pipeline(self):
|
||||
return self.redis_store.pipeline()
|
||||
|
||||
def init_app(self, app):
|
||||
self.active = app.config.get("REDIS_ENABLED")
|
||||
@@ -172,6 +171,10 @@ class RedisClient:
|
||||
if self.active:
|
||||
return self.redis_store.llen(key)
|
||||
|
||||
def ltrim(self, key, start, end):
|
||||
if self.active:
|
||||
return self.redis_store.ltrim(key, start, end)
|
||||
|
||||
def delete(self, *keys, raise_exception=False):
|
||||
keys = [prepare_value(k) for k in keys]
|
||||
if self.active:
|
||||
|
||||
Reference in New Issue
Block a user