darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #717 from GSA/notify-api-714

Browse Source 
no verification codes on staging
This commit is contained in:
Carlo Costino
2024-01-09 17:07:59 -05:00
committed by GitHub
parent a0d0ec33d6 5366992d1a
commit 54bd9b7e27
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/delivery/send_to_providers.py
View File

@@ -77,7 +77,9 @@ def send_sms_to_provider(notification):
notification.job_row_number,
)
except BaseException:
my_phone = redis_store.get(f"2facode_{notification.id}")
key = f"2facode-{notification.id}".replace(" ", "")
my_phone = redis_store.get(key)
if my_phone:
my_phone = my_phone.decode("utf-8")
if my_phone is None:

9
app/user/rest.py
View File

@@ -351,7 +351,14 @@ def create_2fa_code(
reply_to_text=reply_to,
)
redis_store.set(f"2facode_{saved_notification.id}", recipient, ex=1800)
key = f"2facode-{saved_notification.id}".replace(" ", "")
recipient = str(recipient)
redis_store.set(key, recipient)
stored_recipient = redis_store.get(key)
if stored_recipient:
current_app.logger.info("IN user/rest.py we saved the recipient of the 2facode to redis!")
else:
current_app.logger.info("IN user/rest.py we did NOT save the recipient of the 2facode to redis!")
# Assume that we never want to observe the Notify service's research mode
# setting for this notification - we still need to be able to log into the
# admin even if we're doing user research using this service: