darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-25 08:43:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make comment clearer following review

Browse Source
This commit is contained in:
Pea Tyczynska
2020-04-16 13:10:47 +01:00
parent a4507dbb3f
commit 470d00c26e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/dao/notifications_dao.py
View File

@@ -92,8 +92,8 @@ def dao_create_notification(notification):
def _decide_permanent_temporary_failure(current_status, status, code=None): def _decide_permanent_temporary_failure(current_status, status, code=None):
# Firetext will send pending, then send either succes or fail. # Firetext will send pending, then send either succes or fail.
# If we go from pending to failure we need to set failure type as temporary-failure # If we go from pending to failure we need to set failure type as temporary-failure,
# if we get a detailed code from firetext, we should use that code to set status instead # unless we get a detailed code from firetext. Then we should use that code to set status instead.
if current_status == NOTIFICATION_PENDING and status == NOTIFICATION_PERMANENT_FAILURE: if current_status == NOTIFICATION_PENDING and status == NOTIFICATION_PERMANENT_FAILURE:
if code: if code:
status = get_message_status_from_firetext_code(code) status = get_message_status_from_firetext_code(code)