From 470d00c26ebada5b02d7a2a99efffb05bf173098 Mon Sep 17 00:00:00 2001 From: Pea Tyczynska Date: Thu, 16 Apr 2020 13:10:47 +0100 Subject: [PATCH] Make comment clearer following review --- app/dao/notifications_dao.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/dao/notifications_dao.py b/app/dao/notifications_dao.py index d141e7422..30591bb57 100644 --- a/app/dao/notifications_dao.py +++ b/app/dao/notifications_dao.py @@ -92,8 +92,8 @@ def dao_create_notification(notification): def _decide_permanent_temporary_failure(current_status, status, code=None): # Firetext will send pending, then send either succes or fail. - # If we go from pending to failure we need to set failure type as temporary-failure - # if we get a detailed code from firetext, we should use that code to set status instead + # If we go from pending to failure we need to set failure type as temporary-failure, + # unless we get a detailed code from firetext. Then we should use that code to set status instead. if current_status == NOTIFICATION_PENDING and status == NOTIFICATION_PERMANENT_FAILURE: if code: status = get_message_status_from_firetext_code(code)