darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 08:16:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix job retrieval

Browse Source
This commit is contained in:
Kenneth Kehl
2024-08-15 17:11:31 -07:00
parent 714f6f1588
commit 438ab92fd6
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/aws/s3.py
View File

@@ -173,7 +173,7 @@ def get_job_and_metadata_from_s3(service_id, job_id):
def get_job_from_s3(service_id, job_id): def get_job_from_s3(service_id, job_id):
retries = 0 retries = 0
max_retries = 5 max_retries = 3
backoff_factor = 1 backoff_factor = 1
while retries < max_retries: while retries < max_retries:
@@ -190,11 +190,14 @@ def get_job_from_s3(service_id, job_id):
sleep_time = backoff_factor * (2**retries) # Exponential backoff sleep_time = backoff_factor * (2**retries) # Exponential backoff
time.sleep(sleep_time) time.sleep(sleep_time)
continue continue
else:
current_app.logger.error("Failed to get job from bucket", exc_info=True)
return None
except Exception as e: except Exception as e:
current_app.logger.error(f"Failed to get object from bucket {e}") current_app.logger.error(f"Failed to get job from bucket", exc_info=True)
raise return None
raise Exception("Failed to get object after 5 attempts") raise Exception("Failed to get object after 3 attempts")
def incr_jobs_cache_misses(): def incr_jobs_cache_misses():