From 438ab92fd6d92a5e3e18519ee451b34f8a4206df Mon Sep 17 00:00:00 2001
From: Kenneth Kehl <@kkehl@flexion.us>
Date: Thu, 15 Aug 2024 17:11:31 -0700
Subject: [PATCH] fix job retrieval

---
 app/aws/s3.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/app/aws/s3.py b/app/aws/s3.py
index 2b7feaf15..290203ec1 100644
--- a/app/aws/s3.py
+++ b/app/aws/s3.py
@@ -173,7 +173,7 @@ def get_job_and_metadata_from_s3(service_id, job_id):
 
 def get_job_from_s3(service_id, job_id):
     retries = 0
-    max_retries = 5
+    max_retries = 3
     backoff_factor = 1
     while retries < max_retries:
 
@@ -190,11 +190,14 @@ def get_job_from_s3(service_id, job_id):
                 sleep_time = backoff_factor * (2**retries)  # Exponential backoff
                 time.sleep(sleep_time)
                 continue
+            else:
+                current_app.logger.error("Failed to get job from bucket", exc_info=True)
+                return None
         except Exception as e:
-            current_app.logger.error(f"Failed to get object from bucket {e}")
-            raise
+            current_app.logger.error(f"Failed to get job from bucket", exc_info=True)
+            return None
 
-    raise Exception("Failed to get object after 5 attempts")
+    raise Exception("Failed to get object after 3 attempts")
 
 
 def incr_jobs_cache_misses():