darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1264 from alphagov/template-returns-placeholders

Browse Source 
Return placeholders when getting a template
This commit is contained in:
Chris Hill-Scott
2017-10-02 11:21:46 +01:00
committed by GitHub
parent f90a10ab38 55d185f50d
commit 2614d719d1
3 changed files with 108 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
tests/app/v2/template/test_get_template.py
View File

@@ -40,11 +40,81 @@ def test_get_template_by_id_returns_200(client, sample_service, tmp_type, expect
'body': template.content,
"subject": expected_subject,
'name': expected_name,
'personalisation': {},
}
assert json_response == expected_response
@pytest.mark.parametrize("create_template_args, expected_personalisation", [
(
{
"template_type": SMS_TYPE,
"content": "Hello ((placeholder)) ((conditional??yes))",
},
{
"placeholder": {
"required": True
},
"conditional": {
"required": True
},
},
),
(
{
"template_type": EMAIL_TYPE,
"subject": "((subject))",
"content": "((content))",
},
{
"subject": {
"required": True
},
"content": {
"required": True
},
},
),
(
{
"template_type": LETTER_TYPE,
"subject": "((letterSubject))",
"content": "((letter_content))",
},
{
"letterSubject": {
"required": True,
},
"letter_content": {
"required": True,
},
"contact block": {
"required": True,
},
},
)
])
@pytest.mark.parametrize("version", valid_version_params)
def test_get_template_by_id_returns_placeholders(
client,
sample_service_custom_letter_contact_block,
version,
create_template_args,
expected_personalisation,
):
template = create_template(sample_service_custom_letter_contact_block, **create_template_args)
auth_header = create_authorization_header(service_id=sample_service_custom_letter_contact_block.id)
version_path = '/version/{}'.format(version) if version else ''
response = client.get(path='/v2/template/{}{}'.format(template.id, version_path),
headers=[('Content-Type', 'application/json'), auth_header])
json_response = json.loads(response.get_data(as_text=True))
assert json_response['personalisation'] == expected_personalisation
def test_get_template_with_non_existent_template_id_returns_404(client, fake_uuid, sample_service):
auth_header = create_authorization_header(service_id=sample_service.id)