Merge pull request #848 from alphagov/add-dvla-provider

Added the provider details for DVLA.

migrations/versions/0066_add_dvla_provider.py

@@ -0,0 +1,31 @@
+"""empty message
+
+Revision ID: 0066_add_dvla_provider
+Revises: 0065_users_current_session_id
+Create Date: 2017-03-02 10:32:28.984947
+
+"""
+import uuid
+from datetime import datetime
+
+revision = '0066_add_dvla_provider'
+down_revision = '0065_users_current_session_id'
+
+from alembic import op
+
+
+def upgrade():
+    provider_id = str(uuid.uuid4())
+    op.execute(
+        "INSERT INTO provider_details (id, display_name, identifier, priority, notification_type, active, version) values ('{}', 'DVLA', 'dvla', 50, 'letter', true, 1)".format(provider_id)
+    )
+    op.execute(
+        "INSERT INTO provider_details_history (id, display_name, identifier, priority, notification_type, active, version) values ('{}', 'DVLA', 'dvla', 50, 'letter', true, 1)".format(provider_id)
+    )
+    op.execute("INSERT INTO provider_rates (id, valid_from, rate, provider_id) VALUES ('{}', '{}', 1.0, '{}')".format(uuid.uuid4(), datetime.utcnow(), provider_id))
+
+
+def downgrade():
+    op.execute("DELETE FROM provider_rates where provider_id = (SELECT id from provider_details where display_name='DVLA')")
+    op.execute("DELETE FROM provider_details_history where display_name = 'DVLA'")
+    op.execute("DELETE FROM provider_details where display_name = 'DVLA'")

tests/app/dao/test_provider_details_dao.py

@@ -31,7 +31,7 @@ def set_primary_sms_provider(identifier):
 
 
 def test_can_get_all_providers(restore_provider_details):
-    assert len(get_provider_details()) == 4
+    assert len(get_provider_details()) == 5
 
 
 def test_can_get_sms_providers(restore_provider_details):

tests/app/provider_details/test_rest.py

@@ -13,12 +13,13 @@ def test_get_provider_details_in_type_and_identifier_order(client, notify_db):
     )
     assert response.status_code == 200
     json_resp = json.loads(response.get_data(as_text=True))['provider_details']
-    assert len(json_resp) == 4
+    assert len(json_resp) == 5
 
     assert json_resp[0]['identifier'] == 'ses'
     assert json_resp[1]['identifier'] == 'mmg'
     assert json_resp[2]['identifier'] == 'firetext'
     assert json_resp[3]['identifier'] == 'loadtesting'
+    assert json_resp[4]['identifier'] == 'dvla'
 
 
 def test_get_provider_details_by_id(client, notify_db):