darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-04-12 05:09:35 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update Notification history if there is a mismatch in the number of notifications to be updated and the number actually updated.

Browse Source
This commit is contained in:
Rebecca Law
2019-05-15 15:30:15 +01:00
parent 82d8c7014d
commit 198fd21f7e
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/notifications_dao.py
View File

@@ -526,7 +526,7 @@ def dao_update_notifications_by_reference(references, update_dict):
)
updated_history_count = 0
if updated_count == 0:
if updated_count != len(references):
updated_history_count = NotificationHistory.query.filter(
NotificationHistory.reference.in_(references)
).update(

19
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -1523,6 +1523,25 @@ def test_dao_update_notifications_by_reference_set_returned_letter_status(sample
assert Notification.query.get(notification.id).status == 'returned-letter'
def test_dao_update_notifications_by_reference_updates_history_when_one_of_two_notifications_exists(
sample_letter_template
):
notification1 = create_notification(template=sample_letter_template, reference='ref1')
notification2 = create_notification(template=sample_letter_template, reference='ref2')
Notification.query.filter_by(id=notification1.id).delete()
NotificationHistory.query.filter_by(id=notification2.id).delete()
updated_count, updated_history_count = dao_update_notifications_by_reference(
references=['ref1', 'ref2'],
update_dict={"status": "returned-letter"}
)
assert updated_count == 1
assert updated_history_count == 1
assert Notification.query.get(notification2.id).status == 'returned-letter'
assert NotificationHistory.query.get(notification1.id).status == 'returned-letter'
def test_dao_get_notification_by_reference_with_one_match_returns_notification(sample_letter_template, notify_db):
create_notification(template=sample_letter_template, reference='REF1')
notification = dao_get_notification_by_reference('REF1')