darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3382 from alphagov/2dp

Browse Source 
Report processing stats to 2dp rather than 1dp
This commit is contained in:
David McDonald
2021-11-26 09:48:05 +00:00
committed by GitHub
parent ad263f6172 648490bf62
commit 16ec8ccb8a
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/performance_dashboard/rest.py
View File

@@ -78,7 +78,7 @@ def transform_into_notification_by_type_json(total_notifications):
def transform_processing_time_results_to_json(processing_time_results):
j = []
for x in processing_time_results:
j.append({"date": x.date, "percentage_under_10_seconds": round(x.percentage, 1)})
j.append({"date": x.date, "percentage_under_10_seconds": x.percentage})
return j

6
tests/app/performance_dashboard/test_rest.py
View File

@@ -62,7 +62,7 @@ def test_performance_dashboard(sample_service, admin_request):
create_process_time(bst_date='2021-02-28', messages_total=15, messages_within_10_secs=14)
create_process_time(bst_date='2021-03-01', messages_total=35, messages_within_10_secs=34)
create_process_time(bst_date='2021-03-02', messages_total=15, messages_within_10_secs=14)
create_process_time(bst_date='2021-03-02', messages_total=15, messages_within_10_secs=12)
create_process_time(bst_date='2021-03-03', messages_total=15, messages_within_10_secs=14)
results = admin_request.get(endpoint="performance_dashboard.get_performance_dashboard",
@@ -75,8 +75,8 @@ def test_performance_dashboard(sample_service, admin_request):
assert results['letter_notifications'] == 2+3+10+15
assert results['notifications_by_type'] == [{"date": '2021-03-01', "emails": 15, "sms": 20, "letters": 3},
{"date": '2021-03-02', "emails": 25, "sms": 30, "letters": 10}]
assert results['processing_time'] == [{"date": "2021-03-01", "percentage_under_10_seconds": 97.1},
{"date": "2021-03-02", "percentage_under_10_seconds": 93.3}]
assert results['processing_time'] == [{"date": "2021-03-01", "percentage_under_10_seconds": 97.1428571428571},
{"date": "2021-03-02", "percentage_under_10_seconds": 80.0}]
assert results["live_service_count"] == 1
assert results["services_using_notify"][0]["service_name"] == sample_service.name
assert not results["services_using_notify"][0]["organisation_name"]