Combine query filters when getting scheduled job

> filter_by and filter are just aliases for each other so can be
> combined together - filter is probably the better one (and then use
> == instead of keyword args)
This commit is contained in:
Chris Hill-Scott
2016-09-02 12:20:28 +01:00
parent 4a7267be8b
commit 11a4b18451

View File

@@ -46,8 +46,12 @@ def dao_get_scheduled_jobs():
def dao_get_future_scheduled_job_by_id_and_service_id(job_id, service_id):
return Job.query \
.filter_by(service_id=service_id, id=job_id) \
.filter(Job.job_status == 'scheduled', Job.scheduled_for > datetime.utcnow()) \
.filter(
Job.service_id == service_id,
Job.id == job_id,
Job.job_status == 'scheduled',
Job.scheduled_for > datetime.utcnow()
) \
.one()