darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-05-05 16:48:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2186 from alphagov/make-dvla-table-fields-required

Browse Source 
Make name and filename fields of DVLAOrganisation non-nullable
This commit is contained in:
Katie Smith
2018-10-25 14:32:12 +01:00
committed by GitHub
parent 5a627e2077 4c630ba2e2
commit 0ce1365305
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models.py
View File

@@ -246,8 +246,8 @@ DVLA_ORG_LAND_REGISTRY = '500'
class DVLAOrganisation(db.Model):
__tablename__ = 'dvla_organisation'
id = db.Column(db.String, primary_key=True)
name = db.Column(db.String(255), nullable=True)
filename = db.Column(db.String(255), nullable=True)
name = db.Column(db.String(255), nullable=False)
filename = db.Column(db.String(255), nullable=False)
INTERNATIONAL_SMS_TYPE = 'international_sms'

23
migrations/versions/0240_dvla_org_non_nullable.py Normal file
View File

@@ -0,0 +1,23 @@
"""
Revision ID: 0240_dvla_org_non_nullable
Revises: 0239_add_edit_folder_permission
Create Date: 2018-10-25 09:16:54.602182
"""
from alembic import op
import sqlalchemy as sa
revision = '0240_dvla_org_non_nullable'
down_revision = '0239_add_edit_folder_permission'
def upgrade():
op.alter_column('dvla_organisation', 'filename', existing_type=sa.VARCHAR(length=255), nullable=False)
op.alter_column('dvla_organisation', 'name', existing_type=sa.VARCHAR(length=255), nullable=False)
def downgrade():
op.alter_column('dvla_organisation', 'name', existing_type=sa.VARCHAR(length=255), nullable=True)
op.alter_column('dvla_organisation', 'filename', existing_type=sa.VARCHAR(length=255), nullable=True)