Building tests for the tasks class

app/celery/tasks.py

@@ -1,12 +1,12 @@
-from itsdangerous import URLSafeSerializer
 from app import notify_celery, twilio_client, db, encryption
 from app.clients.sms.twilio import TwilioClientException
 from app.dao.templates_dao import get_model_templates
+from app.dao.notifications_dao import save_notification
 from app.models import Notification
 from flask import current_app
 
 
-@notify_celery.task(name="send-sms", bind="True")
+@notify_celery.task(name="send-sms")
 def send_sms(service_id, notification_id, encrypted_notification):
     notification = encryption.decrypt(encrypted_notification)
     template = get_model_templates(notification['template'])
@@ -14,7 +14,7 @@ def send_sms(service_id, notification_id, encrypted_notification):
     status = 'sent'
 
     try:
-        twilio_client.send_sms(notification, template.content)
+        twilio_client.send_sms(notification['to'], template.content)
     except TwilioClientException as e:
         current_app.logger.info(e)
         status = 'failed'
@@ -27,5 +27,4 @@ def send_sms(service_id, notification_id, encrypted_notification):
         status=status
     )
 
-    db.session.add(notification_db_object)
-    db.session.commit()
+    save_notification(notification_db_object)

app/encryption.py

@@ -10,7 +10,8 @@ class Encryption:
         self.salt = app.config.get('DANGEROUS_SALT')
 
     def encrypt(self, thing_to_encrypt):
-        return self.serializer.dumps(thing_to_encrypt, self.salt)
+        return self.serializer.dumps(thing_to_encrypt, salt=
+        self.salt)
 
     def decrypt(self, thing_to_decrypt):
         return self.serializer.loads(thing_to_decrypt, salt=self.salt)

app/notifications/rest.py

@@ -3,11 +3,9 @@ import uuid
 from flask import (
     Blueprint,
     jsonify,
-    request,
-    current_app
+    request
 )
 
-from itsdangerous import URLSafeSerializer
 from app import api_user, encryption
 from app.aws_sqs import add_notification_to_queue
 from app.dao import (templates_dao, notifications_dao)

tests/app/celery/test_tasks.py

@@ -0,0 +1,74 @@
+import uuid
+from app.celery.tasks import send_sms
+from app import twilio_client
+from app.clients.sms.twilio import TwilioClientException
+from app.dao import notifications_dao
+
+
+def test_should_send_template_to_correct_sms_provider_and_persist(sample_template, mocker):
+    notification = {
+        "template": sample_template.id,
+        "to": "+441234123123"
+    }
+    mocker.patch('app.encryption.decrypt', return_value=notification)
+    mocker.patch('app.twilio_client.send_sms')
+
+    notification_id = uuid.uuid4()
+
+    send_sms(
+        sample_template.service_id,
+        notification_id,
+        "encrypted-in-reality")
+
+    twilio_client.send_sms.assert_called_once_with("+441234123123", sample_template.content)
+    persisted_notification = notifications_dao.get_notification(sample_template.service_id, notification_id)
+    assert persisted_notification.id == notification_id
+    assert persisted_notification.to == '+441234123123'
+    assert persisted_notification.template_id == sample_template.id
+    assert persisted_notification.status == 'sent'
+
+
+def test_should_persist_notification_as_failed_if_sms_client_fails(sample_template, mocker):
+    notification = {
+        "template": sample_template.id,
+        "to": "+441234123123"
+    }
+    mocker.patch('app.encryption.decrypt', return_value=notification)
+    mocker.patch('app.twilio_client.send_sms', side_effect=TwilioClientException())
+
+    notification_id = uuid.uuid4()
+
+    send_sms(
+        sample_template.service_id,
+        notification_id,
+        "encrypted-in-reality")
+
+    twilio_client.send_sms.assert_called_once_with("+441234123123", sample_template.content)
+    persisted_notification = notifications_dao.get_notification(sample_template.service_id, notification_id)
+    assert persisted_notification.id == notification_id
+    assert persisted_notification.to == '+441234123123'
+    assert persisted_notification.template_id == sample_template.id
+    assert persisted_notification.status == 'failed'
+
+
+def test_should_not_send_sms_if_db_peristance_failed(sample_template, mocker):
+    notification = {
+        "template": sample_template.id,
+        "to": "+441234123123"
+    }
+    mocker.patch('app.encryption.decrypt', return_value=notification)
+    mocker.patch('app.twilio_client.send_sms', side_effect=TwilioClientException())
+
+    notification_id = uuid.uuid4()
+
+    send_sms(
+        sample_template.service_id,
+        notification_id,
+        "encrypted-in-reality")
+
+    twilio_client.send_sms.assert_called_once_with("+441234123123", sample_template.content)
+    persisted_notification = notifications_dao.get_notification(sample_template.service_id, notification_id)
+    assert persisted_notification.id == notification_id
+    assert persisted_notification.to == '+441234123123'
+    assert persisted_notification.template_id == sample_template.id
+    assert persisted_notification.status == 'failed'

tests/app/notifications/test_rest.py

@@ -5,7 +5,6 @@ from tests import create_authorization_header
 from flask import json
 from app.models import Service
 from app.dao.templates_dao import get_model_templates
-from mock import ANY
 
 
 def test_get_notification_by_id(notify_api, sample_notification):