darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-07-24 09:58:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2024-08-08 10:57:37 -07:00
parent 3de8a27a1a
commit 034684bbb0
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/user/rest.py
View File

@@ -638,9 +638,8 @@ def report_all_users():
"service": user[3], "service": user[3],
} }
download_users.append(new_user) download_users.append(new_user)
print(f"download_users {download_users}")
dump = json.dumps(download_users) return jsonify(data=download_users, status=200, mime_type="application/json"), 200
return jsonify(data=dump), 200
@user_blueprint.route("/<uuid:user_id>/organizations-and-services", methods=["GET"]) @user_blueprint.route("/<uuid:user_id>/organizations-and-services", methods=["GET"])

11
tests/app/user/test_rest.py
View File

@@ -1137,5 +1137,14 @@ def test_report_all_users(admin_request, mocker):
_expected_status=200, _expected_status=200,
) )
assert response == { assert response == {
"data": '[{"name": "name", "email_address": "email", "mobile_number": "phone", "service": "service"}]' "data": [
{
"name": "name",
"email_address": "email",
"mobile_number": "phone",
"service": "service",
}
],
"mime_type": "application/json",
"status": 200,
} }