From 034684bbb0b357bfc65765e698ea7204e84ca502 Mon Sep 17 00:00:00 2001
From: Kenneth Kehl <@kkehl@flexion.us>
Date: Thu, 8 Aug 2024 10:57:37 -0700
Subject: [PATCH] code review feedback

---
 app/user/rest.py            |  5 ++---
 tests/app/user/test_rest.py | 11 ++++++++++-
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/app/user/rest.py b/app/user/rest.py
index cde968065..faaca4664 100644
--- a/app/user/rest.py
+++ b/app/user/rest.py
@@ -638,9 +638,8 @@ def report_all_users():
             "service": user[3],
         }
         download_users.append(new_user)
-    print(f"download_users {download_users}")
-    dump = json.dumps(download_users)
-    return jsonify(data=dump), 200
+
+    return jsonify(data=download_users, status=200, mime_type="application/json"), 200
 
 
 @user_blueprint.route("/<uuid:user_id>/organizations-and-services", methods=["GET"])
diff --git a/tests/app/user/test_rest.py b/tests/app/user/test_rest.py
index f8482e446..4e064ca8e 100644
--- a/tests/app/user/test_rest.py
+++ b/tests/app/user/test_rest.py
@@ -1137,5 +1137,14 @@ def test_report_all_users(admin_request, mocker):
         _expected_status=200,
     )
     assert response == {
-        "data": '[{"name": "name", "email_address": "email", "mobile_number": "phone", "service": "service"}]'
+        "data": [
+            {
+                "name": "name",
+                "email_address": "email",
+                "mobile_number": "phone",
+                "service": "service",
+            }
+        ],
+        "mime_type": "application/json",
+        "status": 200,
     }