Merge pull request #2596 from alphagov/lighter-serialize-for-users

Leaner serialize for user model for displaying list of users

app/models.py

@@ -175,6 +175,14 @@ class User(db.Model):
             'state': self.state,
         }
 
+    def serialize_for_users_list(self):
+        return {
+            'id': self.id,
+            'name': self.name,
+            'email_address': self.email_address,
+            'mobile_number': self.mobile_number,
+        }
+
 
 class ServiceUser(db.Model):
     __tablename__ = 'user_to_service'

app/user/rest.py

@@ -423,7 +423,7 @@ def get_by_email():
 def find_users_by_email():
     email, errors = partial_email_data_request_schema.load(request.get_json())
     fetched_users = get_users_by_partial_email(email['email'])
-    result = [user.serialize() for user in fetched_users]
+    result = [user.serialize_for_users_list() for user in fetched_users]
     return jsonify(data=result), 200