From b2f811662d22c3024f26b861ad1137967d737046 Mon Sep 17 00:00:00 2001 From: Pea Tyczynska Date: Mon, 19 Aug 2019 13:31:29 +0100 Subject: [PATCH] Leaner serialize for user model for displaying list of users --- app/models.py | 8 ++++++++ app/user/rest.py | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/app/models.py b/app/models.py index 1879d5827..991647704 100644 --- a/app/models.py +++ b/app/models.py @@ -175,6 +175,14 @@ class User(db.Model): 'state': self.state, } + def serialize_for_users_list(self): + return { + 'id': self.id, + 'name': self.name, + 'email_address': self.email_address, + 'mobile_number': self.mobile_number, + } + class ServiceUser(db.Model): __tablename__ = 'user_to_service' diff --git a/app/user/rest.py b/app/user/rest.py index bb3a9ed9d..8a53d8b0d 100644 --- a/app/user/rest.py +++ b/app/user/rest.py @@ -423,7 +423,7 @@ def get_by_email(): def find_users_by_email(): email, errors = partial_email_data_request_schema.load(request.get_json()) fetched_users = get_users_by_partial_email(email['email']) - result = [user.serialize() for user in fetched_users] + result = [user.serialize_for_users_list() for user in fetched_users] return jsonify(data=result), 200