mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-06 11:23:48 -05:00
f3a0c505bd
Done using isort[1], with the following command:
```
isort -rc ./app ./tests
```
Adds linting to the `run_tests.sh` script to stop badly-sorted imports
getting re-introduced.
Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because
I think it gives the cleanest diffs, eg:
```
from third_party import (
lib1,
lib2,
lib3,
lib4,
)
```
1. https://pypi.python.org/pypi/isort
39 lines
788 B
Bash
Executable File
39 lines
788 B
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Run project tests
|
|
#
|
|
# NOTE: This script expects to be run from the project root with
|
|
# ./scripts/run_tests.sh
|
|
|
|
set -o pipefail
|
|
|
|
function display_result {
|
|
RESULT=$1
|
|
EXIT_STATUS=$2
|
|
TEST=$3
|
|
|
|
if [ $RESULT -ne 0 ]; then
|
|
echo -e "\033[31m$TEST failed\033[0m"
|
|
exit $EXIT_STATUS
|
|
else
|
|
echo -e "\033[32m$TEST passed\033[0m"
|
|
fi
|
|
}
|
|
|
|
if [[ -z "$VIRTUAL_ENV" ]] && [[ -d venv ]]; then
|
|
source ./venv/bin/activate
|
|
fi
|
|
|
|
flake8 .
|
|
display_result $? 1 "Code style check"
|
|
|
|
isort --check-only -rc ./app ./tests
|
|
display_result $? 2 "Import order check"
|
|
|
|
npm test
|
|
display_result $? 3 "Front end code style check"
|
|
|
|
## Code coverage
|
|
py.test -n4 --maxfail=10 --cov=app --cov-report=term-missing tests/ --junitxml=test_results.xml --strict
|
|
display_result $? 4 "Code coverage"
|