mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-04-25 03:30:53 -04:00
ef335e7601
We mostly rely on the API returning a 404 to generate 404s for trying to get things with non-UUID IDs. This is fine, except our tests often mock these API calls. So it could look like everything is working fine, except the thing your passing in might never be a valid UUID, and thus would 404 in a non-test environment. So this commit: 1. uses the `uuid` URL converter everywhere there’s something that looks like an ID in a URL parameter 2. adds a test which automates checking for 1.
59 lines
2.2 KiB
Python
59 lines
2.2 KiB
Python
from flask import render_template, url_for
|
|
from werkzeug.utils import redirect
|
|
|
|
from app import provider_client
|
|
from app.main import main
|
|
from app.main.forms import ProviderForm
|
|
from app.utils import user_is_platform_admin
|
|
|
|
|
|
@main.route("/providers")
|
|
@user_is_platform_admin
|
|
def view_providers():
|
|
providers = provider_client.get_all_providers()['provider_details']
|
|
domestic_email_providers, domestic_sms_providers, intl_sms_providers = [], [], []
|
|
for provider in providers:
|
|
if provider['notification_type'] == 'sms':
|
|
domestic_sms_providers.append(provider)
|
|
if provider.get('supports_international', None):
|
|
intl_sms_providers.append(provider)
|
|
elif provider['notification_type'] == 'email':
|
|
domestic_email_providers.append(provider)
|
|
|
|
add_monthly_traffic(domestic_sms_providers)
|
|
|
|
return render_template(
|
|
'views/providers/providers.html',
|
|
email_providers=domestic_email_providers,
|
|
domestic_sms_providers=domestic_sms_providers,
|
|
intl_sms_providers=intl_sms_providers
|
|
)
|
|
|
|
|
|
def add_monthly_traffic(domestic_sms_providers):
|
|
total_sms_sent = sum(provider['current_month_billable_sms'] for provider in domestic_sms_providers)
|
|
|
|
for provider in domestic_sms_providers:
|
|
percentage = (provider['current_month_billable_sms'] / total_sms_sent * 100) if total_sms_sent else 0
|
|
provider['monthly_traffic'] = round(percentage)
|
|
|
|
|
|
@main.route("/provider/<uuid:provider_id>/edit", methods=['GET', 'POST'])
|
|
@user_is_platform_admin
|
|
def edit_provider(provider_id):
|
|
provider = provider_client.get_provider_by_id(provider_id)['provider_details']
|
|
form = ProviderForm(active=provider['active'], priority=provider['priority'])
|
|
|
|
if form.validate_on_submit():
|
|
provider_client.update_provider(provider_id, form.priority.data)
|
|
return redirect(url_for('.view_providers'))
|
|
|
|
return render_template('views/providers/edit-provider.html', form=form, provider=provider)
|
|
|
|
|
|
@main.route("/provider/<uuid:provider_id>")
|
|
@user_is_platform_admin
|
|
def view_provider(provider_id):
|
|
versions = provider_client.get_provider_versions(provider_id)
|
|
return render_template('views/providers/provider.html', provider_versions=versions['data'])
|