c11c054323
Keyboard users select a time slot by moving to the radio for that slot, using the arrow keys, and selecting it by pressing 'space' or 'enter', like a `<select>`. We allow this by listening for 'keydown' events from the 'enter' or 'space' keys on time slot radios that are checked. Browsers fire 'click' events alongside the 'keydown' event meaning it's possible for the code that makes the selection to be run twice. We currently guard against this by checking for the `pageX` property of the event object, reasoning that a click event fired by a key press won't have a cursor position. Most browsers we support set it to `0` but it isn't always the case: https://dom-event-test.glitch.me/results.html For those browsers, the `!event.pageX` condition resolves correctly so this works. Safari and versions of Internet Explorer before 11 however, set it to a positive number. In those browsers, moving the selection between radios using the arrow keys fired a 'click' event which, in Safari and IE<11, was treated as a mouse/touch event and so confirmed the selection. This made it impossible to select a later time. These changes replace the 'click' event on time slots with an artifical one that tracks mouse/trackpad clicks by listening for a 'mousedown' followed by a 'mouseup' on a time slot. This doesn't fire on key presses so avoids the problem.
notifications-admin
GOV.UK Notify admin application.
Features of this application
- Register and manage users
- Create and manage services
- Send batch emails and SMS by uploading a CSV
- Show history of notifications
First-time setup
Brew is a package manager for OSX. The following command installs brew:
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
Languages needed
brew install node
NPM is Node's package management tool. n is a tool for managing
different versions of Node. The following installs n and uses the long term support (LTS)
version of Node.
npm install -g n
n lts
npm rebuild node-sass
The app runs within a virtual environment. We use mkvirtualenv for easier working with venvs
pip install virtualenvwrapper
mkvirtualenv -p /usr/local/bin/python3 notifications-admin
Install dependencies and build the frontend assets:
workon notifications-admin
./scripts/bootstrap.sh
Rebuilding the frontend assets
If you want the front end assets to re-compile on changes, leave this running in a separate terminal from the app
npm run watch
Create a local environment.sh file containing the following:
echo "
export NOTIFY_ENVIRONMENT='development'
export FLASK_APP=application.py
export FLASK_DEBUG=1
export WERKZEUG_DEBUG_PIN=off
"> environment.sh
AWS credentials
Your aws credentials should be stored in a folder located at ~/.aws. Follow Amazon's instructions for storing them correctly
Running the application
workon notifications-admin
./scripts/run_app.sh
Then visit localhost:6012
Updating application dependencies
requirements.txt file is generated from the requirements-app.txt in order to pin
versions of all nested dependencies. If requirements-app.txt has been changed (or
we want to update the unpinned nested dependencies) requirements.txt should be
regenerated with
make freeze-requirements
requirements.txt should be committed alongside requirements-app.txt changes.
Working with static assets
When running locally static assets are served by Flask at http://localhost:6012/static/…
When running on preview, staging and production there’s a bit more to it:
