mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-02-06 11:23:48 -05:00
6948f5f003
In response to [1]. Using window.fetch means we don't get console
logs on errors, so this simplifies the error handling, although we
need to account for some errors not being a standard error object,
such as the string we get by doing Promise.reject('error').
In making this change, I've also started addressing another comment
in the PR [2], so that we reset mocked objects after the tests.
This also switches the ordering of done(), so that it's the last
statement (in response to [3]).
In the next commit we'll check for 'response.ok', but I wanted to
keep this one simple, as it's quite a large change.
[1]: https://github.com/alphagov/notifications-admin/pull/3878#discussion_r631054187
[2]: https://github.com/alphagov/notifications-admin/pull/3878#discussion_r631060116
[3]: https://github.com/alphagov/notifications-admin/pull/3878#discussion_r631061628