5b5d4af681
The failing test here[1] does two things: 1. makes a request to /sign-out 2. calls the index route, without actually making a request This means that when the `login_manager.unauthorized_handler`[2] looks at Flask’s `request` object it gets the request context from 1., not 2., because 2. isn’t actually a request. The means it sets the value of the `next` parameter to that of the request, not of the index route. Basically at some point Flask has changed and decided that 2. isn’t a proper request, so won’t set new request context. This isn’t a realistic test because nothing would call the index function directly, it would always be as part of a request to that page. But to make the minimal change to fix the breaking tests this commit makes the check a bit more general, i.e. that the redirect is to the sign in page with any `next` parameter, not a specific `next` parameter. 1.9111a7fc86/tests/app/utils/test_user.py (L130-L138)2.9111a7fc86/app/main/views/sign_in.py (L86)
notifications-admin
GOV.UK Notify admin application - https://www.notifications.service.gov.uk/
- Register and manage users
- Create and manage services
- Send batch emails and SMS by uploading a CSV
- Show history of notifications
Setting up
Python version
At the moment we run Python 3.9 in production.
NodeJS & NPM
If you don't have NodeJS on your system, install it with homebrew.
brew install node
nvm is a tool for managing different versions of NodeJS. Follow the guidance on nvm's github repository to install it.
Once installed, run the following to switch to the version of NodeJS for this project. If you don't have that version, it should tell you how to install it.
nvm use
environment.sh
In the root directory of the application, run:
echo "
export NOTIFY_ENVIRONMENT='development'
export FLASK_APP=application.py
export FLASK_ENV=development
export WERKZEUG_DEBUG_PIN=off
"> environment.sh
AWS credentials
To run parts of the app, such as uploading letters, you will need appropriate AWS credentials. See the Wiki for more details.
To run the application
# install dependencies, etc.
make bootstrap
# run the web app
make run-flask
Then visit localhost:6012.
Any Python code changes you make should be picked up automatically in development. If you're developing JavaScript code, run npm run watch to achieve the same.
To test the application
# install dependencies, etc.
make bootstrap
# run all the tests
make test
# continuously run js tests
npm run test-watch
To run a specific JavaScript test, you'll need to copy the full command from package.json.