Rebecca Law ac0b8ed95c If the job is for letters do not add the sender_id. ...

How this happens: a user starts to send a letter job, then in another tab starts a SMS
or email job, the sender_id is set in the session. Then the user goes
back to the letter job tab and creates the job. The sender_id is set in
the metadata of the csv file, and causes an exception when trying to persist
the letter notification.

This PR adds a check to ensure the sender_id is not set for letter jobs.

This will catch a small use case where the user has multiple tabs open
and has started sending an SMS or email job, then tries to send a letter
job.

2021-04-15 13:51:48 +01:00

..

accounts

Fix /accounts page to only show trial services once

2021-03-16 15:34:35 +00:00

organisations

stop putting invite user objects in the session

2021-03-16 18:14:04 +00:00

service_settings

Remove existing broadcast permission form

2021-02-23 16:03:13 +00:00

uploads

Extract formatters into their own module

2021-01-07 11:57:30 +00:00

__init__.py

…

test_accept_invite.py

Allow users of the API to search templates by ID

2021-04-13 15:24:29 +01:00

test_activity.py

…

test_add_service.py

Use underscores to notate 1000s

2021-03-10 14:56:51 +00:00

test_agreement.py

…

test_api_integration.py

Fix the ‘revoke’ links on the API keys page

2021-03-03 15:24:38 +00:00

test_broadcast.py

Estimate number of phones in an arbitrary polygon

2021-04-12 15:45:48 +01:00

test_code_not_received.py

…

test_conversation.py

…

test_dashboard.py

Allow users of the API to search templates by ID

2021-04-13 15:24:29 +01:00

test_email_branding.py

…

test_email_preview.py

…

test_feedback.py

Fix test that fails after 5:30pm

2020-12-30 09:50:11 +00:00

test_find_services.py

Support service IDs in ‘find services by name’

2021-03-02 10:00:51 +00:00

test_find_users.py

…

test_forgot_password.py

…

test_headers.py

…

test_history.py

Don't show user as unknown for service history

2021-04-06 11:36:54 +01:00

test_inbound_sms_admin.py

…

test_index.py

Remove redundant hidden H3s

2021-03-12 17:19:50 +00:00

test_jobs.py

Add hidden text for pills on job page

2021-02-24 14:36:21 +00:00

test_letter_branding.py

…

test_letters.py

Allow users of the API to search templates by ID

2021-04-13 15:24:29 +01:00

test_manage_users.py

rename get_invited_user funcs

2021-03-12 15:59:32 +00:00

test_new_password.py

…

test_notifications.py

allow caseworkers to view letter previews

2021-02-23 16:08:03 +00:00

test_performance.py

Fix sort order on performance page

2021-03-15 10:05:46 +00:00

test_platform_admin.py

Rename usage report to billing report

2021-03-30 14:13:54 +01:00

test_providers.py

…

test_register.py

stop putting invite user objects in the session

2021-03-16 18:14:04 +00:00

test_returned_letters.py

…

test_send.py

If the job is for letters do not add the sender_id.

2021-04-15 13:51:48 +01:00

test_service_settings.py

Fix flake8 and isort errors

2021-03-08 18:48:56 +00:00

test_sign_in.py

stop putting invite user objects in the session

2021-03-16 18:14:04 +00:00

test_sign_out.py

…

test_template_folders.py

Use template-list-item selector

2021-04-14 10:30:00 +01:00

test_template_history.py

…

test_templates.py

Allow users of the API to search templates by ID

2021-04-13 15:24:29 +01:00

test_tour.py

Fix flake8 and isort errors

2021-03-08 18:48:56 +00:00

test_two_factor.py

Fix flake8 and isort errors

2021-03-08 18:48:56 +00:00

test_user_profile.py

…

test_verify.py

stop putting invite user objects in the session

2021-03-16 18:14:04 +00:00