darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-18 13:39:57 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,554 Commits 59 Branches 61 Tags
f7992b3b984faa61effede7c8cec59b15b3d5af2
Commit Graph

2556 Commits

Author SHA1 Message Date
Chris Hill-Scott
64dbae179f Merge pull request #3343 from alphagov/show-letter-upload-guidance 
Show guidance on how to upload a letter
 2020-03-11 17:35:32 +00:00
David McDonald
577091cec7 Merge pull request #3363 from alphagov/remove-user-from-service-event 
Add event for remove_user_from_service
 2020-03-10 15:49:37 +00:00
David McDonald
c248fee772 Add event for remove_user_from_service 
Follows our existing patterns of events for managing users
 2020-03-10 13:52:39 +00:00
Rebecca Law
6bd69be5d8 Merge pull request #3362 from alphagov/fix-message-too-long-error 
Fix the error message for message-too-long
 2020-03-10 13:07:13 +00:00
Rebecca Law
040da762ed Fix the error message for message-too=long 
There was a bug that displayed the error message with 2 red error boxes around the error message.
Also need another else to handle a new error message from the API, the old one can be removed after the API is deployed. But this can go first. I tested this branch with API master and the API branch with the change. I tested one off SMS and a CSV upload.
 2020-03-10 09:29:38 +00:00
Katie Smith
8c30dbfb69 Add international_letters permission to settings page 
This is a permission that can only be toggled by Platform Admin and
which requires the `letter` permission in order to be turned on.
 2020-03-09 14:17:20 +00:00
Leo Hemsted
2d8d2d712a move invite error handler to top level 
ensure we catch org errors as well as regular errors
 2020-03-06 13:20:31 +00:00
Pea Tyczynska
8a4618ffe0 Fix logo upload - we need to rewind the bytestream after we read it 2020-03-04 17:26:19 +00:00
Pea M. Tyczynska
8ecccca6c2 Merge pull request #3348 from alphagov/no-embedded-images-in-SVG-logo-files 
Do not allow to upload SVG logos with embedded raster images in them
 2020-03-04 15:41:03 +00:00
Pea Tyczynska
44519fcf8e Do not allow to upload SVG logos with embedded raster images in them 
Those are for example png or jpg images. They do not render properly.
 2020-03-04 15:35:12 +00:00
Chris Hill-Scott
b64c5ae78a Merge pull request #3344 from alphagov/uploads-navigation 
Fix navigation around uploads and jobs
 2020-03-04 12:14:08 +00:00
Leo Hemsted
8ccf97b029 Merge pull request #3339 from alphagov/remove-png-letter-logos 
don't convert letter logo svgs to pngs
 2020-03-04 10:18:19 +00:00
Chris Hill-Scott
22d1b353d5 Merge pull request #3341 from alphagov/hide-postage-validation-failed 
Don’t show the postage when validation has failed
 2020-03-03 14:37:14 +00:00
Chris Hill-Scott
3df3db1609 Fix navigation around uploads and jobs 
The uploads and jobs page should start showing in the _Uploads_ menu on
the left hand side.

If you’ve navigated to a job from the uploads page (ie you haven’t got
to that page because you’ve just sent the job) then you should see a
link back to the uploads page.
 2020-03-03 14:33:20 +00:00
Chris Hill-Scott
e155794cbc Merge pull request #3333 from alphagov/uploads-page-ready 
Redesign the uploads page to accommodate different kinds of uploads
 2020-03-03 13:44:38 +00:00
Chris Hill-Scott
f1a04d9b1e Show guidance on how to upload a letter 
Once we’ve launched the feature we want the guidance to be discoverable.
 2020-03-03 13:29:45 +00:00
Chris Hill-Scott
b236df523c Don’t show the postage when validation has failed 
The postage covers up some of the letter, so it can hide the problem. It
also implies that the letter has been put in an envelope, which will
never happen if it fails validation.

This matches what we do for uploaded letters.
 2020-03-03 12:57:43 +00:00
Leo Hemsted
a3ccd9660b don't convert letter logo svgs to pngs 
https://github.com/alphagov/notifications-template-preview/pull/371
stops using png logos when rendering png previews of templated letters.

when that is merged we no longer need to convert to pngs when we upload
a new letter logo.
 2020-03-02 18:00:26 +00:00
Chris Hill-Scott
d2d5510376 Add a search as you type form 
As in other places where we have a long list of things where you might
want to jump to a specific thing. We use this pattern where there are
more than 7 things, per the magical number 7[1]

1. https://en.wikipedia.org/wiki/The_Magical_Number_Seven,_Plus_or_Minus_Two
 2020-02-28 16:24:42 +00:00
Chris Hill-Scott
408fcf05eb Add financial year filter 
Otherwise this page will become less useful come April 1st…
 2020-02-28 12:46:50 +00:00
Chris Hill-Scott
bd9e127e57 Sum up usage for an whole organisation 
We invoice on a per organisation basis, so it’s useful to know the per
organisation figures without needing to do any spreadsheet-fu.
 2020-02-28 12:17:49 +00:00
Chris Hill-Scott
63f704c64f Fix accidental switch of previous and next 
We were showing the previous page link when we meant to show the next
page link because the variables were swapped round in the code.
 2020-02-27 17:51:01 +00:00
Chris Hill-Scott
eed5e0fdd7 Combine scheduled and already-sent jobs 
I’m hoping that if I can design something that clearly differentiates
them then we won’t need to do so by putting them in separate tables,
which then need labelling, which would clutter up the page.
 2020-02-27 17:33:41 +00:00
Pea M. Tyczynska
b6e0b7f97d Merge pull request #3307 from alphagov/send-by-email-setting 
Users now able to set the send by email setting by themselves
 2020-02-27 16:15:16 +00:00
Pea Tyczynska
a601d6e700 Send files by email on for everyone and only depending on service 
having contact details set up.

Display not set up yet for send files by email row when contact_link not set up
 2020-02-27 13:36:27 +00:00
Pea Tyczynska
02b2a890e8 Get rid of on/off page send file by email setting 2020-02-27 13:35:08 +00:00
Pea Tyczynska
b2e6d14958 Enable users to turn send file by email setting on and off 2020-02-27 11:55:09 +00:00
Rebecca Law
4b11d776ee Add usage stats to organisation page. 2020-02-26 13:24:18 +00:00
Tom Byers
9f2e1498fc Update links missed in previous work 
Includes those in:
- the static 5xx error page
- validation messaging
- guidance page about trial mode
- links used in tests

Issues raised in https://github.com/alphagov/notifications-admin/pull/3303#issuecomment-589572715
 2020-02-25 10:52:03 +00:00
Chris Hill-Scott
3dab9c2915 Refactor to make it logic clearer 
The logic around what gets shown on the uploads page was hard to follow.
This commit makes three changes to hopefully make it easier:
- remove the passing-around of a string containing the contents of a
  rendered partial
- encapsulate everything in one `show_scheduled_jobs` variable, rather
  than mixing between `scheduled_jobs` and
  `current_service.scheduled_jobs`
- adds a comment to explain why we still render `_jobs.html` even when
  we know we have no jobs
 2020-02-24 16:38:09 +00:00
Chris Hill-Scott
c20ec82cd2 Show scheduled jobs on page one of the uploads page 
This is the same thing we do for caseworking users who don’t have the
dashboard. Since we’re going to summarise scheduled jobs on the
dashboard instead of listing them they need to be listed here instead
(which is where we’ll link to from the dashboard).

Design of this will probably evolve as we work out how to style single
letter uploads and letter jobs, but that’s OK for now because no-one
has the uploads page at the moment.
 2020-02-24 16:38:07 +00:00
karlchillmaid
e13dba3763 Merge pull request #3324 from alphagov/change-forgot-to-forgotten 
Change forgot to forgotten
 2020-02-24 12:45:17 +00:00
karlchillmaid
a51cc5d4b5 Change 'forgot' to 'forgotten' 2020-02-24 11:59:07 +00:00
Tom Byers
5b306dde4d Revert "Convert all links to govuk frontend" 2020-02-24 11:56:38 +00:00
Tom Byers
97172cca30 Merge branch 'master' into convert-all-links-to-govuk-frontend 2020-02-24 10:12:58 +00:00
Tom Byers
1513cfa9e6 Update links missed in previous work 
Includes those in:
- the static 5xx error page
- validation messaging
- guidance page about trial mode
- links used in tests

Issues raised in https://github.com/alphagov/notifications-admin/pull/3303#issuecomment-589572715
 2020-02-21 13:59:04 +00:00
Leo Hemsted
106228ed09 Merge pull request #3320 from alphagov/remove-generic-400-error-page 
remove admin 400 error handler
 2020-02-21 13:08:53 +00:00
Leo Hemsted
d83250c7c2 remove the generic 400 error page handler 
it just shows a h1, so isn't helpful for people. We can re-use the 500
error page, which includes instructings "Try again later" and
instructions on what to do next (check the status page, email notify
support).

this required refactoring to ensure we can show the 500 error page while
still returning the required status code
 2020-02-21 11:58:37 +00:00
Chris Hill-Scott
74e70ed8bc Refactor summaries into model 
This lets us encapsulate some of the logic that’s currently cluttering
up the view/template layer.
 2020-02-20 11:58:57 +00:00
Chris Hill-Scott
3bbd5381c6 Revert "Revert "Restyle template statistics and received text messages"" 2020-02-18 16:16:51 +00:00
Pea M. Tyczynska
a8ca8c1835 Merge pull request #3311 from alphagov/revert-3295-restyle-template-stats 
Revert "Restyle template statistics and received text messages"
 2020-02-18 15:04:59 +00:00
Pea M. Tyczynska
e97f9f7fa4 Merge pull request #3310 from alphagov/fix-reset-password 
Fix reset password flow
 2020-02-18 15:03:11 +00:00
Chris Hill-Scott
6bdd776780 Revert "Restyle template statistics and received text messages" 2020-02-18 14:58:33 +00:00
Pea Tyczynska
3a93fe6892 Fix reset password flow 
It was broken because of mismatch in update password argument
 2020-02-18 14:50:27 +00:00
Chris Hill-Scott
a86f0a6efc Merge pull request #3295 from alphagov/restyle-template-stats 
Restyle template statistics and received text messages
 2020-02-18 14:30:06 +00:00
Pea Tyczynska
7d460fe483 Move date-checking logic to utils and unit test it 2020-02-17 11:34:25 +00:00
Pea Tyczynska
caf77341b3 Send 2fa email and move user to waiting page when they need to re-validate email access 2020-02-17 11:34:24 +00:00
Chris Hill-Scott
42373e3615 Always use smaller font size for totals 
This means the font size matches the counts on the usage section, and on
the new received text messages banner.
 2020-02-17 10:31:59 +00:00
Katie Smith
a26e8c55ef Remove unused pages with buttons 
We had two templates that contained a link styled as an old style
button but that weren't being used anywhere (one would actually give a
`500` if you tried to visit it). This removes them and the view function
for one of them (the other no longer had a view function).
 2020-02-17 08:05:05 +00:00
Chris Hill-Scott
4f32258a7b Merge pull request #3293 from alphagov/cache-returned-letter-summary 
Cache returned letter summary in Redis
 2020-02-12 13:48:51 +00:00