Fix the error message for message-too=long

There was a bug that displayed the error message with 2 red error boxes around the error message.
Also need another else to handle a new error message from the API, the old one can be removed after the API is deployed. But this can go first. I tested this branch with API master and the API branch with the change. I tested one off SMS and a CSV upload.
This commit is contained in:
Rebecca Law
2020-03-09 17:03:22 +00:00
parent 4a154fddcf
commit 040da762ed
3 changed files with 11 additions and 14 deletions

View File

@@ -907,8 +907,11 @@ def get_template_error_dict(exception):
error = 'not-allowed-to-send-to'
elif 'Exceeded send limits' in exception.message:
error = 'too-many-messages'
# the error from the api is changing for message-too-long, but we need both until the api is deployed.
elif 'Content for template has a character count greater than the limit of' in exception.message:
error = 'message-too-long'
elif 'Text messages cannot be longer than' in exception.message:
error = 'message-too-long'
else:
raise exception

View File

@@ -1,13 +1,7 @@
{% from "components/banner.html" import banner_wrapper %}
<div class="bottom-gutter">
{% call banner_wrapper(type='dangerous') %}
<h1 class='banner-title'>
Message too long
</h1>
<p>
Text messages cannot be longer than {{ SMS_CHAR_COUNT_LIMIT }} characters.
Your message is {{ template.content_count }} characters.
</p>
{% endcall %}
</div>
<h1 class='banner-title'>
Message too long
</h1>
<p>
Text messages cannot be longer than {{ SMS_CHAR_COUNT_LIMIT }} characters.
Your message is {{ template.content_count }} characters.
</p>

View File

@@ -3560,7 +3560,7 @@ TRIAL_MODE_MSG = (
'Cannot send to this recipient when service is in trial mode '
'see https://www.notifications.service.gov.uk/trial-mode'
)
TOO_LONG_MSG = 'Content for template has a character count greater than the limit of 612'
TOO_LONG_MSG = 'Text messages cannot be longer than 612 characters. Your message is 654 characters.'
SERVICE_DAILY_LIMIT_MSG = 'Exceeded send limits (1000) for today'