darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-08 23:40:44 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,693 Commits 56 Branches 60 Tags
f156373e9a7101636089078b2a3655e1167a7fcf
Commit Graph

4693 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
f156373e9a Merge pull request #1685 from alphagov/comma-error 
Update error message about commas in placeholders
 2017-12-11 11:56:45 +00:00
Chris Hill-Scott
eef66b70de Reword because ‘inbetween’ isn’t a word 2017-12-11 11:19:33 +00:00
Chris Hill-Scott
242a216c1b Update error message about commas in placeholders 
We call the yellow things ‘double brackets’ on the frontend, not fields
or placeholders. This error message was a bit out of date.

Also refactored it to use the `Field` class; this code was probably
written before `Field` was factored out of `Template`.
 2017-12-11 11:19:33 +00:00
Chris Hill-Scott
72dd0b369f Merge pull request #1698 from alphagov/pyup-update-pyexcel-xls-0.5.4-to-0.5.5 
Update pyexcel-xls to 0.5.5
 2017-12-11 11:17:58 +00:00
pyup-bot
34aca4de5b Update pyexcel-xls from 0.5.4 to 0.5.5 2017-12-11 10:41:20 +00:00
Pete Herlihy
58b999ec60 Merge pull request #1699 from alphagov/117-119 
117-119 for Cash Service MK and HMCTS Small Claims Mediation
 2017-12-11 10:38:51 +00:00
Pete Herlihy
79912166d7 117-119 for Cash Service MK and HMCTS Small Claims Mediation 
50 - 51 orgs too
 2017-12-11 10:25:23 +00:00
Chris Hill-Scott
8cc478f731 Merge pull request #1691 from alphagov/strip-spaces-sign-in 
Strip spaces from email addresses when signing in
 2017-12-08 16:21:26 +00:00
Chris Hill-Scott
bef8e8887b Strip spaces from email addresses when signing in 
If you copy and paste an email address into the sign in box, there’s a
chance you’ll also copy some leading or trailing spaces. This is
especially likely to happen if you’re doing this while using your
computer upside down.

If this happens, it never even gets as far as looking up the user,
because the form validation doesn’t consider a string with a leading
space to be a valid email address.

This commit makes sure that accidental spaces are handled, by removing
them before doing any validation or hitting the API to look up the user.
 2017-12-08 16:17:45 +00:00
kentsanggds
ac547623b1 Merge pull request #1694 from alphagov/ken-add-fast-smartypants 
Add smartypants in requirements.txt
 2017-12-07 16:21:59 +00:00
kentsanggds
3f76930dbe Add smartypants in requirements.txt 2017-12-07 16:13:30 +00:00
kentsanggds
3742beee04 Merge pull request #1693 from alphagov/ken-fix-html5lib 
Update requirements.txt to fix html5lib issue
 2017-12-07 15:49:52 +00:00
kentsanggds
1c60a4cea2 Update requirements.txt 2017-12-07 15:07:44 +00:00
kentsanggds
a3a41cfe19 Update requirements.txt to fix html5lib issue 
Update to latest version of notifications utils in order to fix issue in html5lib which is being used by bleach in utils.
 2017-12-07 14:51:57 +00:00
Pete Herlihy
2f7694559f Merge pull request #1692 from alphagov/115-117-and-48-50 
115-117 and 48-50
 2017-12-07 11:21:35 +00:00
Pete Herlihy
25600e3363 115-117 and 48-50 
West Suffolk
Marine Management Organisation

Woo Hoo.
 2017-12-07 10:26:12 +00:00
Leo Hemsted
8007650f3d Merge pull request #1688 from alphagov/pyup-update-pytest-3.3.0-to-3.3.1 
Update pytest to 3.3.1
 2017-12-06 15:21:44 +00:00
pyup-bot
ee9c94e612 Update pytest from 3.3.0 to 3.3.1 2017-12-06 01:20:53 +00:00
Leo Hemsted
42f097a37d Merge pull request #1683 from alphagov/billing-endpoints 
Remove commented out line
 2017-12-04 17:14:47 +00:00
Leo Hemsted
292350633f update tests 2017-12-04 17:08:53 +00:00
Leo Hemsted
2a28278cb8 make sure service api client doesnt expect free sms fragment 2017-12-04 16:57:00 +00:00
Leo Hemsted
b9b3d7e9f3 remove other line 2017-12-04 16:45:12 +00:00
Leo Hemsted
c366e2e44b Merge pull request #1682 from alphagov/billing-endpoints 
update free sms fragment limit via billing client instead of service
 2017-12-04 16:43:36 +00:00
Leo Hemsted
eb3d4acb45 update free sms fragment limit to go via billing client instead of service 2017-12-04 16:03:11 +00:00
Chris Hill-Scott
109832b090 Merge pull request #1680 from alphagov/no-features-signed-in 
Remove features from top nav when signed in
 2017-12-04 15:11:26 +00:00
Chris Hill-Scott
fc45acb2d4 Remove features from top nav when signed in 
Features is a sales tool. Once you’re using the product already there’s
less of a need to see it. The pages are still accessible from the
footer, and for users who aren’t signed in.
 2017-12-04 14:58:10 +00:00
Leo Hemsted
9c412a7f4e Merge pull request #1679 from alphagov/ken-add-send_letters_as_pdf-setting 
Add send letters as PDF service setting
 2017-12-04 11:59:41 +00:00
Leo Hemsted
cab61a3d0a Merge pull request #1665 from alphagov/change-csrf-token-status 
Change the CSRF error from 400 to 403
 2017-12-04 11:59:29 +00:00
Leo Hemsted
a3646254bc Merge pull request #1678 from alphagov/pyup-update-flask-login-0.4.0-to-0.4.1 
Update flask-login to 0.4.1
 2017-12-04 11:59:21 +00:00
Leo Hemsted
4a110ac839 Merge pull request #1677 from alphagov/114-115 
114-115 and 47-48 for CareCERT NHS Digital
 2017-12-04 11:58:56 +00:00
pyup-bot
5f4e7ffe6a Update flask-login from 0.4.0 to 0.4.1 2017-12-02 02:50:50 +00:00
Ken Tsang
8fb7f79e5e Add send letters as PDF service setting 2017-12-01 19:12:22 +00:00
Pete Herlihy
212ac7c0ef 114-115 and 47-48 for CareCERT NHS Digital 2017-12-01 15:28:18 +00:00
Chris Hill-Scott
eefe5d0ba5 Merge pull request #1674 from alphagov/pyup-update-awscli-1.13.0-to-1.14.2 
Update awscli to 1.14.2
 2017-12-01 14:35:35 +00:00
Chris Hill-Scott
719a8c1037 Merge pull request #1676 from alphagov/fix-nav-order-non-signed-in 
Fix order of nav when signed out
 2017-12-01 14:29:50 +00:00
Chris Hill-Scott
c7c1559697 Fix order of nav when signed out 
Got this wrong in a previous commit. Now it matches the footer (which
is the right order).
 2017-12-01 14:15:19 +00:00
Chris Hill-Scott
3c057a5131 Merge pull request #1673 from alphagov/rationalise-top-nav 
Rationalise top navigation and footer
 2017-12-01 10:44:01 +00:00
Chris Hill-Scott
413e7d4689 Merge pull request #1675 from alphagov/fix-page-titles-static 
Make page titles match <h1> tags on static pages
 2017-12-01 10:43:52 +00:00
Chris Hill-Scott
4cc455a7cc Rename Slack link 
It was quite long, and Thom wasn’t a fan of the wording.
 2017-12-01 10:28:51 +00:00
Chris Hill-Scott
7c643b7ff3 Remove headings from footer 
It doesn’t make sense to have a section called ‘Support’ which has a
link called ‘Support’ in it.

And by splitting up, and reducing the number of links in the footer,
they don’t _need_ headers – hopefully they’re self explanatory.
 2017-12-01 10:28:51 +00:00
Chris Hill-Scott
e64ca206cb Make pricing its own column in footer 
This makes the footer match the order and grouping of links in the top
navigation.
 2017-12-01 10:28:51 +00:00
Chris Hill-Scott
2369187f18 Make order of About links match features sidebar 
The links in the footer should be in the same order as those in the
sidebar of the features page. That’s the order that’s been thought about
more.
 2017-12-01 10:28:50 +00:00
Chris Hill-Scott
1817d3f091 Remove external link support in sub navigation 
This navigation will only have internal links in it.
 2017-12-01 10:28:50 +00:00
Chris Hill-Scott
b6096dbe06 Remove performance link from features nav 
The features nav is supposed to navigate your between pages in the app.
It’s very unexpected to have it open an external link.

Performance isn’t strictly a part of Support, but it’s worked having it
there for long enough that it’s probably not a bother.
 2017-12-01 10:16:40 +00:00
Chris Hill-Scott
49aa42464a Make features and documentation always visible 
These links should always appear in the header, because they’re useful
to both signed in and signed out users.
 2017-12-01 10:16:40 +00:00
Chris Hill-Scott
fd908671b0 Make page titles match <h1> tags on static pages 
This commit fixes pages where this isn’t the case, and modifies the test
to use the `client_request` fixture, which checks for this mismatch.
 2017-12-01 09:52:23 +00:00
pyup-bot
9c2764ad5b Update awscli from 1.13.0 to 1.14.2 2017-11-30 20:18:45 +00:00
Chris Hill-Scott
dcbfe5a834 Merge pull request #1672 from alphagov/113-114 
111-114 for 3 new services
 2017-11-30 17:17:33 +00:00
Pete Herlihy
4285991640 113-114 for IAC Judiciary (HMCTS) 2017-11-30 16:41:03 +00:00
Chris Hill-Scott
4b77ef0533 Merge pull request #1667 from alphagov/email-auth-pword-reset 
ensure that email auth users don't get 2fa codes when resetting passwords
 2017-11-30 15:50:24 +00:00