Commit Graph

10371 Commits

Author SHA1 Message Date
Chris Hill-Scott
ed7be81181 Merge pull request #3615 from alphagov/fix-extra-tracking
Fix extra tracking on numeric inputs
2020-09-08 13:46:58 +01:00
Pea M. Tyczynska
88a5fd56bf Merge pull request #3609 from alphagov/send-polygons-to-api
Send simple polygons to API along with areas
2020-09-08 12:23:12 +01:00
Chris Hill-Scott
abdabe4571 Fix extra tracking on numeric inputs
Since we moved to using textboxes from GOV.UK Frontend the old class
wasn’t appearing in the page.
2020-09-08 12:02:03 +01:00
David McDonald
602386bd4e Merge pull request #3612 from alphagov/pyup-scheduled-update-2020-09-07
Scheduled weekly dependency update for week 36
2020-09-08 10:17:12 +01:00
David McDonald
ef134c6b6c freeze requirments 2020-09-08 09:52:14 +01:00
pyup-bot
2fc8ce5fa0 Update eventlet from 0.26.1 to 0.27.0 2020-09-07 14:54:02 +01:00
Chris Hill-Scott
821d9f20e0 Merge pull request #3604 from alphagov/no-assert-not-called
Remove uses of .assert_not_called
2020-09-07 12:58:20 +01:00
Chris Hill-Scott
3af8ed521d Merge pull request #3594 from alphagov/fix-live-search-sub-areas
Don’t filter ‘All of’ choice with live search
2020-09-07 12:57:58 +01:00
Chris Hill-Scott
fe6feb313c Merge pull request #3611 from alphagov/line-7-address-example
Show address line 7 not postcode in example spreadsheet
2020-09-07 12:39:51 +01:00
Chris Hill-Scott
2a6c058c0f Merge pull request #3602 from alphagov/fix-chrome-autofill-font-size
Fix font-size when Chrome autofills inputs
2020-09-07 12:39:40 +01:00
Chris Hill-Scott
0459e26be9 Show address line 7 not postcode in example spreadsheet
Since the letter preview will now show address line 7, the example
spreadsheet we give should match.
2020-09-07 12:00:27 +01:00
Rebecca Law
5194eba076 Merge pull request #3466 from alphagov/international-letters-form
Let users switch international letters on and off
2020-09-07 10:02:19 +01:00
Rebecca Law
52954191fa Merge branch 'master' into international-letters-form 2020-09-07 09:45:17 +01:00
Rebecca Law
0f64d4d136 Merge pull request #3564 from alphagov/int-letters-content
Add international letter rates to pricing page
2020-09-07 08:13:43 +01:00
Pea Tyczynska
3bfe3a2bf7 Send simple polygons to API along with areas
When creating broadcast message, or updating it.
We want to send simple polygons to API so we can
later relay them to the broadcast provider.

Test that update broadcast message sends polygons correctly
2020-09-04 16:55:02 +01:00
karlchillmaid
f775e18361 Add price update date
Added Monday's date, as that's when we plan to merge and deploy.
2020-09-04 14:28:23 +01:00
Tom Byers
3bebb1fbfd Merge pull request #3607 from alphagov/add-missing-closing-tag
Add missing `</span>`
2020-09-02 16:05:59 +01:00
Tom Byers
d9655f16f5 Add missing </span>
Missed out from this PR:

https://github.com/alphagov/notifications-admin/pull/3593
2020-09-02 15:53:49 +01:00
Tom Byers
afb8669b2f Merge pull request #3597 from alphagov/fix-pill-spacing-2nd-attempt
Fix spacing in pill items
2020-09-02 11:16:40 +01:00
Tom Byers
0560066638 Change mixins-before-declarations Sass-lint rule
We write our Sass to be mobile-first, meaning we
declare the value for a property (for mobile) and
then add all other variations (for other
viewports) afterwards.

Because of this, we need mixins that produce media
queries to be able to follow declarations.

This extension to the rule is also hinted at as
good practice in the docs:

7847511b61/docs/rules/mixins-before-declarations.md
2020-09-02 10:59:31 +01:00
karlchillmaid
ae1dc14ff2 Update heading class and add ID 2020-09-01 18:36:33 +01:00
David McDonald
7e934a9e4a Merge pull request #3606 from alphagov/pyup-scheduled-update-2020-08-31
Scheduled weekly dependency update for week 35
2020-09-01 16:57:45 +01:00
David McDonald
511ed6daf0 make freeze requirements 2020-09-01 16:46:25 +01:00
Tom Byers
676a9297fe Merge pull request #3593 from alphagov/fix-link-and-button-text-across-pages
Fix link and button text across pages
2020-09-01 15:11:09 +01:00
pyup-bot
ec5a1cff12 Update shapely from 1.7.0 to 1.7.1 2020-08-31 14:54:04 +01:00
pyup-bot
96e2293d4d Update pyexcel-xls from 0.5.8 to 0.5.9 2020-08-31 14:54:03 +01:00
pyup-bot
7e898827d6 Update pyexcel from 0.6.3 to 0.6.4 2020-08-31 14:54:02 +01:00
Pea M. Tyczynska
84e3a7ffd5 Merge pull request #3601 from alphagov/only-govt-users-can-be-invited-to-broadcast-services
Broadcast: only approved domain users can be invited
2020-08-28 15:04:50 +01:00
Pea Tyczynska
e0faad6cea Only approved email domain users can be invited
to broadcast services. This is done to improve security.
2020-08-28 14:41:03 +01:00
Tom Byers
457c3336b9 Merge pull request #3603 from alphagov/fix-template-id-copy-to-clipboard
Fix comparison in api_key component
2020-08-28 13:56:58 +01:00
Chris Hill-Scott
1e55a8cbbe Remove uses of .assert_not_called
I prefer to avoid `assert_not_called`, because if I make a typo like
this, the tests will still pass:
```
    app.invite_api_client.create_invite.asset_not_called()
```

It’s harder to have a false positive with the statement written this
way:
```
    assert app.invite_api_client.create_invite.called is False
```
2020-08-28 13:26:14 +01:00
Tom Byers
aff584b933 Fix comparison in api_key component
We can't control the case of either 'name' or
'thing' so the comparison should make them both
the same.
2020-08-28 13:07:38 +01:00
Tom Byers
d446a91a8e Merge pull request #3591 from alphagov/fix-copy-to-clipboard
Fix copy to clipboard
2020-08-28 10:58:36 +01:00
Chris Hill-Scott
a1607ef6fa Fix font-size when Chrome autofills inputs
For some reason Chrome decides that using its own font declaration is
preferable to keeping the input looking as it would without autofill.

This overrides that with our bigger, better font.
2020-08-28 10:31:44 +01:00
Chris Hill-Scott
786946639b Merge pull request #3599 from alphagov/fix-autofocus
Fix the autofocus component
2020-08-28 10:15:58 +01:00
Chris Hill-Scott
344d8646a3 Merge pull request #3590 from alphagov/buffer-de-buffer
Make simplification of polygons more sophisticated
2020-08-28 10:15:49 +01:00
Chris Hill-Scott
38a95d9fdc Merge pull request #3600 from alphagov/tour-4-not-sms
Reword title of screen 4 of broadcast tour
2020-08-27 14:44:26 +01:00
Chris Hill-Scott
459b7b6018 Reword title of screen 4 of broadcast tour
We want to emphasise the difference over the similarity.
2020-08-27 11:34:21 +01:00
Chris Hill-Scott
674c27a693 Fix the autofocus component
Since moving textboxes to GOV.UK Frontend we’ve started putting the
data attribute on the `input` element itself, not a wrapper around it.

This commit updates the Javascript accordingly.
2020-08-27 08:50:28 +01:00
Chris Hill-Scott
db1f916d34 Merge pull request #3598 from alphagov/broadcast-tour-content-update
Emergency alert tour – screen 2 update
2020-08-27 08:22:42 +01:00
karlchillmaid
8913eee803 Add 'you can' for clarity and readability 2020-08-26 21:52:55 +01:00
Chris Hill-Scott
3172ed1f18 Merge pull request #3596 from alphagov/5-step-tour
Improve pacing and sequence of information in the broadcast tour
2020-08-26 16:50:46 +01:00
Chris Hill-Scott
75a145a927 Merge pull request #3580 from alphagov/alert-icon-ie11
Make SVG alert icon show in Internet Explorer 10
2020-08-26 16:50:40 +01:00
Chris Hill-Scott
7d2403e052 Merge pull request #3592 from alphagov/add-new-wrap
Make ‘Add another area’ button wrap where possible
2020-08-26 16:50:31 +01:00
Chris Hill-Scott
dbfe293b4e Improve pacing and sequence of information in the broadcast tour
This commit refines which information we show on each page.

Specifically we’re
- adding some wording (‘at exactly the same time’) to try to communicate
  the immediacy
- giving the ‘loud noises’ message it’s own screen to really draw
  attention to it
- moving the ‘no phone numbers bit’ later in the journey, and
  experimenting with explaining why that is, to make it clearer how it’s
  different to a text message
2020-08-26 16:42:52 +01:00
Tom Byers
70007fcb8f Fix spacing in pill items
At maximum zoom, the text in the items gets
cropped horizontally.

This removes the padding on their containers to
give them more space and, instead, puts it on the
content items instead.

Left-aligned content still needs some padding on
the left-hand side but centrally-aligned can grow
into the whole space.

This also reduces the padding applied below 420px
width or when the screen is zoomed below 300%.
Above that, our content needs more space between
items but below that, the space allocated to the
content is more important.
2020-08-26 16:20:43 +01:00
Chris Hill-Scott
2ede3ef8f0 Don’t filter ‘All of’ choice with live search
Because the ‘All of’ choice appears above the search field, it shouldn’t
be filtered by the search field.

We can fix this by wrapping the sub-areas in a `<div>` and make the
selector more specific.
2020-08-26 10:59:29 +01:00
Tom Byers
c12b7cbb5d Fix tests from changes to link text 2020-08-26 10:10:21 +01:00
Chris Hill-Scott
08838a9dc4 Make ‘Add another area’ button wrap where possible
Broke this while fixing the spacing between the buttons and the areas.
2020-08-26 10:03:25 +01:00
Chris Hill-Scott
64291c8c95 Remove padding on map render
We don’t need it now we’re projecting a bigger bleed.
2020-08-26 09:18:25 +01:00