Commit Graph

1811 Commits

Author SHA1 Message Date
Chris Hill-Scott
eb95bcbdb1 ‘Onto’ not ‘on to’ 2018-01-24 10:38:01 +00:00
Chris Hill-Scott
e48fe539b9 Update cookie information link…
…to a more reputable-looking site.
2018-01-24 10:36:53 +00:00
Chris Hill-Scott
05c93822e0 Add information about pricing to inbound SMS page
One of the things that came out of the support analysis was that people
were asking how much inbound SMS costs. There wasn’t a significant
volume of these requests, but the fix seems low-effort and
non-disruptive enough that we should do it.

Content by Thom.
2018-01-22 14:05:45 +00:00
Chris Hill-Scott
375e15511c Make page title match <h1>
This is what we do as convention, unless there’s a good reason not to, and is better than ’Email verification’.
2018-01-18 14:30:18 +00:00
Chris Hill-Scott
92674641ac Tell people they can close tab once email auth’d
We’ve seen people come back to this page once signed in and be confused what it’s for and how they get back to Notify.

The best way to avoid confusion is (we think) getting people to close this tab.
2018-01-18 14:30:17 +00:00
chrisw
e52921bc00 add view link in message log for letter notifications 2018-01-17 15:39:39 +00:00
Rebecca Law
86d1df2a31 Gunicorn will timeout a process after 30 seconds.
The marshmallow schema takes too long, we need to fix the performance of that first.
2018-01-17 12:47:15 +00:00
Rebecca Law
9cf392ed7f Merge branch 'master' into enable-download-link 2018-01-17 11:08:39 +00:00
Pete Herlihy
1629ca4f67 131-135 and 55-58
* Department of Agriculture, Environment and Rural Affairs – DAERA Assisted Digital
* The National Archives – The National Archives
* Falkirk Council – My Falkirk 
* Ministry of Housing, Communities & Local Government – MHCLG
2018-01-16 13:02:14 +00:00
Chris Hill-Scott
3b564b4f29 Add option for one off in request to go live
When we first made this form you couldn’t send one off messages with
Notify. It’s interesting to us because it might help identity teams who
would benefit from email auth, or other features that we build in the
future for caseworkers.
2018-01-16 11:41:47 +00:00
Chris Hill-Scott
d9a63c07a9 Refactor user permissions to use args, not list
This makes the interface a bit cleaner and less verbose.
2018-01-16 11:22:57 +00:00
Chris Hill-Scott
072f8e0f87 Make row in URL match displayed row
Spreadsheets start at row 1 (the header row), and the values don’t start
until row 2. The row numbers in our URLs start at 0, which is a concept
that only makes sense to programmers.

It’s more predictable and consistent to make the number in the URL match
the row number displayed on the page when previewing the spreadsheet.
2018-01-15 14:45:38 +00:00
Chris Hill-Scott
ba0a010d64 Link each row in the spreadsheet
We’ve heard from some users, especially those sending letters, that
they’d like to check that a spreadsheet they’ve uploaded has populated
the template correctly.

My reckon is that seeing just one row of the spreadsheet populate the
template isn’t enough to give people confidence that everything’s
working properly.

This commit adds links to all but the currently-previewed row. Clicking
that link will populate the preview with values from that row. These
pages already exist; they were created in this PR:
https://github.com/alphagov/notifications-admin/pull/1696
2018-01-15 14:45:37 +00:00
Chris Hill-Scott
b5c114b66e Remove error handling code when no errors
`ok.html` is only used if the file has no errors. Therefore there will
never been any need to highlight which rows in the file have errors.
2018-01-15 14:45:36 +00:00
Chris Hill-Scott
c68b10590d Merge branch 'master' into styleguide-l 2018-01-15 14:12:07 +00:00
Chris Hill-Scott
36f68b960a Update this file to match the other one 2018-01-15 14:11:57 +00:00
Chris Hill-Scott
27a83f6c97 Treat ‘service manual’ as a proper noun
ie capitalise it to match https://www.gov.uk/service-manual
2018-01-15 14:11:17 +00:00
Chris Hill-Scott
1260dee094 fix typo 2018-01-15 14:10:03 +00:00
Rebecca Law
8a026dfdeb The downloading of the CSV is working for as many as 190, 000 notifications.
This PR re-enables the download link and filters the notifications by templates type.
2018-01-15 12:29:03 +00:00
Chris Hill-Scott
67b54d850f Add link back to API integration from callbacks
Matches what we do on the API keys and whitelist pages.
2018-01-15 10:10:12 +00:00
Chris Hill-Scott
b3673a94a2 Link to callbacks from inbound page
If you’ve got an inbound number and are using the API you’ll probably
be interested in this new feature we’ve got. And if you do know about
it, you might not be able to find it because we’ve moved it.
2018-01-15 10:10:11 +00:00
Katie Smith
7386d5ec1c Fix 500 error from notifications/letter.json page
The letters notification page makes ajax calls to update the status - these
were failing because it's making a POST request without a CSRF token.
(The email and SMS notification pages contain a search form that includes
the hidden CSRF input, so this was only occurring with the letters
page.)

This commit adds a hidden form for the letters page which just contains
the CSRF token.
2018-01-15 09:21:12 +00:00
Chris Hill-Scott
ebd5721d42 Correct description of how service name appears
This has changed since we made prefixing text messages its own setting.
2018-01-12 16:55:54 +00:00
Rebecca Law
135b0ad131 Revert download link.
There is some inconsistencies about how it is working, that needs to be solved.
2018-01-12 16:15:53 +00:00
Pete Herlihy
c616f180c7 Updated go-live page links to email and text message guidance
Now mirrors the terms of use.
2018-01-11 15:51:11 +00:00
Pete Herlihy
7bbd16e78f Simplified to links to guidance in the service manual
Some strange pages to be linking to. Most of the things we are trying to say are now covered on this page https://www.gov.uk/service-manual/design/sending-emails-and-text-messages, so much tidier and more effective to link just to that.
2018-01-11 15:48:05 +00:00
Rebecca Law
6070e2e197 Merge branch 'master' into download_link-activity-page 2018-01-10 16:06:40 +00:00
chrisw
7271d4fbde Allow letter templates to select the default contact block from the list 2018-01-10 11:20:40 +00:00
Chris Hill-Scott
17ea920be4 Update previous/next navigation to match GOV.UK
The pagination pattern on GOV.UK changed in:
https://github.com/alphagov/static/pull/1051

We should update ours to match because:
- consistency
- the new icons looks better
2018-01-08 15:59:55 +00:00
chrisw
79355d42fb Merge branch 'master' of https://github.com/alphagov/notifications-admin into make-content-links-in-notify-consistent 2018-01-08 11:23:38 +00:00
chrisw
0a7fe52e83 make content links in Notify consistent 2018-01-05 14:45:19 +00:00
Pete Herlihy
9e70924042 128-131 and 53 to 55
* ABCi - Aneurin Bevan UHB – Aneurin Bevan University Health Board
* Research – Driver & Vehicle Standards Agency
* Tunbridge Wells Borough Council	 – Tunbridge Wells Borough Council
2018-01-05 12:32:34 +00:00
chrisw
efe90f6830 Updated service manual link on using-notify page 2018-01-05 11:52:28 +00:00
Rebecca Law
1fccb3da5e Merge branch 'master' into download_link-activity-page 2018-01-03 12:48:02 +00:00
Chris Hill-Scott
a604ed60b6 Remove value of download attribute on links
We should standardise on <a download> rather than
<a download="download"> everywhere. The value of the download attribute
tells the browser what filename to use, but is overridden by the
Content-Disposition HTTP header. Since it’s not being used, we should
remove it for the sake of disambiguation.
2018-01-02 16:52:17 +00:00
Chris Hill-Scott
85b3978061 Force example CSV to download, not open in browser
We wouldn’t wan’t anyone just seeing the raw CSV data in their browser – it isn’t clear what a user would do with it at that point. And we wouldn’t want it navigating them away from the send page, because this might cause them to lose their place.

This commit forces the file to download using the HTML5 `download` attribute:

> This attribute instructs browsers to download a URL instead of navigating to it, so the user will be prompted to save it as a local file. 

– https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-download
2018-01-02 14:06:39 +00:00
Rebecca Law
259db9c271 Put the download csv link on the activity page.
Still needs some tests, probably some refactoring as well.
2017-12-30 16:54:39 +00:00
Pete Herlihy
d24fe480fd Bumped to 128 and 53 for NCC Libraries 2017-12-28 10:46:20 +00:00
Pete Herlihy
742d9ceebc 121-127 and 51-52 orgs
DVLA DM Contact Centre	Driver & Vehicle Licensing Agency
DVLA Contact Centre Complaints	Driver & Vehicle Licensing Agency
School Admissions Buckinghamshire County Council	Buckinghamshire County Council
Submit a GAR	Home Office
G-Cloud Commercial Agreement Team	Crown Commercial Service
Tracio Fflyd	Gwynedd Council
2017-12-27 12:44:16 +00:00
Rebecca Law
ff01759cce Merge branch 'master' into letter-on-usage-page 2017-12-21 14:24:40 +00:00
Rebecca Law
2f118a78a1 Merge branch 'master' into letter-on-usage-page 2017-12-20 16:31:23 +00:00
Rebecca Law
e7f94bd007 Add a template to show letter usage if the service has the letter permission 2017-12-20 16:28:40 +00:00
Chris Hill-Scott
c6f54966bf Change tables to scroll in-page, not full screen
There were three problems with showing tables fullscreen:
- it was over-optimised for very big spreadsheets, whereas most users
  will only have a few columns in their files
- it was jarring to go from full screen and back to the normal layout
- it was a bit change for existing users, where we prefer incremental
  changes that make things better without disrupting people’s work
  (where possible)

So this commit changes the big table to scroll horizontally in the page,
not take up the full width of the page.

From the fullscreen table it keeps:
- the shimming method to keep the horizontal scrollbar at the bottom of
  the screen at all times

It introduces some more refinements to make it nicer to use:
- fixing the first column, so you always know what row you’re on
- adding shadows indicate where there is content that’s scrolled outside
  the edges of the container
2017-12-20 12:09:18 +00:00
Chris Hill-Scott
8bfb67c702 Go fullscreen for row-level errors in spreadsheets
Two bits of context:

1. As we start dealing with letters, which have more columns, it’s more
   likely that people’s spreadsheets won’t fit in our current layout.

2. We already removed the view of the template from the page that shows
   row-level errors (eg bad phone number or missing personalisation) in
   spreadsheets because you don’t need to know about the content of the
   message in order to fix the errors.

This commit goes further by removing anything that isn’t to do with
the errors, including the normal GOV.UK header and the service’s
navigation.

This means the content can go the width of the page, which means it can
be allowed to scroll horizontally without being a usability car
crash. Which means that the layout doesn’t break with a spreadsheet that
has lots of columns.
2017-12-20 12:09:18 +00:00
Chris Hill-Scott
eb395db2d6 Fix error when file has header rows but no data
Previously the error was saying ‘It needs at least one row of data, and
columns called None’.
2017-12-20 11:59:51 +00:00
Rebecca Law
b7db7debc5 Add letters to usage page.
Before this goes live need to only show letters on usage if the service has the permission.
2017-12-19 14:35:10 +00:00
Chris Hill-Scott
3a67555d4d Update callbacks.html 2017-12-18 14:14:36 +00:00
Chris Hill-Scott
3df3c61279 Fix page titles on callbacks documentation
This page is no longer just about inbound.
2017-12-18 14:13:40 +00:00
Rebecca Law
084be530a6 Merge branch 'master' into letter-on-usage-page 2017-12-18 11:02:20 +00:00
Rebecca Law
43747bd1ea Add letter usage to usage page.
Still need to add the summary info.
2017-12-15 17:28:52 +00:00