Commit Graph

4891 Commits

Author SHA1 Message Date
Chris Hill-Scott
eb95bcbdb1 ‘Onto’ not ‘on to’ 2018-01-24 10:38:01 +00:00
Chris Hill-Scott
e48fe539b9 Update cookie information link…
…to a more reputable-looking site.
2018-01-24 10:36:53 +00:00
Chris Hill-Scott
29ee391fcc Merge pull request #1807 from alphagov/better-inbound-guidance
Add information about pricing to inbound SMS page
2018-01-24 10:30:27 +00:00
Chris Hill-Scott
05c93822e0 Add information about pricing to inbound SMS page
One of the things that came out of the support analysis was that people
were asking how much inbound SMS costs. There wasn’t a significant
volume of these requests, but the fix seems low-effort and
non-disruptive enough that we should do it.

Content by Thom.
2018-01-22 14:05:45 +00:00
Chris Hill-Scott
f2934b904a Merge pull request #1806 from alphagov/stricter-phone
Be stricter about length of phone numbers
2018-01-22 13:53:33 +00:00
Chris Hill-Scott
57a80a44ba Be stricter about length of phone numbers
Brings in:
- [x] https://github.com/alphagov/notifications-utils/pull/319
2018-01-22 11:31:48 +00:00
Chris Hill-Scott
a5ee771b61 Merge pull request #1764 from gov-cjwaszczuk/master
Updated email preview to mimic sent emails
2018-01-19 12:36:17 +00:00
Chris Hill-Scott
fb28e6867c Merge branch 'master' into master 2018-01-19 12:18:17 +00:00
Leo Hemsted
2271ecf418 Merge pull request #1791 from alphagov/bank-hols
add 2018 and 2019 bank holidays
2018-01-18 15:52:58 +00:00
Leo Hemsted
e6400c43c4 Merge branch 'master' into bank-hols 2018-01-18 15:47:21 +00:00
Chris Hill-Scott
f067a39833 Merge pull request #1796 from alphagov/close-tab-hint
Tell people they can close tab once email auth’d
2018-01-18 14:36:22 +00:00
Chris Hill-Scott
375e15511c Make page title match <h1>
This is what we do as convention, unless there’s a good reason not to, and is better than ’Email verification’.
2018-01-18 14:30:18 +00:00
Chris Hill-Scott
92674641ac Tell people they can close tab once email auth’d
We’ve seen people come back to this page once signed in and be confused what it’s for and how they get back to Notify.

The best way to avoid confusion is (we think) getting people to close this tab.
2018-01-18 14:30:17 +00:00
chrisw
e6690c8a78 Updated email preview to mimic sent emails 2018-01-17 16:54:35 +00:00
Alexey Bezhan
5434d553b6 Merge pull request #1797 from alphagov/fix-deskpro-empty-user-email-error
Update utils to fix Deskpro empty user_email error
2018-01-17 16:40:04 +00:00
Alexey Bezhan
6186e92141 Update utils to fix Deskpro empty user_email error
Deskpro user_email will now use the default address from the app
configuration if `user_email` argument was set to an empty string.
2018-01-17 16:03:33 +00:00
Chris Waszczuk
2077d72e12 Merge pull request #1789 from gov-cjwaszczuk/add-preview-link-in-message-log-for-letters
Add view link in message log for letter notifications
2018-01-17 15:59:57 +00:00
chrisw
e52921bc00 add view link in message log for letter notifications 2018-01-17 15:39:39 +00:00
Alexey Bezhan
1cf47b7dac Merge pull request #1788 from alphagov/use-deskpro-client
Replace Deskpro ad-hoc requests with a client from utils
2018-01-17 14:37:34 +00:00
Alexey Bezhan
a23efc9a93 Replace Deskpro ad-hoc requests with a client from utils
Moves the duplicated calls to Deskpro to notification_utils and
rewrites feedback and service go-live requests to use the shared
client.
2018-01-17 14:31:27 +00:00
Rebecca Law
c3c3ce05d6 Merge pull request #1795 from alphagov/disable-download-link
Fix performance issue
2018-01-17 12:54:34 +00:00
Rebecca Law
86d1df2a31 Gunicorn will timeout a process after 30 seconds.
The marshmallow schema takes too long, we need to fix the performance of that first.
2018-01-17 12:47:15 +00:00
Rebecca Law
25d37167be Merge pull request #1783 from alphagov/enable-download-link
Enable the download CSV file for notifications
2018-01-17 11:12:56 +00:00
Rebecca Law
9cf392ed7f Merge branch 'master' into enable-download-link 2018-01-17 11:08:39 +00:00
Leo Hemsted
92a5dd57ba Merge pull request #1792 from alphagov/golivepage
remove free sms fragment limit from go live flow
2018-01-16 17:45:08 +00:00
Leo Hemsted
2edb1eb704 remove free sms fragment limit from go live flow 2018-01-16 17:40:31 +00:00
Chris Hill-Scott
005600c923 Merge pull request #1790 from alphagov/131-135
131-135 and 55-58
2018-01-16 13:10:08 +00:00
Pete Herlihy
1629ca4f67 131-135 and 55-58
* Department of Agriculture, Environment and Rural Affairs – DAERA Assisted Digital
* The National Archives – The National Archives
* Falkirk Council – My Falkirk 
* Ministry of Housing, Communities & Local Government – MHCLG
2018-01-16 13:02:14 +00:00
Leo Hemsted
f297beb9bc add 2018 and 2019 bank holidays
also refactor to use iso timestamps
2018-01-16 12:46:46 +00:00
Chris Hill-Scott
4aa37add5a Merge pull request #1776 from alphagov/update-request-to-go-live-new-features
Update request to go live flow with new features
2018-01-16 12:02:37 +00:00
Chris Hill-Scott
3b564b4f29 Add option for one off in request to go live
When we first made this form you couldn’t send one off messages with
Notify. It’s interesting to us because it might help identity teams who
would benefit from email auth, or other features that we build in the
future for caseworkers.
2018-01-16 11:41:47 +00:00
Chris Hill-Scott
48106f22a3 Include organisation type in request to go live
This is so we can catch organisations that are going live with the wrong
free text message allowance.
2018-01-16 11:41:47 +00:00
Chris Hill-Scott
4e99c2fb8b Merge pull request #1778 from alphagov/permissions-refactor
Refactor user permissions decorator
2018-01-16 11:41:26 +00:00
Chris Hill-Scott
e573f492db Check for unknown permissions
This guards against anyone mispelling or using the wrong words for a
permission, which could introduce unexpected or hard to catch errors.
2018-01-16 11:24:37 +00:00
Chris Hill-Scott
f2418c171c Move roles to models file
Any time we can keep code out of the view files is good. This user stuff
seems like a sensible place to put it, since we’re going to use it
there.
2018-01-16 11:23:48 +00:00
Chris Hill-Scott
d9a63c07a9 Refactor user permissions to use args, not list
This makes the interface a bit cleaner and less verbose.
2018-01-16 11:22:57 +00:00
Chris Hill-Scott
6531a0c761 Merge pull request #1784 from alphagov/link-each-recipient
Link to previews of each recipient in a spreadsheet
2018-01-16 10:42:48 +00:00
Chris Hill-Scott
784f577c4d Improve redraw performance
It’s noticeable when clicking from row to row in the spreadsheet that
the page jumps around a fair bit on load because there are a couple of
Javascript-powered components.

This commit makes sure:
- the radio select component doesn’t change height when rendering for
  the first time
- the scrollable table doesn’t show parts of the table that should be
  hidden by overflow for a fraction of second before all the JS has
  run
- the right-hand shadow on horizontally scrollable tables doesn’t fade
  in on initial page load but shows at 100% opacity immediately
2018-01-15 14:45:38 +00:00
Chris Hill-Scott
072f8e0f87 Make row in URL match displayed row
Spreadsheets start at row 1 (the header row), and the values don’t start
until row 2. The row numbers in our URLs start at 0, which is a concept
that only makes sense to programmers.

It’s more predictable and consistent to make the number in the URL match
the row number displayed on the page when previewing the spreadsheet.
2018-01-15 14:45:38 +00:00
Chris Hill-Scott
b95a7403b4 Make clickable area of link bigger
Fitt’s law[1] states that bigger click areas are quicker and easier for
people to click. Therefore we should make click areas as big as
possible, without being ambiguous about what the outcome of clicking
will be or increasing the potential for accidental clicks.

The click areas of the row numbers in the table were very small – this
commits makes them as big as the containing table cells.

Uses this technique to achieve the bigger click areas without disrupting
the layout:
http://authenticff.com/journal/css-pro-tip-expanding-clickable-area

1. https://en.wikipedia.org/wiki/Fitts%27s_law
2018-01-15 14:45:37 +00:00
Chris Hill-Scott
ba0a010d64 Link each row in the spreadsheet
We’ve heard from some users, especially those sending letters, that
they’d like to check that a spreadsheet they’ve uploaded has populated
the template correctly.

My reckon is that seeing just one row of the spreadsheet populate the
template isn’t enough to give people confidence that everything’s
working properly.

This commit adds links to all but the currently-previewed row. Clicking
that link will populate the preview with values from that row. These
pages already exist; they were created in this PR:
https://github.com/alphagov/notifications-admin/pull/1696
2018-01-15 14:45:37 +00:00
Chris Hill-Scott
b5c114b66e Remove error handling code when no errors
`ok.html` is only used if the file has no errors. Therefore there will
never been any need to highlight which rows in the file have errors.
2018-01-15 14:45:36 +00:00
Chris Hill-Scott
d8e67102fa Merge pull request #1767 from alphagov/styleguide-l
Simplified to links to guidance in the service manual
2018-01-15 14:23:04 +00:00
Chris Hill-Scott
c68b10590d Merge branch 'master' into styleguide-l 2018-01-15 14:12:07 +00:00
Chris Hill-Scott
36f68b960a Update this file to match the other one 2018-01-15 14:11:57 +00:00
Chris Hill-Scott
27a83f6c97 Treat ‘service manual’ as a proper noun
ie capitalise it to match https://www.gov.uk/service-manual
2018-01-15 14:11:17 +00:00
Chris Hill-Scott
1260dee094 fix typo 2018-01-15 14:10:03 +00:00
Chris Hill-Scott
58d242198e Merge pull request #1785 from alphagov/1771-1770-1769
Pyup updates 1771 1770 1769
2018-01-15 14:03:45 +00:00
pyup-bot
a914c2e783 Update pyexcel from 0.5.6 to 0.5.7 2018-01-15 13:53:10 +00:00
pyup-bot
b79cd42110 Update pyexcel-io from 0.5.5 to 0.5.6 2018-01-15 13:52:39 +00:00