darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-28 22:30:44 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,491 Commits 50 Branches 59 Tags
e19e68396fcf1e90bedf99b4eb0f29d44decfc2c
Commit Graph

5491 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
e19e68396f Merge pull request #2057 from alphagov/whitespace 
move strip_whitespace to utils
 2018-05-08 16:55:02 +01:00
Chris Hill-Scott
d261c556d0 Merge pull request #2065 from alphagov/email-complete-sign-in 
Improve email address input on sign in
 2018-05-08 16:54:06 +01:00
Chris Hill-Scott
952a83f23a Merge pull request #2068 from alphagov/2fa-input 
Improve 2fa code input
 2018-05-08 16:53:54 +01:00
Chris Hill-Scott
3aa688d1e5 Merge pull request #2071 from alphagov/public-agreement 
Add URLs to download the agreement without login
 2018-05-08 14:56:47 +01:00
Chris Hill-Scott
771f916630 Add URLs to download the agreement without login 
So that we can share these URLs in an email we’re sending out.
 2018-05-08 14:49:06 +01:00
Chris Hill-Scott
7aec58728e Make confirm page consistent with 2fa page 2018-05-08 14:46:07 +01:00
Chris Hill-Scott
2066b039d8 Merge pull request #2069 from alphagov/209-229-and-75-79 
Updating service count to 229 and Org count to 79
 2018-05-08 14:30:02 +01:00
Chris Hill-Scott
0e1e5ccecc Merge pull request #2070 from alphagov/manheadschool 
Adding mansheadschool to the whitelist of domains
 2018-05-08 14:29:53 +01:00
Pete Herlihy
bb7973f753 Adding a test for mansheadschool whitelisting domain 2018-05-08 11:42:04 +01:00
Pete Herlihy
653e3fcd52 Adding Manshead School to allowed domains 2018-05-08 11:40:19 +01:00
Leo Hemsted
e47a459757 Merge pull request #2066 from alphagov/mock-tests 
Make sure we always mock endpoints in tests
 2018-05-08 11:37:51 +01:00
Pete Herlihy
712600c617 Updating service count to 229 and Org count to 79 2018-05-08 11:25:23 +01:00
Leo Hemsted
4ddd3aa155 use client_request to always check the response 
this'll avoid us accidentally 503ing and ignoring it in tests where we
check for "assert my_content not present"
 2018-05-08 11:16:12 +01:00
Chris Hill-Scott
02907afce1 Refactor sms_code functionality into the class 
So it’s all in one place, not two.
 2018-05-08 11:03:01 +01:00
Chris Hill-Scott
60c56be048 Remove ConfirmMobileNumberForm 
It’s exactly the same code as `TwoFactorForm` was.
 2018-05-08 11:02:28 +01:00
Chris Hill-Scott
063f9cc081 Enable numeric keypad for text message code 
If you’re signing in on a phone, it’s easier to type the two factor code
with a numeric keypad. The most reliable way to get the numeric keypad
to show up on multiple devices is:
- `type='tel'` (not `type='number'` because that’s only meant for
  numbers, not string of digits, ie `01234` is not a number)
- `pattern='[0-9]*'`, without which it doesn’t work on iOS

Based on the guidance here:
- https://github.com/alphagov/govuk-design-system-backlog/issues/74
- https://docs.google.com/document/d/1wozIhOdt6wvlgqVReauUnlsJI-3fqUlNuQFwUI7tqAA/edit
 2018-05-08 10:55:42 +01:00
Chris Hill-Scott
4d678aec93 Give better error messages for incorrect code 
If we know the code won’t pass the validation on the API side, we might
as well tell the user before even passing it to the API.

So this commit:
- adds some more validators to the field
- rewrites the validation function on the form to actually call the
  field-level validators before hitting the API 🤦‍♂️
- refactors the tests to be parametrize, which means they can be
  shorter, easier to read, and more comprehensive
 2018-05-08 10:53:22 +01:00
Leo Hemsted
e1b71e546b move strip_whitespace to utils 
see https://github.com/alphagov/notifications-utils/pull/471
 2018-05-03 17:17:32 +01:00
Chris Hill-Scott
d9e7aa9059 Merge pull request #2064 from alphagov/pyup-update-pyexcel-io-0.5.6-to-0.5.7 
Update pyexcel-io to 0.5.7
 2018-05-03 17:01:11 +01:00
Leo Hemsted
7656d3d567 ensure create_email_branding is mocked in tests 
also fix asserts to check status codes (to make sure it's not 500)
 2018-05-03 16:33:37 +01:00
Leo Hemsted
236339435c conversations only looks for 404 errors from inbound sms 
stops masking some 503s in tests
 2018-05-03 16:33:37 +01:00
Leo Hemsted
09a8e863a4 in send flow replace suppress with try catch 
suppress was suppressing 404 errors (the happy path) - but it was also
suppressing 503s from tests where we hadn't mocked endpoints
 2018-05-03 16:33:32 +01:00
Chris Hill-Scott
c0a5855d2f Improve email address input on sign in 
- `type='email'` on the form field
- removing `autocomplete='off'` because it’s a browser feature that
  some people find useful
 2018-05-03 16:31:00 +01:00
Leo Hemsted
e8ef6fa174 don't swallow HTTP errors from create_event 
tests weren't patching out create_event (which is invoked every time a
user logs in). This was getting caught by our egress proxy on jenkins.
We didn't notice because the event handler code was swallowing all
exceptions and not re-raising.

This changes that code to no longer swallow exceptions. Since we did
that, we also need to update all the tests that test log-in to mock
the call
 2018-05-03 16:14:13 +01:00
pyup-bot
d29885f15b Update pyexcel-io from 0.5.6 to 0.5.7 2018-05-02 23:27:01 +01:00
Chris Hill-Scott
23e53a9fae Merge pull request #1992 from alphagov/add-crown-agreement 
Let users download the crown agreement
 2018-05-02 10:18:37 +01:00
Chris Hill-Scott
793842bb3b Let users download the crown agreement 
This (partially) reverts commit dca5546cbd

Depends on

- [ ] agreement being uploaded to the bucket in all environments as
      `crown.pdf`
 2018-05-02 09:54:13 +01:00
Chris Hill-Scott
714b9289b4 Merge pull request #2060 from alphagov/pyup-update-pytest-mock-1.9.0-to-1.10.0 
Update pytest-mock to 1.10.0
 2018-05-02 09:34:38 +01:00
Chris Hill-Scott
2bc1d1f6e5 Merge pull request #2040 from alphagov/gchq 
Mark agreement signed by GCHQ
 2018-05-02 09:34:26 +01:00
Chris Hill-Scott
b443c299c3 Merge pull request #2058 from alphagov/pyup-update-gunicorn-19.8.0-to-19.8.1 
Update gunicorn to 19.8.1
 2018-05-02 09:34:15 +01:00
Chris Hill-Scott
a36ecd1f9e Merge pull request #2062 from alphagov/can-show-contents 
Fix truncation message for large file
 2018-05-02 09:33:30 +01:00
Chris Hill-Scott
403d856fde Fix truncation message for large file 
We do show the initial rows now.
 2018-05-02 09:24:16 +01:00
Chris Hill-Scott
f7a7ac53e2 Merge pull request #2061 from alphagov/fix-too-many-rows-exception 
Bump utils to fix large CSV bug
 2018-05-02 09:12:36 +01:00
Chris Hill-Scott
fa3b7603f4 Bump utils to fix large CSV bug 
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/473

Changes: https://github.com/alphagov/notifications-utils/compare/27.0.0...fix-too-many-rows-exception
 2018-05-01 19:49:45 +01:00
pyup-bot
70420eded5 Update pytest-mock from 1.9.0 to 1.10.0 2018-05-01 18:43:57 +01:00
Alexey Bezhan
c9f40f63ce Merge pull request #2059 from alphagov/upload-document-permission-switch 
Add a button for switching 'upload_document' permission
 2018-05-01 17:02:11 +01:00
Alexey Bezhan
f663092cf4 Add a button for switching 'upload_document' permission 
Adds a platform admin button to the service settings to turn on/off
'upload_document' service permission. The permission allows uploading
documents to document-download-api through the post notification API
endpoint.
 2018-05-01 16:53:21 +01:00
Chris Hill-Scott
394ef265ed Merge pull request #2056 from alphagov/no-session-file-uploads 
Remove use of session storage from file upload journey
 2018-05-01 09:55:05 +01:00
Chris Hill-Scott
054f75a8ed Don’t load the check page if a job exists already 
If a user clicks ‘back’ once they’ve sent a job we don’t want them to
land on the ‘check’ page again. This would suggest that they can send
the same job again (they can’t because that `job_id` is in the database
already). That said, it’s confusing to see that page; the natural thing
is to go jump back another step, to where you uploaded the file.
 2018-05-01 09:47:05 +01:00
Chris Hill-Scott
b44074bf3a Stop writing job metadata to the session 
We’re not looking at the job metadata in the session any more (see
previous commits) so it’s safe to stop writing it.
 2018-05-01 09:47:05 +01:00
Chris Hill-Scott
8c04f8f21a Stop checking the session to see if a file’s valid 
We’re going to stop storing job metadata in the session. So we can’t
rely on it for checking whether a file is valid. That safeguard is
happening in the API instead now (because it’s looking at the metadata
stored in S3).
 2018-05-01 09:47:04 +01:00
Chris Hill-Scott
98214884d3 Stop posting job metadata to the API 
The API is looking at the S3 metadata for this information now, so
there’s no need for us to continue sending it through.
 2018-05-01 09:47:04 +01:00
Katie Smith
6ea4cf7c07 Merge pull request #1639 from alphagov/delete-senders-reply-addresses 
Allow delete email reply to address, SMS senders
 2018-05-01 09:07:53 +01:00
Katie Smith
db921896b2 Highlight the new endpoints in the appropriate navigation menus 
Added the four new endpoints to navigation.py to determine which (if
any) navigation items get highlighted when the endpoints are visited.
 2018-05-01 08:38:54 +01:00
Katie Smith
0e370d511e Update service_api_client to use new endpoints 
API now has separate endpoints to archive email reply-to addresses and
SMS senders, so we no longer need to use the endpoints for updating.
 2018-05-01 08:38:54 +01:00
Chris Hill-Scott
965bc76c42 Allow delete email reply to address, SMS senders 
For both SMS senders and email reply to addresses this commit adds:
- a delete link
- a confirmation loop

It doesn’t let users delete:
- default SMS senders or reply to addresses (they always have to have
  one)
- inbound numbers

It assumes that the API will allow updating of an attribute named
`active` on the respective database rows. It could work in a different
way. We can’t do complete deletion though because these will still be
keyed to notifications.
 2018-05-01 08:38:54 +01:00
pyup-bot
f8723bccf0 Update gunicorn from 19.8.0 to 19.8.1 2018-04-30 19:49:55 +01:00
Chris Hill-Scott
63b17001e1 Merge pull request #2041 from alphagov/👑 
Add some crown bodies who haven’t signed the MOU
 2018-04-30 17:09:04 +01:00
Leo Hemsted
b3101a08b0 Merge pull request #2037 from alphagov/strip-obscure-whitespace 
Strip obscure whitespace from form submissions
 2018-04-30 14:41:31 +01:00
Leo Hemsted
57bc9469e0 Merge pull request #2052 from alphagov/pyup-update-gunicorn-19.7.1-to-19.8.0 
Update gunicorn to 19.8.0
 2018-04-30 14:40:13 +01:00