darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-24 20:31:19 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,962 Commits 49 Branches 59 Tags
d68cc68deff7f3a6bca64aea06b117bf2bec5625
Commit Graph

5962 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
d68cc68def Make page title semi-consistent 
We tend to use ‘Add’ rather than ‘Create’ in other places.
 2018-08-23 09:52:50 +01:00
Chris Hill-Scott
9b9acfa291 Select a branding with a link, not form 
Selecting a branding just takes you to a new page, it doesn’t change
any state.

Links are generally the way you go from one page to another on the web.
 2018-08-23 09:52:50 +01:00
Chris Hill-Scott
1e28fe4ffd Remove redundant argument 
This `branding_dict` is not used in the Jinja template anywhere.
 2018-08-23 09:51:33 +01:00
Chris Hill-Scott
0e7ed2b0cf Put ‘add new’ button at top of page 
One of the most frequent tasks done on this page is adding a new
branding.

Current to do this you have to:
- scroll to the bottom
- scan for the ‘Create a new email branding’ option that visually looks
  just like all the other brandings
- submit a form

This commit makes change it to one clearly differentiated button at the
top of the page. This is consistent for how we let users add templates
and team members.
 2018-08-23 09:49:23 +01:00
Tom Byers
7d6714ed68 Add live-search visibility test for conversations 
It is only shown if the number of messages don't
fit onto the screen.
 2018-08-22 19:03:52 +01:00
Tom Byers
3bc7c1c224 Add test for live-search on templates page 
Includes addition of a mock for a list of
templates long enough to need a live-search.
 2018-08-22 19:03:52 +01:00
Tom Byers
3b4c49a2c3 Add test helper to generate service templates 2018-08-22 19:03:52 +01:00
Tom Byers
cff43abfc6 Add live-search to /email-branding page 2018-08-22 19:03:46 +01:00
Tom Byers
3ea94128c6 Add live-search to set-email-branding page 2018-08-22 19:03:38 +01:00
Tom Byers
0015f086ea Add test helper to mock email brandings 2018-08-22 18:25:02 +01:00
Tom Byers
47798b218c Make live-search into a component 2018-08-22 17:42:04 +01:00
Chris Hill-Scott
71be0eaeb4 Merge pull request #2246 from alphagov/input-not-change 
Fix colour preview not loading on page load
 2018-08-22 16:57:02 +01:00
Chris Hill-Scott
3483490f03 Fix colour preview not loading on page load 
The event was changed from `change` to `input`. The trigger was not updated accordingly.
 2018-08-22 16:51:16 +01:00
Chris Hill-Scott
6193f049f5 Merge pull request #2242 from alphagov/colour-preview-refactor 
Refactor hex colour preview Javascript
 2018-08-22 16:38:10 +01:00
Chris Hill-Scott
b10f0747ae Use input event not keyup 
The `oninput` event is a more performant way to detect changes to a
textbox’s contents (compared to `onkeydown`, `onpaste`, etc).

It’s not supported in older browsers, but since this is a likely to be
used by platform admin users only that’s OK.
 2018-08-22 16:31:05 +01:00
Chris Hill-Scott
6501105768 Refactor to not repeat lots of Jinja code 2018-08-22 16:31:05 +01:00
Chris Hill-Scott
b73e42650d Refactor hex colour preview Javascript 
This commit improves the code that previews a hex colour when setting up
or changing an email branding.

Specifically it:
- refactors the Javascript to conform to our patterns (module pattern,
  preprocessed with Gulp)
- makes the code work when there are multiple colour previews on one
  page

It also does some visual prettifying, because I couldn’t help myself…
 2018-08-22 16:31:05 +01:00
Chris Hill-Scott
864e732c38 Merge pull request #2241 from alphagov/add-colours-and-domain-to-email-branding 
New columns for email branding
 2018-08-22 16:29:42 +01:00
Rebecca Law
473c8378fc Created a method to decide which colour to pass into the notifications-utils method to preview the template. 
Removed the ServiceCreateEmailBranding form - it is identical to the other form.
 2018-08-22 12:56:08 +01:00
Chris Hill-Scott
6c8345045f Merge pull request #2245 from alphagov/bump-utils-long-letters 
Bump utils to show error message for long letters
 2018-08-22 09:41:28 +01:00
Chris Hill-Scott
2ca2176f76 Merge pull request #2205 from alphagov/pyup-update-eventlet-0.22.1-to-0.24.1 
Update eventlet to 0.24.1
 2018-08-22 09:36:46 +01:00
Chris Hill-Scott
270a563fea Bump utils to show error message for long letters 
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/518
 2018-08-22 09:32:34 +01:00
karlchillmaid
d8f5896f9d Merge pull request #2243 from alphagov/reply-to_address_label_change 
Rename 'reply-to address' in Settings
 2018-08-21 10:23:43 +01:00
Chris Hill-Scott
7530fbf731 Fix the tests and catch a few more examples 2018-08-20 18:05:46 +01:00
karlchillmaid
36e8a9b3cc Corrected the page title 
Corrected the page title to 'Data retention'
 2018-08-20 16:59:35 +01:00
karlchillmaid
60f64ee5e5 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:50:56 +01:00
karlchillmaid
e18f1727d1 'Email reply-to addresses' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:48:21 +01:00
karlchillmaid
2c635faf5f 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:46:28 +01:00
karlchillmaid
15ed2e624a 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:45:08 +01:00
karlchillmaid
fb717e6933 'Email reply-to address' updated 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:43:42 +01:00
karlchillmaid
abed956a5a 'Email reply-to address' label change 
Updated 'reply-to address' to include a hyphen
 2018-08-20 16:41:16 +01:00
Chris Hill-Scott
9e5ce87f58 Update eventlet from 0.22.1 to 0.24.1 2018-08-20 16:12:27 +01:00
Chris Hill-Scott
b8f41d5204 Merge pull request #2218 from alphagov/pyup-update-whitenoise-3.3.1-to-4.0 
Update whitenoise to 4.0
 2018-08-20 16:09:39 +01:00
Rebecca Law
3fda171f80 New columns for email branding 
Added banner_colour, single_id_colour and domain to email branding view. Now able to set the fields.

However, the new fields are not being used yet.
 2018-08-20 13:27:17 +01:00
Chris Hill-Scott
a3139cdb19 Merge pull request #2240 from fidejoseph/patch-1 
Update email_domains.yml
 2018-08-20 13:08:41 +01:00
fidejoseph
3fbe85cdf8 Update email_domains.yml 
update: hscni.net
 2018-08-20 12:14:03 +01:00
Chris Hill-Scott
752d79b89f Merge pull request #2239 from alphagov/pyup-update-pytest-3.7.1-to-3.7.2 
Update pytest to 3.7.2
 2018-08-20 11:28:12 +01:00
Chris Hill-Scott
ba2c9fca5c Merge pull request #2237 from alphagov/pyup-update-pyexcel-io-0.5.7-to-0.5.8 
Update pyexcel-io to 0.5.8
 2018-08-20 11:28:06 +01:00
Chris Hill-Scott
09aacbba0d Freeze requirements 2018-08-20 11:25:31 +01:00
pyup-bot
49b79dc8ac Update whitenoise from 3.3.1 to 4.0 2018-08-20 11:23:12 +01:00
Chris Hill-Scott
a62308b10f Freeze requirements 2018-08-20 10:29:30 +01:00
pyup-bot
6071c98031 Update pyexcel-io from 0.5.7 to 0.5.8 2018-08-20 10:27:24 +01:00
pyup-bot
2a06748a32 Update pytest from 3.7.1 to 3.7.2 2018-08-18 16:46:56 +01:00
Pete Herlihy
b6d56af9d4 Merge pull request #2238 from alphagov/new-domains 
Adding derrystrabane.com (local council)
 2018-08-17 15:35:10 +01:00
Pete Herlihy
bbccbd8784 Adding derrystrabane.com (local council) 
For *reasons* they've gone with dot com addresses.
 2018-08-17 15:12:24 +01:00
Katie Smith
43e3ddb73a Merge pull request #2233 from alphagov/increase-sms-length 
Increase SMS maximum length from 459 to 612
 2018-08-17 14:03:29 +01:00
Katie Smith
a38c8ebf64 Merge pull request #2229 from alphagov/format-platform-admin-numbers 
Improve number formatting on platform-admin page
 2018-08-17 14:03:14 +01:00
Katie Smith
6b5eaf7fff Improve number formatting on platform-admin page 
Minor changes to the number formatting for the `/platform-admin` page to
- Show the complaint percentage to 2 decimal places. (The number of
complaints is often below 0.0% so 1 decimal place isn't useful)
- Format the numbers in the status boxes to use a comma as a thousands
separator.
 2018-08-16 16:57:02 +01:00
Katie Smith
1b6c357dea Use new value of SMS_CHAR_COUNT_LIMIT from utils 
Admin, API and utils were all defining a value for SMS_CHAR_COUNT_LIMIT.
This value has been updated in notifications-utils to allow text
messages to be 4 fragments long and notifications-admin now gets the value of
SMS_CHAR_COUNT_LIMIT from notifications-utils instead of defining it in
config.
 2018-08-16 16:56:32 +01:00
Katie Smith
cdd828da20 Bump utils to version 30.1.0 
Bumped notifications-utils to bring in the new value for
`SMS_CHAR_COUNT_LIMIT`
 2018-08-16 16:56:32 +01:00