darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-16 03:10:16 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,338 Commits 60 Branches 61 Tags
c9b2211bd349e24b64c095bfc781cd0028fdf724
Commit Graph

4338 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
c9b2211bd3 Let users download a CSV of inbound messages 
In user research, we’ve seen users copy/pasting the contents of the
inbound SMS page into a spreadsheet, in order to keep a record of the
messages they receive. They even went as far as to write a macro which
fixed the errors caused by copying and pasting.

It would be much easier if we just gave them the data already in a
spreadsheet format. Which is what this commit does.

One caveat is that, because spreadsheets can contain executable code (ie
formulas), and because we’re populating the spreadsheet with
user-submitted data (albeit via SMS) we need to be careful about
injection attacks.

The details of how these attacks work are detailed here (interesting
reading): http://georgemauer.net/2017/10/07/csv-injection.html

The mitigation is to not allow characters which initialise a formula
at the start of the cell.
 2017-10-18 10:27:37 +01:00
Chris Hill-Scott
ad8a35b045 Merge pull request #1545 from alphagov/digit-spacing 
Add some letter spacing to textboxes that accept digits
 2017-10-17 17:07:05 +01:00
Chris Hill-Scott
a7a19fdf5b Merge pull request #1544 from alphagov/remove-html-validation 
Remove HTML5 validation
 2017-10-17 17:06:52 +01:00
Chris Hill-Scott
6baa9fe327 Merge pull request #1542 from alphagov/track-all-form-errors 
Track form validation errors in Google analytics
 2017-10-17 17:06:44 +01:00
Leo Hemsted
184bd398f4 Merge pull request #1548 from alphagov/leohemsted-patch-1 
log json to stdout
 2017-10-17 15:40:20 +01:00
Leo Hemsted
819611728c log json to stdout 2017-10-17 14:23:15 +01:00
Chris Waszczuk
1493e8bd41 Merge pull request #1543 from gov-cjwaszczuk/master 
Allow one-off email sending to select the reply-to address
 2017-10-17 11:30:29 +01:00
Pete Herlihy
d07787c992 Merge pull request #1546 from alphagov/87-88 
88-89 and 40-41
 2017-10-17 11:17:11 +01:00
chrisw
e149d0eb91 Allow one-off email sending to select the reply-to address 2017-10-17 11:15:26 +01:00
Pete Herlihy
2c53a1e2fe 88-89 and 40-41 2017-10-17 10:21:26 +01:00
Chris Hill-Scott
7fc2a5b134 Remove HTML5 validation 
This commit:
- uses WTForms email fields wherever we collect email addresses
- makes sure we don’t let the default HTML5 form validation get trigged
  (using `novalidate`[1])

We don’t want to use the default validation because:
- it looks out of place
- it’s not well supported by assistive technology

1. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#attr-novalidate
 2017-10-16 17:17:54 +01:00
Chris Hill-Scott
57069e427d Add some letter spacing to two factor textbox 
Entering, or reading back sequences of digits is easier when they’re a
bit more spaced out.

This is because we read words as shapes, but read numbers
digit-by-digit.

So this commit adjusts the tracking of the type to put a bit more space
in for textboxes that are going to accept digits.
 2017-10-16 17:12:16 +01:00
Sakis
7809a70cf3 Merge pull request #1537 from alphagov/remove-unnecessary-routes 
Drop admin-paas.* route
 2017-10-16 16:33:39 +01:00
Chris Hill-Scott
d5edb8dbfb Track form validation errors in Google analytics 
We started tracking upload errors in eb264f34b7

This has been useful.

This commit adds tracking of other form validation errors, so we can
pick up if there’s a form field that’s causing people particular
trouble.

Also had to rewrite a very old test to look for page content in a
smarter way.
 2017-10-16 15:26:21 +01:00
Chris Hill-Scott
d3ddb7cf0d Merge pull request #1541 from alphagov/wider-notify 
Open Notify to the wider public sector
 2017-10-16 14:39:33 +01:00
Chris Hill-Scott
54c320e0fa Open Notify to the wider public sector 
Notify is now available, as a pilot, to local government and the NHS. So
telling people that it’s only for government departments and agencies is
- wrong
- might stop them from signing up

The word ‘organisation’ matches what’s used on the list of services, and
on the hint text on the email field on the sign up page.
 2017-10-16 11:53:28 +01:00
Chris Hill-Scott
82e0c5c838 Merge pull request #1539 from alphagov/pyup-update-ago-0.0.9-to-0.0.92 
Update ago to 0.0.92
 2017-10-16 11:25:36 +01:00
Chris Hill-Scott
82598abd58 Merge pull request #1526 from alphagov/org-not-dept 
Rename count from ‘departments’ to ’organisations’
 2017-10-16 11:25:12 +01:00
Chris Hill-Scott
f01df65751 Rename count from ‘departments’ to ’organisations’ 
They’re not all departments.

Could also say ‘departments and agencies’ as per the Performance Platform page. Which is more accurate?
 2017-10-16 11:14:43 +01:00
pyup-bot
07d0661425 Update ago from 0.0.9 to 0.0.92 2017-10-15 02:02:12 +01:00
Athanasios Voutsadakis
54e821500b Drop admin-paas.* route 
This was introduced during the migration and is no longer needed nor
should it be used.
 2017-10-12 14:52:22 +01:00
Chris Waszczuk
311e4501c2 Merge pull request #1533 from gov-cjwaszczuk/master 
[DONT MERGE] Add multiple letter contact blocks for services from Admin app
 2017-10-12 10:13:46 +01:00
chrisw
a94415632d Add multiple letter contact blocks for services from Admin app 2017-10-12 09:47:58 +01:00
Pete Herlihy
554eaf399a Merge pull request #1536 from alphagov/84-86 
84-86 and 39 to 40 orgs...
 2017-10-10 15:36:15 +01:00
Pete Herlihy
bf4bf3282d Adding Civil Service Local News to make it 87 2017-10-10 15:35:56 +01:00
Pete Herlihy
541f32e466 84-86 and 39 to 40 orgs... 
HMCTS SENDIST (?) - and RPA
 2017-10-09 10:50:47 +01:00
Chris Hill-Scott
507ad25f23 Merge pull request #1535 from alphagov/pyup-update-pytest-xdist-1.20.0-to-1.20.1 
Update pytest-xdist to 1.20.1
 2017-10-06 09:05:37 +01:00
pyup-bot
264da26d41 Update pytest-xdist from 1.20.0 to 1.20.1 2017-10-05 21:34:58 +01:00
Chris Hill-Scott
c62ee26b15 Merge pull request #1530 from alphagov/security-features 
Adding security features to the features page
 2017-10-05 15:19:04 +01:00
Chris Hill-Scott
6ee62fa9be Merge pull request #1531 from alphagov/october-roadmap 
Updated roadmap for October 2017 onwards
 2017-10-05 15:11:30 +01:00
Pete Herlihy
e8a2fbaea4 Added link to the info risk management page 2017-10-05 15:11:16 +01:00
Pete Herlihy
ac79ee9891 Adding security features to the features page 2017-10-05 15:11:15 +01:00
Chris Hill-Scott
580da8b6dd Merge pull request #1532 from alphagov/info-risk-mgmt 
Info risk mgmt page added.
 2017-10-05 15:10:47 +01:00
Chris Hill-Scott
5a15871b88 Dashes not underscores 2017-10-05 15:00:18 +01:00
Pete Herlihy
c50989c706 Tidied up for code style 2017-10-05 14:58:25 +01:00
Pete Herlihy
27cbd699c9 Tidied up code style 2017-10-05 14:47:34 +01:00
Pete Herlihy
d418075dab Added page with the information risk management approach 2017-10-05 14:39:57 +01:00
Pete Herlihy
2fab0b4582 Added test for the route to information_risk_management page 2017-10-05 14:25:20 +01:00
Pete Herlihy
18bacab039 Added route to information_risk_management page 2017-10-05 14:24:12 +01:00
Pete Herlihy
a3f3689c31 Updated roadmap for October 2017 onwards 2017-10-05 13:58:05 +01:00
Chris Hill-Scott
0aa8c412af Merge pull request #1529 from alphagov/pyup-update-pytest-3.2.2-to-3.2.3 
Update pytest to 3.2.3
 2017-10-05 10:25:26 +01:00
pyup-bot
a0c7eda75a Update pytest from 3.2.2 to 3.2.3 2017-10-04 22:16:59 +01:00
Chris Hill-Scott
f7211b164f Merge pull request #1528 from alphagov/cf-off 
Remove cffi
 2017-10-04 11:01:21 +01:00
Chris Hill-Scott
6f2e1e1c87 Remove cffi 
It doesn’t seem to be used; tests pass without it being installed.

Was added in 10950bb8a6 with no explanation as to why it’s needed…
 2017-10-04 10:39:57 +01:00
Chris Hill-Scott
676691646c Merge pull request #1527 from alphagov/pyup-update-cffi-1.11.0-to-1.11.1 
Update cffi to 1.11.1
 2017-10-04 10:15:08 +01:00
Chris Hill-Scott
61ce4c5a02 Merge pull request #1525 from alphagov/only-mandate-mandatory-columns 
Only mandate mandatory address columns
 2017-10-04 10:14:39 +01:00
Chris Hill-Scott
775fa1ac2d Merge pull request #1524 from alphagov/key-types-and-letters 
Add note about relationship between team API key and letters
 2017-10-04 10:14:32 +01:00
pyup-bot
9f554f1e4c Update cffi from 1.11.0 to 1.11.1 2017-10-04 08:32:56 +01:00
Chris Hill-Scott
76bee708af Merge pull request #1523 from alphagov/79-84 
79 - 84
 2017-10-03 14:13:52 +01:00
Chris Hill-Scott
95f6257852 Merge pull request #1512 from alphagov/email-reply-tweaks 
Tweak email reply to pages, add IDs
 2017-10-03 14:12:56 +01:00