darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-12 05:10:45 -04:00
Code Issues Packages Projects Releases Wiki Activity
6,493 Commits 50 Branches 59 Tags
c7118a80e2aba3822c78b00a0d452ea89ab19336
Commit Graph

6493 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
c7118a80e2 Stick email status to bottom of screen 
We’ve moved away from using the expand/collapse pattern on the page
where you click ‘send’. Instead we’re putting the send button in the
sticky footer.

So it’s a bit jarring to still have the expand/collapse on the page you
see after you’ve sent an email. This commit replaces it with the sticky
footer as well.

This is only relevant for emails because:

1. Text messages are generally short enough to fit on the screen
2. We don’t show the status of letters because they don’t really change
 2018-11-22 10:20:39 +00:00
Chris Hill-Scott
a5bbabcd7b Merge pull request #2511 from alphagov/sticky-send 
Use sticky footer on the check one-off page
 2018-11-20 13:15:32 +00:00
Leo Hemsted
fda10c81a7 Merge pull request #2494 from alphagov/bump-reqs 
bump reqs
 2018-11-20 11:06:08 +00:00
Rebecca Law
ad129e92dd Merge pull request #2507 from alphagov/delete-letter-job-page 
Delete letter job page
 2018-11-20 09:57:52 +00:00
Rebecca Law
28b9adf4e0 Merge pull request #2510 from alphagov/fix-user-with-no-permissions 
Fix the permission check for users without permissions.
 2018-11-19 17:06:33 +00:00
Chris Hill-Scott
fe9cffc4d1 Merge pull request #2512 from alphagov/fix-empty-template-message 
Fix missing ‘no templates’ message
 2018-11-19 16:02:28 +00:00
Chris Hill-Scott
da80dfb6f3 Fix missing ‘no templates’ message 
This got broken because `template_folder_path` is never an empty list
any more (it always contains at least one item, _Templates_, which is
the root).
 2018-11-19 15:55:57 +00:00
Rebecca Law
dd22fa06a4 Fix the permission check for users without permissions. 
A users without permissions should be redirected to choose-templates page when signing in.
 2018-11-19 15:26:43 +00:00
Chris Hill-Scott
7e4ef84635 Put sticky footers on check one-off page 
This page is a good use case for sticky footers because the primary
action on the page would otherwise be off the bottom of the viewport.
 2018-11-19 15:26:13 +00:00
Chris Hill-Scott
9bd91ed60a Style spacing for sticky footers 
Sticky footers need slightly different spacing to sticky headers so they
look balanced. They can’t just inherit the same spacing.
 2018-11-19 15:24:02 +00:00
Chris Hill-Scott
65b1b142b0 Show full emails on check notifications page 
Because we’re going to use a sticky footer on this page we don’t need
to show the email in its collapsed form. Showing the email is only
needed to:
- fit more things on a page
- make sure a button comes up above the fold (which the sticky footer
  will solve)
 2018-11-19 15:22:34 +00:00
Chris Hill-Scott
c9908befc2 Merge pull request #2505 from alphagov/style-folder 
Style folder hierarchy in headings
 2018-11-19 15:21:57 +00:00
Chris Hill-Scott
d3e7557058 Link current level in hierarchy from manage folder 
Because that’s the page you come directly back from.
 2018-11-19 11:28:36 +00:00
Chris Hill-Scott
738043c5c4 Show path on template and manage folder pages 
So the page headings stay consistent as you click around, and make it
easy to get back where you came from.
 2018-11-19 11:28:35 +00:00
Chris Hill-Scott
d49622c5dc Style folder hierarchy in headings 
This makes the display of folders in the `<h1>` look like the prototype.

It alters the behaviour we’ve initially built here by only ever showing
a maximum of two levels of hierarchy (the current folders and its
parent).
 2018-11-19 10:50:03 +00:00
Pea (Malgorzata Tyczynska)
754ae743ca Merge pull request #2506 from alphagov/fix_delete_folder_button_breadcrumb 
Fix breadcrumbs on manage_template_folder page
 2018-11-19 10:49:28 +00:00
Pea (Malgorzata Tyczynska)
2b040afe00 Merge pull request #2501 from alphagov/update_confirm_delete_messages 
Make deletion confirmation banner messages consistent across our app
 2018-11-19 10:37:48 +00:00
Pea Tyczynska
87c92e093b Update confirmation messages for delete sms-sender and delete reply-to-email 2018-11-16 17:05:59 +00:00
Pea Tyczynska
9953229c54 Test that delete folder endpoint detects non-empty folders 2018-11-16 15:59:23 +00:00
Pea Tyczynska
69ada9a312 Hide name changing functionality when in folder deletion mode 
Also add 'back' link
Also start work on additional tests for folder deletion flow
 2018-11-16 15:58:18 +00:00
Rebecca Law
924e3aa6da Merge branch 'master' into delete-letter-job-page 2018-11-16 15:32:51 +00:00
Pea Tyczynska
7f4580cb82 Update content following review 2018-11-16 15:15:40 +00:00
Pea Tyczynska
4373987786 Fix breadcrumbs on manage_template_folder page 2018-11-16 11:21:27 +00:00
Pea Tyczynska
a43e6a8885 Make deletion confirmation banner messages consistent across our app 
Also introduce a way to provide context to a banner / flash message
that will be displayed in plain font style.
 2018-11-16 11:05:52 +00:00
Chris Hill-Scott
ce9878db91 Merge pull request #2504 from alphagov/recent-domains 
Update domains for recently new organisations
 2018-11-16 10:34:24 +00:00
Chris Hill-Scott
f58fbcf2d3 Merge pull request #2492 from alphagov/refactor-repetetive-methods 
Refactor duplicative methods
 2018-11-16 10:34:18 +00:00
Chris Hill-Scott
230ea013c6 Update domains for recently new organisations 2018-11-16 10:14:58 +00:00
Chris Hill-Scott
bc33a0411e Merge pull request #2500 from alphagov/fix-notification-page-no-message-type 
Don’t ask for data retention unless channel is known
 2018-11-15 17:23:57 +00:00
Rebecca Law
f788aab998 Remove letter jobs page 
When we first built letters you could only send them via a CSV upload, initially we needed a way to send those files to dvla per job.
We since stopped using this page. So let's delete it!
 2018-11-15 17:17:45 +00:00
Chris Hill-Scott
f3d1dc4a9c Don’t ask for data retention unless channel is known 
If the user is looking at the notifications page for all message types
(which is what we show ‘caseworkers’) then it doesn’t make sense to ask
the API for the data retention period for that message type (because
it will be `None`). Doing so causes the API to return a `404`, which
then causes the admin app to return `404`.

Passing through `None` as the value of limit days will just cause the
API to return everything in the `notifications` table, which is fine
for us.
 2018-11-15 17:17:10 +00:00
Chris Hill-Scott
f47215ddc7 Merge pull request #2499 from alphagov/redirect-signed-in-users-to-their-service 
Redirect signed-in users to their service
 2018-11-15 16:22:48 +00:00
Chris Hill-Scott
be9fb99247 Redirect signed-in users to their service 
Some users are bookmarking the sign in page for quick access to their
Notify service.

If they’re already signed in when they used this bookmark they get
redirected. However the redirect isn’t very smart, because it just takes
them to their list of services. This isn’t great if they only have one
service.

This commit redirects them to the `show_accounts_or_dashboard` endpoint
instead, which does the work to figure out which page is most useful
to show someone when they sign in.

Also changing this for `/register`, although it’s less likely that
someone will have bookmarked this page.
 2018-11-15 16:01:59 +00:00
karlchillmaid
dd72a9d333 Merge pull request #2498 from alphagov/update-roadmap 
Update roadmap – remove Q2
 2018-11-15 15:21:27 +00:00
Pea (Malgorzata Tyczynska)
1dc63bbe63 Merge pull request #2493 from alphagov/delete_folder 
Add delete folder flow
 2018-11-15 14:44:39 +00:00
Pea Tyczynska
f54c2c0dc7 Update content of deletion messages following review 2018-11-15 10:51:44 +00:00
Pea Tyczynska
2a1328a17e Check if folder is empty before calling the api 2018-11-15 10:51:44 +00:00
Pea Tyczynska
d61022e3e6 Add flash messages and error handling to delete folder flow 2018-11-15 10:51:44 +00:00
Pea Tyczynska
91d309816b Build delete folder endpoint that calls template_folders_api_client 2018-11-15 10:51:44 +00:00
Pea Tyczynska
b5c78dc552 Add delete_folder method to template folder api client 2018-11-15 10:51:44 +00:00
Pea Tyczynska
4520065af4 Add a delete folder link to manage folder page and basic delete 
endpoint
 2018-11-15 10:51:44 +00:00
karlchillmaid
e4106ef547 Update roadmap – remove Q2 
Update roadmap to remove Q2 (July-September 2018)
 2018-11-15 10:23:28 +00:00
Tom Byers
d1805e7fc0 Merge pull request #2469 from alphagov/make-current-sticky-js-generic 
Allow our sticky navs to stick to bottom as well as top
 2018-11-15 09:59:37 +00:00
Tom Byers
eeb096aa62 Add missed .stopped method to Sticky Element 2018-11-14 16:42:52 +00:00
Leo Hemsted
3551d36f32 bump reqs 2018-11-14 13:35:24 +00:00
Tom Byers
8411598390 Remove transition if element is stuck onload 
Fade-in and out for sticky elements should only be
when they move from being in-page to stuck from a
user interaction.
 2018-11-14 10:25:08 +00:00
Chris Hill-Scott
9e4abbc511 Refactor duplicative methods 
These methods were both doing the exact same thing. There may well be
others in the future that also need to do this thing.
 2018-11-14 10:16:55 +00:00
Chris Hill-Scott
7f171ba4ea Merge pull request #2462 from alphagov/api-key-sort-order 
Sort API keys alphabetically
 2018-11-14 10:13:36 +00:00
Chris Hill-Scott
ca56561da1 Merge pull request #2489 from alphagov/pre-populate-folder-rename 
Pre-populate rename folder form with current name
 2018-11-14 10:13:22 +00:00
Chris Hill-Scott
666381e23d Pre-populate rename folder form with current name 
Often people will be editing the existing name, not changing it
completely.

This matches what we do when someone wants to rename their template or
service.
 2018-11-13 16:05:05 +00:00
Chris Hill-Scott
ce798a02e4 Merge pull request #2487 from alphagov/fix-folders-ie10 
Fix templates page in IE10
 2018-11-13 15:26:13 +00:00