Commit Graph

11051 Commits

Author SHA1 Message Date
Pea Tyczynska
dcc590ec96 Cancelled notifications do not show as failures on dashboard stats
Also update tests after we no longer show cancelled letters
2019-01-10 15:27:04 +00:00
Pete Herlihy
4c8225406c Updated Essex Council contract status and added aliases 2019-01-10 14:00:54 +00:00
Chris Hill-Scott
848e88c7ca Merge pull request #2648 from alphagov/pyup-update-pytz-2018.7-to-2018.9
Update pytz to 2018.9
2019-01-10 13:48:31 +00:00
Chris Hill-Scott
05622dd4b6 Freeze requirements 2019-01-10 13:40:53 +00:00
pyup-bot
3ffe77972f Update pytz from 2018.7 to 2018.9 2019-01-10 13:34:25 +00:00
Chris Hill-Scott
b38289ddc3 Merge pull request #2647 from alphagov/cne-siar.gov.uk-signed
Mark agreement signed by Comhairle nan Eilean Siar
2019-01-10 13:34:21 +00:00
Chris Hill-Scott
63cd0a7908 Mark agreement signed by Comhairle nan Eilean Siar 2019-01-10 10:03:59 +00:00
Leo Hemsted
de694cc9b8 Merge pull request #2642 from alphagov/redis
bump utils
2019-01-09 16:10:46 +00:00
Katie Smith
ef1391f5a4 Merge pull request #2644 from alphagov/show-friendly-error-for-pdf-failures
Show better error message if precompiled letters can't be opened
2019-01-09 14:32:30 +00:00
Katie Smith
1c6a71700d Update error messages for validation-failed precompiled letters 2019-01-09 13:10:36 +00:00
Katie Smith
da50f77538 Show error message if precompiled PDF cannot be opened
If PDF files have a validation error which means that they can't be
opened by PyPDF2 we would previously show the 500 status error page. We
now catch PyPDF2.utils.PdfReadErrors so that we can display a custom
error message on the notification page instead.
2019-01-09 13:10:36 +00:00
Katie Smith
bb7e9726d3 Stop showing validation-failed letters as cancelled in table
Changed the table for displaying all notifications to show letters which
have the status of 'validation-failed' as 'Validation failed' instead of
'Cancelled'.

The individual notification page for a letter which has failed
validation has not been changed since this already has a description
(letter has content outside the printable area).
2019-01-09 13:10:36 +00:00
Chris Hill-Scott
8b39bc14d1 Merge pull request #2643 from alphagov/dont-count-pages-api-message-log
Don't request pagination links for API Message log page
2019-01-09 12:27:35 +00:00
Chris Hill-Scott
606641a35e Merge pull request #2645 from alphagov/cne-siar.gov.uk
Add Comhairle nan Eilean Siar to domains list
2019-01-09 12:26:46 +00:00
Chris Hill-Scott
a34e1ea1f0 Merge pull request #2638 from alphagov/copy-template-from-folders
Allow users to navigate folders when copying
2019-01-09 12:26:29 +00:00
Chris Hill-Scott
668b0a91b2 Add Comhairle nan Eilean Siar to domains list
Comhairle nan Eilean Siar (Scottish Gaelic pronunciation: [ˈkʰõ.ərˠʎə nə ˈɲelan ˈʃiəɾ]) is the local government council for Na h-Eileanan Siar council area of Scotland, comprising the Outer Hebrides.
2019-01-09 12:02:02 +00:00
Chris Hill-Scott
f77b101261 Merge pull request #2634 from alphagov/pyup-update-pytest-cov-2.6.0-to-2.6.1
Update pytest-cov to 2.6.1
2019-01-09 11:49:32 +00:00
Chris Hill-Scott
30886c3cdb Merge pull request #2626 from alphagov/empty-service-state-folders
Use grey buttons to add templates when service is new
2019-01-09 10:26:43 +00:00
Chris Hill-Scott
c751f6ba1f Merge pull request #2627 from alphagov/fix-zindex-template-form
Fix z-index on templates page
2019-01-09 10:25:58 +00:00
Chris Hill-Scott
13d20cf7a9 Merge pull request #2641 from alphagov/nlwed
Mark agreement signed by North Lincs, Walsall and East Dunbartonshire
2019-01-08 16:07:03 +00:00
Alexey Bezhan
6cd18f87de Don't request pagination links for API Message log page
Counting pages for API notifications takes a long time for services
with a lot of sent messages (since it issues a `count(*)` query for
the given filter). Since API message log doesn't have a "Next page"
link we can skip the count by setting a flag on the API request.
2019-01-08 15:35:44 +00:00
Chris Hill-Scott
a093b8d976 Use Babergh as the example in tests
Because Aberdeenshire have signed the agreement.
2019-01-08 15:12:52 +00:00
Chris Hill-Scott
2ef4d1c401 Resolve aliases for Ayrshire 2019-01-08 15:12:44 +00:00
Leo Hemsted
c379239a9e bump utils
brings in redis 3
2019-01-08 15:00:42 +00:00
Pete Herlihy
59f260c785 And South Ayrshire... 2019-01-08 13:59:40 +00:00
Chris Hill-Scott
61b902554f …and Aberdeenshire 2019-01-08 13:03:06 +00:00
Chris Hill-Scott
206a7806d4 Allow users to navigate folders when copying
We already have a pattern for navigation folders and searching for
templates – let’s use it for the copy page too. And I reckon we can
represent services as folders if the user has multiple services they
could copy a template from.
2019-01-08 12:21:32 +00:00
Chris Hill-Scott
a1e02d1fec Mark agreement signed by North Lincs, Walsall and East Dunbartonshire 2019-01-08 11:54:14 +00:00
Pea (Malgorzata Tyczynska)
0b22fff751 Merge pull request #2639 from alphagov/quick_fix_letter_status
Format letter statuses so they make more sense to our users
2019-01-08 11:06:35 +00:00
Chris Hill-Scott
42e1b2bc08 Merge pull request #2635 from alphagov/pyup-update-beautifulsoup4-4.7.0-to-4.7.1
Update beautifulsoup4 to 4.7.1
2019-01-07 16:16:58 +00:00
Chris Hill-Scott
c2eee08aae Merge pull request #2640 from alphagov/hounslow.gov.uk
Mark agreement signed by Hounslow council
2019-01-07 15:59:33 +00:00
Chris Hill-Scott
cbe5e77e69 Mark agreement signed by Hounslow council 2019-01-07 15:46:32 +00:00
Chris Hill-Scott
933dd1245b Merge pull request #2637 from alphagov/doncaster.gov.uk
Mark agreement signed by Doncaster Council
2019-01-07 15:42:23 +00:00
Pea Tyczynska
b8318c491b Format letter statuses so they make more sense to our users 2019-01-07 15:17:09 +00:00
Tom Byers
1685e492ca Merge pull request #2630 from alphagov/nest-destination-folders
Nest destination folders
2019-01-07 10:31:41 +00:00
Chris Hill-Scott
d13c071431 Mark agreement signed by Doncaster Council 2019-01-07 10:22:28 +00:00
pyup-bot
67685fb601 Update beautifulsoup4 from 4.7.0 to 4.7.1 2019-01-07 01:07:37 +00:00
pyup-bot
4c62a1c0a7 Update pytest-cov from 2.6.0 to 2.6.1 2019-01-07 01:07:33 +00:00
Tom Byers
bdc4a1056d Add a test to ensure move_to has no default folder
As requested in:

https://github.com/alphagov/notifications-admin/pull/2630#pullrequestreview-189414780
2019-01-04 17:21:54 +00:00
Leo Hemsted
ad904e587c Merge pull request #2631 from alphagov/utils-bump
bump utils
2019-01-04 16:37:32 +00:00
Leo Hemsted
addb54b84f bump utils
brings in alphagov/notifications-utils#563
2019-01-04 16:21:12 +00:00
Chris Hill-Scott
d907fc9ce6 Update tests/app/main/views/test_template_folders.py
Remove quotes around variable. Were added by mistake.

Co-Authored-By: tombye <tombaromba@gmail.com>
2019-01-04 15:40:34 +00:00
Chris Hill-Scott
f5321346c4 Add left padding to nested radios
This makes them align horizontally with the label of their parent, so
that the layout is a bit calmer.
2019-01-04 15:30:39 +00:00
Chris Hill-Scott
3be03072a7 Reflect expanded scope of radio SASS file 2019-01-04 15:15:59 +00:00
Chris Hill-Scott
4aa4970fc9 Add grey lines to visually show level of nesting
Uses some CSS to draw some grey lines to show which radios descend from
which.

I don’t feel like the intentation is enough, and it looks a bit messy
because the circles of the radio buttons don’t have straight edges
easily suggest visual alignment.

Copies the design from conditionally revealing content in the design
system:
https://design-system.service.gov.uk/components/radios/#conditionally-revealing-content

Implementation is done with pseudo elements, because borders can’t be
positionned exactly enough.
2019-01-04 15:15:59 +00:00
Chris Hill-Scott
39506c4794 Rename ‘All templates’ 2019-01-04 15:15:58 +00:00
Tom Byers
33800c5f27 Add styles for nested lists of radios
Assumes lists that are descendants of a radio
control should be indented at the same amount as
their label text.
2019-01-04 11:59:25 +00:00
Chris Hill-Scott
62d424b01e Merge pull request #2625 from alphagov/trailing-new-line-before-markdown
Bump utils to 30.7.2
2019-01-04 11:48:22 +00:00
Chris Hill-Scott
c1b61a3658 Merge pull request #2617 from alphagov/pytest4
Pytest 4: don't call pytest.mark directly
2019-01-04 11:48:16 +00:00
Chris Hill-Scott
0c1a797a82 Keep param on multiple lines
so it scans the same as preceeding test cases

Co-Authored-By: leohemsted <leohemsted@gmail.com>
2019-01-04 11:34:26 +00:00