Commit Graph

1931 Commits

Author SHA1 Message Date
Chris Hill-Scott
acfe87e788 Use hasattr instead of getattr
We don’t need the value returned by `getattr`, so using `hasattr` is cleaner.
2016-06-02 10:41:54 +01:00
Chris Hill-Scott
012e43549d Remove blue from column headings on send page
While the blue should help reinforce the relationship between the placeholders
and the column headings, it makes the column headings very busy visually, and
less like column headings. Which make the relationship harder to see. I think.
2016-05-31 17:07:31 +01:00
Chris Hill-Scott
6d3fbb1f51 Make example on send look more like a spreadsheet
Now that the example on the breaking changes page looks more like a spreadsheet,
we should do the same thing for the downloadable example on the send page.
2016-05-31 17:07:23 +01:00
Chris Hill-Scott
3ac76192d0 Warn users a template change will break things
When a user adds or removes placeholders in their template we should consider
this a ‘breaking change’ and warn them accordingly.

Implementing this mostly relies on using
https://github.com/alphagov/notifications-utils/pull/37

Temporarily storing the new template until the user confirms that they want to
make the changes in done using hidden fields. This is a bit hacky, but the
complexity of making sessions interact with WTForms was just too much to handle.

This commit also changes the example spreadsheet that we show on this page to
look more like a spreadsheet.
2016-05-31 17:07:05 +01:00
Leo Hemsted
f2cca024dd Merge pull request #619 from alphagov/platform-admin-stats
Headline stats on the platform admin page
2016-05-31 13:53:21 +01:00
Leo Hemsted
57875c731b tests for statistics_utils 2016-05-31 12:17:17 +01:00
Leo Hemsted
83b151982e add stats boxes to platform admin page
moved a couple of stats summary functions from dashboard to a shared statistics_utils file
2016-05-31 12:17:06 +01:00
Chris Hill-Scott
960620f284 Merge pull request #624 from alphagov/fix-403-job-updates
Fix 403s when viewing a job as platform admin
2016-05-31 11:21:28 +01:00
Chris Hill-Scott
86511e088a Merge pull request #623 from alphagov/tidy-up-template-history
Move parameters out of the `…_message` components
2016-05-31 11:21:22 +01:00
NIcholas Staples
139ce3386d Merge pull request #625 from alphagov/download_all_job_notifications
Job notification download now includes all notifications.
2016-05-31 10:49:52 +01:00
Nicholas Staples
5ef5920c17 Job notification download now includes all notifications.
Get row number to match excel format.

Fix for no job_row_number.
2016-05-31 10:43:14 +01:00
Chris Hill-Scott
7a7eb095b1 Fix 403s when viewing a job as platform admin
While battling the bank holiday traffic on my way home this evening I realised
why looking at the job page was causing lots of 403 errors in the Chrome
console (a spike which was reflected on the Graphite screen).

There is a separate `.json` endpoint for getting updates to a job. This enpoint
did not have the `admin=True` option set in its permissions decorator. So when
viewing a service as a platform admin you could see the page, but not receive
any AJAX-powered updates to it.
2016-05-27 19:13:01 +01:00
Chris Hill-Scott
b84d06bd68 Move parameters out of the …_message components
This commit refactors the `email_message` and `sms_message` UI components to
take fewer parameters.

`name`, `edit_link` and anything to do with versions are identical for both
text and email messages so I’ve moved them to the pages where you choose a
template or see the versions.

This commit also tidies up the wording and styling of the template history
stuff.
2016-05-27 11:08:40 +01:00
Chris Hill-Scott
01884655c7 Merge pull request #620 from alphagov/remove-get-started-banner
Remove the get started banner from the dashboard
2016-05-27 08:46:57 +01:00
Chris Hill-Scott
769acbf2b9 Remove the get started banner from the dashboard
We cover this stuff in the tour now. It can also show up
if you delete all your templates.
2016-05-26 17:05:16 +01:00
Chris Hill-Scott
623ef5617e Fix the tests 2016-05-26 09:57:16 +01:00
Chris Hill-Scott
6e95abdc82 Stop help showing up when it shouldn’t 2016-05-26 09:43:55 +01:00
Chris Hill-Scott
af7256d84f Merge pull request #614 from alphagov/jobs-on-dashboard
Put uploaded files on the dashboard
2016-05-26 09:28:07 +01:00
Chris Hill-Scott
aebdc747b7 Don’t show help once tour is done 2016-05-26 09:15:13 +01:00
Rebecca Law
6af2b71696 Removed the else statement in the job_api_client.get_job 2016-05-26 09:00:00 +01:00
Chris Hill-Scott
16d83faa72 Put uploaded files on the dashboard
This commit depends on and uses the data returned by:
- [x] https://github.com/alphagov/notifications-api/pull/345
- [x] https://github.com/alphagov/notifications-api/pull/347
- [x] https://github.com/alphagov/notifications-admin/pull/612

It puts the last 5 jobs on the dashboard. This should be changed to all the jobs
from the last 7 days when that parameter is available.

It also:
- links to the jobs page
- makes the numbers on the jobs page consistent with the dashboard
- makes the numbers on an individual job consistent with the appearance of the
  dashboard
2016-05-26 09:00:00 +01:00
Chris Hill-Scott
fe38a46798 Merge pull request #613 from alphagov/no-tour-final
Make the tour interactive
2016-05-25 17:26:48 +01:00
Chris Hill-Scott
c41944080c Make the tour interactive
_The code for this is quite hacky and light on tests. But I’d really like to get
it in the app for the research tomorrow to see how well the feature works._

This commit changes the tour from being a set of static screens to some help
which guides you through the process of sending your first test message.

The theory behind this is that what users are really struggling with is the
concept of a variable, rather than the relationship between the placeholders and
the column headers. And like learning to program, the best way to learn is by
taking an example and modifying it to your own needs.

This means that when someone adds their first service we set them up an
example email template and an example text message template. Then there is a
guided, three step process where _all_ the user can do is send a test message to
themselves.

Once the message is sent, the user still has the example templates which they
can edit, rather than having to remember what they’re supposed to be doing.
2016-05-25 13:14:09 +01:00
Rebecca Law
0bb8ac82c4 Merge pull request #612 from alphagov/update-jobs-endpoint
Add limit_days query param to the get_job endpoint.
2016-05-25 12:15:11 +01:00
catherineheywood
49ca58ba01 Link to Delivery and failure doc 2016-05-25 12:11:00 +01:00
catherineheywood
32368d69f9 Link to Delivery and failure doc 2016-05-25 12:09:05 +01:00
Rebecca Law
47352af38a Add limit_days query param to the get_job endpoint. 2016-05-25 12:04:51 +01:00
Leo Hemsted
6d43067688 Merge pull request #608 from alphagov/platform-admin-dashboard
New platform admin page
2016-05-25 11:18:05 +01:00
Leo Hemsted
ecf0dd7ebb move platform admin links platform admin page
removed "View providers" and "List all services" from the choose service page and the left-hand nav bar
2016-05-25 10:36:47 +01:00
Leo Hemsted
1292bf9fe6 New platform-admin-dashboard page 2016-05-25 09:48:45 +01:00
NIcholas Staples
52f7f826c4 Merge pull request #607 from alphagov/download_bug_fix
Fixed download bug for services with api notifications. Re-organised …
2016-05-25 09:46:25 +01:00
catherineheywood
76d39b6b6c Add new delivery statuses 2016-05-25 09:14:59 +01:00
Pete Herlihy
88aaabf513 Merge pull request #546 from alphagov/add-delivery-and-failure-help-page
Change delivery and failure states to be more useful
2016-05-24 16:10:16 +01:00
Pete Herlihy
c22abad84e Updated wording around 'client providers' 2016-05-24 15:59:16 +01:00
catherineheywood
9ad1ea0e55 Add line to make bullet list display correctly 2016-05-24 13:45:21 +01:00
Nicholas Staples
2505d1421b Fixed download bug for services with api notifications. Re-organised the mock job and job_json methods. 2016-05-24 12:35:12 +01:00
catherineheywood
3a379017d9 Merge pull request #600 from alphagov/docIntegrateInfo
Doc integrate info
2016-05-24 10:12:36 +01:00
Chris Hill-Scott
a4db2dcfe9 Merge pull request #604 from alphagov/improve-job-csv
Improve the ‘download a CSV’ from the job page
2016-05-24 10:11:42 +01:00
Chris Hill-Scott
dd25eb0fe1 Give the job CSV a helpful filename
If you’re downloading a bunch of reports from your jobs then it’s useful to be
able to differentiate between them. This commit makes it easy to do so by naming
the file with:
- the name of the template
- when the job was created
2016-05-24 09:57:21 +01:00
Chris Hill-Scott
8a30a5bf51 Put ‘download CSV’ on job in logical place 2016-05-24 09:39:28 +01:00
Leo Hemsted
42e529fc90 Merge pull request #602 from alphagov/delete-button
delete template button POSTs archived:true
2016-05-24 09:37:31 +01:00
Chris Hill-Scott
61249e9d49 Merge pull request #582 from alphagov/better-errors-in-trial-mode
Make ‘Too many recipients’ error lower priority
2016-05-24 09:29:08 +01:00
Chris Hill-Scott
9c80c9ea3c Merge pull request #603 from alphagov/hide-created-at
Hide ‘created at…’ on the templates page
2016-05-24 09:28:33 +01:00
NIcholas Staples
e65a7003a2 Merge pull request #601 from alphagov/download_job_notifications
Download csv for job added.
2016-05-24 09:23:45 +01:00
Chris Hill-Scott
45f21e9a10 Hide ‘created at…’ on the templates page
I don’t think that if there’s only one version of the template that it’s
useful to see the created at date.

The auditing stuff only becomes relevant once someone a template has been
changed.
2016-05-24 09:22:12 +01:00
Leo Hemsted
2f1a807be3 delete template button POSTs archived:true 2016-05-23 15:04:24 +01:00
Nicholas Staples
935f355d5c Download csv for job added.
Removed check for notifications so download button is always there.
2016-05-23 12:24:03 +01:00
Catherine Heywood
5fed199696 remove redundant sentence 2016-05-23 10:49:14 +01:00
Catherine Heywood
06cee32a43 change command to request 2016-05-23 10:48:34 +01:00
Catherine Heywood
dea0e5a31b typo 2016-05-23 10:45:25 +01:00