Commit Graph

953 Commits

Author SHA1 Message Date
Tom Byers
97172cca30 Merge branch 'master' into convert-all-links-to-govuk-frontend 2020-02-24 10:12:58 +00:00
Tom Byers
1513cfa9e6 Update links missed in previous work
Includes those in:
- the static 5xx error page
- validation messaging
- guidance page about trial mode
- links used in tests

Issues raised in https://github.com/alphagov/notifications-admin/pull/3303#issuecomment-589572715
2020-02-21 13:59:04 +00:00
Tom Byers
8a98c73b08 Make analytics send the same title for all pages
Sets it on the tracker which means this value gets
sent for each:
- pageview
- event

See: https://developers.google.com/analytics/devguides/collection/analyticsjs/pages

We can only test that this has been set on the
tracker, not how that effects what is sent to GA,
in the JS tests.

This change has been tested in-browser with the
Chrome Analytics Debugger. This revealed the
contents of what is in the beacon sent to GA and
allowed confirmation the title was being set
correctly.

See: https://chrome.google.com/webstore/detail/google-analytics-debugger/jnkmfdileelhofjcijamephohjechhna/related
2020-02-20 11:46:19 +00:00
Tom Byers
5459dd8c13 Fix issues raised on pull request
Includes:
- make 'remove team member' link, on edit member
  permissions page, destructive
- convert missed links on /features pages
- convert missed links on /using-notify/guidance and sub pages
- give links in browse-lists back their size and
  weight (needed for lists of live and trial
  services on Platform Admin)
- give links on Platform Admin inbound numbers
  page back their size and weight
- update links in JS tests
2020-02-20 09:19:06 +00:00
Tom Byers
6d349b514c Remove all redundant link CSS
Giving all links the GOVUK Frontend classes, and
the new `govuk-link--destructive` class, means
some styles are already applied.

This strips out those styles.

Note: there's still a good amount of styling, most
of which is to make the focus styles specific to
the space the link is in. These will need
reviewing when GOVUK Frontend is bumped past
version 3 as this brings in new focus styles.
2020-02-20 09:11:26 +00:00
Tom Byers
b5af89fe02 Remove style for deleted elements
The `.global-cookie-message` and `.footer-nav`
classes were for elements in the govuk_template.
This used to be the base layout for this app but
was changed here:

https://github.com/alphagov/notifications-admin/pull/3198
2020-02-20 09:11:26 +00:00
Tom Byers
548265dbe4 Convert warning links to govuk-link--destructive
Converts links in the following:
- the page-footer component
- the table component
- the browse-list component
- the notification status, when reporting failures
- validation messaging in the whitelist page
2020-02-20 09:11:26 +00:00
Tom Byers
378c26ee2a Add styles for destructive links
This colour is used in a few places so worth
making into its own block and classes.

Note: this establishes a
`app/assets/stylesheets/local` folder for any Sass
files whose names clash with files from vendored
libraries.

`_typography.scss` already exists in GOV.UK
Elements Sass.

This will no longer be needed when GOV.UK Elements
is gone and GOV.UK Frontend is at version 3, where
all its folders are in a `govuk` folder.
2020-02-20 09:11:26 +00:00
Tom Byers
c51d414197 Replace links in navigation
Includes:
- removing all styling of those links
  outside of GOV.UK Frontend (except for a few fixes
  due to their interaction with our design)
- bringing together some duplicate styles into one
  block
- changing how links are marked as selected, now
  they have multiple classes

Fix Sass-lint error in navigation.scss
2020-02-20 09:11:26 +00:00
Tom Byers
a61856ffe1 Replace browse-list links 2020-02-20 09:11:26 +00:00
Tom Byers
5e07ef484f Add font-smoothing as global style
Making all links GOV.UK Frontend styled means some
will sit in content that doesn't use the GOV.UK
Frontend font styles yet.

This applies the font-smoothing that comes with
those styles to all text so links do not look out
of place on browsers that support it.

Note: font-smoothing was part of the GOV.UK
Template styles which have now been removed:

https://github.com/alphagov/govuk_template/blob/master/source/assets/stylesheets/_basic.scss#L68
2020-02-20 09:11:26 +00:00
Tom Byers
c094f31b2b Update links in JavaScript 2020-02-20 09:11:26 +00:00
Tom Byers
7ec191bbac Remove global link styles
All links, that need it, now have the GOVUK
Frontend link class so we no longer need this
CSS.
2020-02-20 09:11:26 +00:00
Chris Hill-Scott
3bbd5381c6 Revert "Revert "Restyle template statistics and received text messages"" 2020-02-18 16:16:51 +00:00
Chris Hill-Scott
6bdd776780 Revert "Restyle template statistics and received text messages" 2020-02-18 14:58:33 +00:00
Chris Hill-Scott
a86f0a6efc Merge pull request #3295 from alphagov/restyle-template-stats
Restyle template statistics and received text messages
2020-02-18 14:30:06 +00:00
Tom Byers
0335e7ad17 Give dashboard banner items some vertical space
Giving the count-label some vertical margin means
it has enough space when the flexbox contents
wrap.

This requires a bit extra on the top to counter
the negative margin the count has subtracting 5px
from the parent box.
2020-02-18 13:14:56 +00:00
Tom Byers
08781a497f Update app/assets/stylesheets/components/banner.scss
Put borders back on dashboard banner focus state

Co-Authored-By: Chris Hill-Scott <me@quis.cc>
2020-02-18 11:55:20 +00:00
Tom Byers
6911319298 Update app/assets/stylesheets/components/banner.scss
Adjustment to the vertical padding on the dashboard

Co-Authored-By: Chris Hill-Scott <me@quis.cc>
2020-02-18 11:54:26 +00:00
Tom Byers
484bcfbae7 Update app/assets/stylesheets/components/banner.scss
Slight adjustment to vertical spacing on the dashboard banner count. See: https://github.com/alphagov/notifications-admin/pull/3295#discussion_r380616204

Co-Authored-By: Chris Hill-Scott <me@quis.cc>
2020-02-18 11:53:21 +00:00
Tom Byers
cd262559cc Refactor dashboard banner CSS and fix its text
Switches the CSS to use flexbox for layout and
uses a macro to let the text support single and
multiple messsages.
2020-02-17 16:44:41 +00:00
Chris Hill-Scott
84df70e520 Use a <caption> for the template statistics table
This is semantically more accurate because it’s describing the whole
table, not just the first column.

Adjusting the font-size to make it sit within the ‘In the last 7 days’
section. Adjusting the spacing because now that we have more borders we
don’t need quite so much whitespace to separate different bits of the
page.
2020-02-17 11:11:53 +00:00
Chris Hill-Scott
b65b417a08 Restyle inbound text messages
This commit adds a new kind of banner to the dashboard for summarising
things you might need to action.

This way we’ll be able to have multiple instances of this banner on the
same page without it looking too intense.

I never really liked the big blue banner for inbound text messages
because it became the most prominent thing on the page. It was an
interim solution that let us ship the feature until we had something
better.
2020-02-17 10:31:59 +00:00
Chris Hill-Scott
89b88ee4cb Restyle template statistics
This makes the template statistics section of the dashboard look less
like its own weird thing and more like:
- the templates page
- the upcoming changes to the styling of the received text messages
  banner on the dashboard
2020-02-17 09:55:52 +00:00
Katie Smith
f40f709e4f Stop importing old style buttons 2020-02-17 08:05:05 +00:00
Katie Smith
e53a97423b Update radio-select to use govuk-frontend buttons 2020-02-17 08:05:05 +00:00
Katie Smith
0d0b71af63 Update buttons on api key pages to govuk-frontend buttons 2020-02-17 08:05:05 +00:00
Katie Smith
485d25b120 Update start button on signed out homepage 2020-02-17 08:05:05 +00:00
Katie Smith
e53c5e17b3 Update file upload component to use govuk-frontend buttons 2020-02-17 08:05:05 +00:00
Katie Smith
2cbfaf1b6f Update the buttons on template folder form 2020-02-17 08:05:05 +00:00
Katie Smith
583a925e89 Add buttons for list entries
As part of updating the stylesheet, moved `.button-secondary` to the
global stylesheet, since this is not related to list entries but instead
affects all buttons with that class (this class wlil be removed once all
the buttons are using the new macro).
2020-02-17 08:05:05 +00:00
Katie Smith
4e42fa6f5d Update buttons for collapsible checkboxes
We use collapsible checkboxes when setting which folders team members
can see (on the manage folder page and on the edit team member page).
2020-02-17 08:05:05 +00:00
Katie Smith
dca6d1690f Use govuk-button in page footer component 2020-02-17 08:05:05 +00:00
Katie Smith
ac41a22329 Use new button in banner macro
This means we can delete a class from the banner scss.
2020-02-17 08:05:05 +00:00
Katie Smith
7ff8b73088 Update buttons that are inline with search box
There were 3 pages where we had a search button inline with a text box.
This replaces the search button with a button from govuk-frontend and
updates the way we style this button to use BEM, which is the style we
now want to use.
2020-02-17 08:05:05 +00:00
Katie Smith
a62658ce8c Add override to govuk-frontend button
The button style we were using had no bottom margin, but the
govuk-frontend button has a bottom margin of 10px. This override removes
the added margin to keep the look of our buttons consistent.
2020-02-17 08:05:05 +00:00
Katie Smith
66967e1d96 Import / require all code for the govuk frontend button 2020-02-17 08:05:05 +00:00
Tom Byers
1d0c2070db Merge pull request #3291 from alphagov/fix-pill-heights
Make pill items match their heights
2020-02-11 14:28:14 +00:00
Tom Byers
4433db346b Center pill content using more flexbox
Turns each pill item (already full height) into a
flex container with its content as a column. Uses
this to align the content (the pill label) to the
middle of the column.
2020-02-07 17:42:53 +00:00
Tom Byers
c8d9625518 Merge pull request #3164 from alphagov/update-static-error-pages
Update static error pages
2020-02-07 12:49:47 +00:00
Tom Byers
76240d5d55 Fix issues from pull request review
Fixes for the following:
- `<p>` tags need `govuk-body` class
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375921631
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375924387
- unused JS file
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375949386
- link to GDS has incorrect href
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375966464
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375966555
2020-02-07 11:21:11 +00:00
Tom Byers
a5ea785474 Make pill items match their heights 2020-02-06 16:38:24 +00:00
Tom Byers
2bb651865a Remove unused images
As per @quis's comment:

https://github.com/alphagov/notifications-admin/pull/3279#issuecomment-581902125
2020-02-05 10:37:57 +00:00
Tom Byers
fbff4beef5 Update app/assets/error_pages/5xx.html
Remove unneeded GOV.UK suffix from page title on error page.

Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
2020-02-04 16:07:33 +00:00
karlchillmaid
238fcd4652 Fix spacing 2020-02-04 13:45:55 +00:00
karlchillmaid
faf983356e Add status page and email
Add status page and email instructions to the 5xx error.

These match what we show on the 500 error page.
2020-02-04 13:44:55 +00:00
Tom Byers
f8564ebe0c Make agreed changes to content
The following changes are still to be decided:
- how to tell userr when the service will be up
  again on the PaaS failwhale page
- contact information for both pages
2020-02-03 17:02:01 +00:00
Tom Byers
9263bac59e Remove all code targetting IE8
We've dropped support for IE8 so this isn't
needed. For reference:

https://github.com/alphagov/notifications-admin/pull/3158#pullrequestreview-308447860
2020-02-03 17:01:54 +00:00
Tom Byers
88bd14811d Update app/assets/error_pages/5xx.html 2020-02-03 17:01:28 +00:00
Matt Hobbs
9d4b761d12 Minify SVG, other SVG's already optimised 2020-01-29 17:33:56 +00:00