darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-28 09:59:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,957 Commits 57 Branches 59 Tags
9ff7b85d04d70854f82b99a81bd7ff1d2e7d6404
Commit Graph

9957 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
9ff7b85d04 Merge pull request #3502 from alphagov/serivce-permission-decorator 
Add service permission decorator
 2020-07-03 14:31:15 +01:00
Chris Hill-Scott
dd2b737d24 Use service_has_permission decorator on inbox 
This proves that the decorator works, because the inbox code is already
tested:
bad1e69cc3/tests/app/main/views/test_dashboard.py (L353-L367)
 2020-07-03 10:12:55 +01:00
Chris Hill-Scott
d4627a2f3a Add service_has_permission decorator 
Similar to how we can restrict routes to only users with a given
permission, this new decorator lets us restrict routes to services that
have a given permission.

Having this is a decorator is cleaner than putting if statements inside
the endpoint code.
 2020-07-03 09:56:11 +01:00
Pea M. Tyczynska
bad1e69cc3 Merge pull request #3499 from alphagov/hint-text-org 
When changing service name, use organisation of the service for hint
 2020-07-02 12:24:51 +01:00
Pea Tyczynska
e1f1f2a9c2 When changing service name, use organisation of the service for hint 
text if available. If service is not attached to any organisation yet,
use default org for the user.
 2020-07-02 12:01:48 +01:00
Pea M. Tyczynska
0ad449883d Merge pull request #3484 from alphagov/add-service-name-hint-text-for-local-authorities 
Add service name hint text for local authorities
 2020-07-02 10:11:34 +01:00
Pea M. Tyczynska
1b2727197a Use en dashes for better formatting 
Co-authored-by: Chris Hill-Scott <me@quis.cc>
 2020-07-01 15:30:57 +01:00
Tom Byers
4eea8bfe57 Add variant page for service-settings/name 
Includes correction of class used for bulleted
list.
 2020-07-01 14:57:45 +01:00
Pea Tyczynska
b3bc3a6447 Write test for separate page for service name change for local orgs 
Also make a bullet list gov uk style
 2020-07-01 14:57:45 +01:00
Pea Tyczynska
d0dd6218f7 Show different page for local org users when adding new service 2020-07-01 14:57:44 +01:00
Tom Byers
a381c6d37d Add test for local auth' version of add-service 2020-07-01 14:57:43 +01:00
karlchillmaid
18435d3455 Update bullets to use default user organisation 2020-07-01 14:57:43 +01:00
karlchillmaid
e15c670585 Create a separate page for service name changing for local services 
This new page has a special hint text that will help local authorities
name their services well.

Add new hint text – old hint text left intact for now
 2020-07-01 14:56:21 +01:00
karlchillmaid
e6f49825e5 Create a separate page for Create service journey for local org users 
This page has a special hint text that will help local org users name
their services well.

Add new hint text – old hint text left intact
 2020-07-01 14:54:36 +01:00
karlchillmaid
8a1d86633c Merge pull request #3486 from alphagov/update-guest-list-content 
Update guest list introduction
 2020-07-01 14:34:27 +01:00
David McDonald
4e165ae3d3 Merge pull request #3496 from alphagov/revert-3495-statsd-to-prometheus 
Revert "Statsd to prometheus"
 2020-07-01 10:29:36 +01:00
David McDonald
5fb58260e2 Revert "Statsd to prometheus" 2020-07-01 10:00:39 +01:00
David McDonald
e260110d60 Merge pull request #3495 from alphagov/statsd-to-prometheus 
Statsd to prometheus
 2020-06-30 15:37:40 +01:00
David McDonald
043e6ac69c Add GDS metrics package to admin app 
Follows the code from the API
 2020-06-30 14:24:34 +01:00
Chris Hill-Scott
9b98298d76 Merge pull request #3494 from alphagov/broadcast-service-permission 
add broadcast service permission to service settings
 2020-06-30 14:11:35 +01:00
Chris Hill-Scott
cbe0ecc022 Merge pull request #3493 from alphagov/pyup-scheduled-update-2020-06-29 
Scheduled weekly dependency update for week 26
 2020-06-30 14:11:21 +01:00
Chris Hill-Scott
7d6802b415 Freeze requirements 2020-06-30 13:50:05 +01:00
pyup-bot
20a53ad32a Update humanize from 2.4.0 to 2.4.1 2020-06-30 13:49:42 +01:00
Leo Hemsted
8b3aa43101 add broadcast service permission 2020-06-30 13:06:26 +01:00
David McDonald
6958c0d677 Remove statsd 
We don't expose these metrics anywhere anyway and we want to move to
prometheus too (which will be done in the next commit)
 2020-06-30 11:08:11 +01:00
Chris Hill-Scott
ee8270aa2c Merge pull request #3480 from alphagov/request-cache 
Import request cache from utils
 2020-06-29 16:22:21 +01:00
Chris Hill-Scott
c98d21da12 Merge pull request #3491 from alphagov/platform-admin-services-layout 
Platform admin services layout
 2020-06-29 16:22:16 +01:00
Chris Hill-Scott
fb4076dc5b Don’t break statistics down by sending/failed/delivered 
This should:
- make the page load faster because it has to render less HTML for each
  service
- make the page easier to scan for services that are sending lots of
  text messages or letters

We used to scan this page to look for services with high failure rates,
and the design of the page was gear towards this. Now we have alerting
for high failure rates, so the page can focus on volumes instead.

This commit also puts the service name above the statistics, so that
long service names don’t break the layout of the page.
 2020-06-24 11:45:32 +01:00
Chris Hill-Scott
2762be233d Put archived label alongside service name 2020-06-24 10:41:12 +01:00
Chris Hill-Scott
37673bce32 Merge pull request #3490 from alphagov/remove-letter-contact-block-field 
Stop expecting letter contact block in service JSON
 2020-06-24 09:17:17 +01:00
karlchillmaid
ab3e76a5b1 Change 'the' to 'a' 2020-06-23 14:54:11 +01:00
karlchillmaid
b549fda0a2 Update key name 2020-06-23 14:38:48 +01:00
Chris Hill-Scott
b176f1b1f0 Merge pull request #3488 from alphagov/ask-for-less-detailed-templates 
Ask API for less detailed JSON for all templates
 2020-06-23 14:12:58 +01:00
Chris Hill-Scott
45697aac43 Stop expecting letter contact block in service JSON 
We’re removing it for performance reasons.

This means removing the old pages that edited the letter contact block
when it was stored directly on the service, rather than the current
model where a service can have multiple contact blocks.
 2020-06-23 08:13:52 +01:00
karlchillmaid
e15665e6bf Merge pull request #3489 from alphagov/update-temp-failure-for-sms 
Update temporary failure error message content
 2020-06-22 13:53:46 +01:00
Chris Hill-Scott
5335729c31 Import request cache from utils 
We’ve making the request cache shared code now so we can remove it from
this app and refer to the version in utils instead.

Delete unused module
 2020-06-22 09:39:32 +01:00
karlchillmaid
81de5dfed2 Update content 2020-06-19 17:55:35 +01:00
karlchillmaid
aea037fca0 update content 2020-06-19 17:53:44 +01:00
karlchillmaid
1f186ec1fa Update temp failure description for SMS 2020-06-19 16:38:06 +01:00
Leo Hemsted
2f1e8b104b Merge pull request #3487 from alphagov/statsd 
bump utils
 2020-06-19 11:54:06 +01:00
Chris Hill-Scott
51e99bd828 Ask API for less detailed JSON for all templates 
This should speed things up by:
- less time waiting for big blobs of JSON to come from Redis or the API
- less time spent deserialising big blobs of JSON
 2020-06-19 10:32:44 +01:00
Leo Hemsted
fb820306da bump utils 2020-06-18 16:06:18 +01:00
David McDonald
c7543df39b Merge pull request #3482 from alphagov/pyup-scheduled-update-2020-06-15 
Scheduled weekly dependency update for week 24
 2020-06-18 11:58:49 +01:00
David McDonald
ec0ebd57a9 make freeze requirements 2020-06-18 11:40:49 +01:00
pyup-bot
b69cfa4d2e Update pyexcel from 0.6.1 to 0.6.2 2020-06-18 11:39:47 +01:00
pyup-bot
0684947732 Update govuk-bank-holidays from 0.6 to 0.8 2020-06-18 11:39:47 +01:00
karlchillmaid
fb2454ec0f Update guest list introduction 2020-06-17 13:32:22 +01:00
Chris Hill-Scott
be3ad0bfd3 Merge pull request #3474 from alphagov/use-sticky-footer-set-inbound-number 
Use a sticky footer on the set inbound number page
 2020-06-17 11:43:24 +01:00
Chris Hill-Scott
e858a45c05 Merge pull request #3485 from alphagov/remove-blacklist-term 
Remove term ‘blacklist’ from codebase
 2020-06-17 09:56:49 +01:00
Chris Hill-Scott
972ba9e3da Remove term ‘blacklist’ from codebase 
‘Commonly used passwords’ is more specific, and avoids the terminology
‘blacklist’ which the National Cyber Security Centre explain to be
problematic:

> It's fairly common to say whitelisting and blacklisting to describe desirable and undesirable things in cyber security. For instance, when talking about which applications you will allow or deny on your corporate network; or deciding which bad passwords you want your users not to be able to use.
>
> However, there's an issue with the terminology. It only makes sense if you equate white with 'good, permitted, safe' and black with 'bad, dangerous, forbidden'. There are some obvious problems with this. So in the name of helping to stamp out racism in cyber security, we will
> avoid this casually pejorative wording on our website in the future. No, it's not the biggest issue in the world - but to borrow a slogan from elsewhere: every little helps.

– https://www.ncsc.gov.uk/blog-post/terminology-its-not-black-and-white
 2020-06-16 18:07:47 +01:00