Commit Graph

2885 Commits

Author SHA1 Message Date
Martyn Inglis
994032a76f Switched off session protection
Many departments are reporting being logged out during usage of the app
This may be because they present differing IP addresses to Notify on different requests due to outbound proxies and so on
Swicthing session protection to None means and IP change won't log a user out.
2016-12-14 14:07:08 +00:00
Rebecca Law
0a69f1797a Merge pull request #1047 from alphagov/invitation-expiry-msg
Invitation expiry msg
2016-12-13 10:00:33 +00:00
Leo Hemsted
466d0b10ac Merge pull request #1051 from alphagov/inactive-service
users can't edit inactive services
2016-12-12 14:59:30 +00:00
Chris Hill-Scott
1a75daef55 Merge pull request #1050 from alphagov/letter-assets
Add assets for letter previews
2016-12-09 17:24:59 +01:00
Leo Hemsted
2419f0d8a9 write tests for @minglis 's code 🙁 2016-12-09 16:09:47 +00:00
Leo Hemsted
d56b7b9a58 block inactive services from making stateful changes
in the NotifyAdminAPIClient, which all api traffic goes through, return
403 for any stateful requests (post, put and delete), if the following
criteria have been met:
* a current_service is set
    (this prevents checks being carried out on non-service related
     updates, eg editing user details)
* the service is not active
* the current user is not a platform admin

so platform admins can still update anything.

Note: Without any specific error handling, the user will see a generic
403 page. This is fine, probably - it's a relatively niche case that
you'll be editing a service you can't get to anyway
2016-12-09 16:09:42 +00:00
Leo Hemsted
255ce158b7 block inactive services from making stateful changes
in the NotifyAdminAPIClient, which all api traffic goes through, return
403 for any stateful requests (post, put and delete), if the following
criteria have been met:
* a current_service is set
    (this prevents checks being carried out on non-service related
     updates, eg editing user details)
* the service is not active
* the current user is not a platform admin

so platform admins can still update anything.

Note: Without any specific error handling, the user will see a generic
403 page. This is fine, probably - it's a relatively niche case that
you'll be editing a service you can't get to anyway
2016-12-09 15:44:58 +00:00
Chris Hill-Scott
f6b566fdf8 Merge pull request #1048 from alphagov/product-page-fixes
Fix a couple of things that got missed on the product page
2016-12-09 14:12:43 +01:00
Chris Hill-Scott
54d7306d77 Add assets for letter previews 2016-12-09 11:26:32 +00:00
Chris Hill-Scott
c72a19178b Remove duplicate <h2> definition 2016-12-07 17:02:03 +00:00
Chris Hill-Scott
82f6c20101 Add alt text for the images on the product page
The images are telling you stuff that is extra to the text on the page
so they should be explained for users who can’t see them.
2016-12-07 17:00:53 +00:00
Chris Hill-Scott
a56d945beb Merge pull request #1035 from alphagov/new-product-page
New product page part 1
2016-12-07 17:34:13 +01:00
Chris Hill-Scott
9ec2f2b5d0 Add a ‘team’ section
This addresses part of the ‘is Notify dependable’ group of needs.

The ones it specifically and partially addresses are:
- is it reliable
- how is it supported

There’s more to come in this section, we’re doing this bit now because
it’s a nice conclusion to the page.
2016-12-07 16:14:32 +00:00
Chris Hill-Scott
4af8206723 Reword and embiggen the headings
Also reword some of the `<p>`s so that they flow better from the
headings.

This was a bit me, and a bit sitting down and hammering this stuff out
with Stephen and Sheryll.
2016-12-07 16:14:32 +00:00
Chris Hill-Scott
63e13836b0 Add illustration to the ‘what is Notify’ section
Compliments the new tagline. Illustration by Stephen.

Only shown where there is space (ie on desktop).
2016-12-07 16:14:32 +00:00
Chris Hill-Scott
eca4fbbf54 Change tagline
The previous one didn’t communicate that this is a thing for sending
stuff to your users. The lede already explains that it’s a thing for
government.
2016-12-07 16:14:32 +00:00
Chris Hill-Scott
40d2d3f338 Space out items in blue box a bit
I went too far with tightening it up from the prototype. This is
somewhere in between.
2016-12-07 16:14:32 +00:00
Chris Hill-Scott
16226c9975 Remove ‘to your account’ from the sign in link
It’s getting a bit long now it’s not the only link; we say just ‘sign
in’ elsewhere.
2016-12-07 16:14:31 +00:00
Chris Hill-Scott
6072ec1e19 Add a grid of features to the home page
This is the first step towards a fully-fledged ‘product’ page.

The needs for the top, blue section of the page are:
- what is Notify?
- can I use it?
- can I test it out?
- how do I create a log in

The needs for the next section of this page (which is the only one added
by this commit) are:
- how will Notify help me work?
- will it work with my service?

This commit shows 4 features of Notify on the home page which address
those needs. They are illustrated because:

1. We want to catch people’s attention – users are reluctant to scroll
   on this page because they just want to click the ‘create account
   button’. But we hypothesize that they will get on better
   with Notify if they look at some of this stuff first.

2. The concepts that they’re talking about are hard to explain with just
   words because they’re quite abstract. The illustrations help us be
   more specific.

3. Feedback we got from user research was that the product page didn’t
   give users any sense of what it was like to actually use Notify.
2016-12-07 16:14:31 +00:00
Chris Hill-Scott
bbf3969525 Match type sizes to prototype 2016-12-07 16:14:31 +00:00
Chris Hill-Scott
f9d2034e4f Make the blue header on the home page full-width
This copies the style that Tim and Stephen have been developing for all
product pages.

It also pulls out the CSS for this into its own file, so that it could
potentially be reused.
2016-12-07 16:14:30 +00:00
Chris Hill-Scott
6cda78e7d5 Cover up the header bar 2016-12-07 16:14:30 +00:00
Chris Hill-Scott
403e133b80 Remove the phones 2016-12-07 16:14:30 +00:00
Chris Hill-Scott
92ad308fca Replace beta banner with beta badge
This is part of the new header style that Tim, Stephen et al have been
working on.

This means that we lose the feedback link, so I’m trying out having it
in the top right.
2016-12-07 16:14:30 +00:00
Chris Hill-Scott
397ad05db9 Make a full width base template
We need this because the top section of the new product page will be
going full-bleed.
2016-12-07 16:14:30 +00:00
Chris Hill-Scott
0d7a453c75 Merge pull request #1046 from alphagov/you-make-me-feel-like-a-natural-england
Add Natural England to government email domains list
2016-12-07 17:14:12 +01:00
Rebecca Law
0417fa3534 Remove unused import 2016-12-07 14:12:12 +00:00
Rebecca Law
4b5e4d2864 Added a new 400.html error page, this error page will only be used when we get an HTTPError from the api.
This was done to solve the problem of invitations expiring and the user getting a 500 error message, which says to try again.
2016-12-07 14:00:03 +00:00
Chris Hill-Scott
db6bb77d74 Don’t allow suppliers to sign up for own accounts
Suppliers need to be invited by people who work for the government.
People who work for the government can invite anyone to join their team,
no matter what their email address is.

So there’s no need for these domains to be in the list now.
2016-12-07 13:57:26 +00:00
Chris Hill-Scott
b4a7ffff8d Add Natural England to gov. email domains list
> I cannot register as the Email address field will not accept my email
> address format (.org.uk).  Natural England is a non-departmental
> government body sponsored by Defra (Department for Environment, Food
> and Rural Affairs).  Can you register me on the system or change the
> system so it will accept my email address?

– Deskpro ticket

> Natural England is an executive non-departmental public body,
> sponsored by the Department for Environment, Food & Rural Affairs.

– https://www.gov.uk/government/organisations/natural-england

***

Checks out…
2016-12-07 12:58:49 +00:00
Rebecca Law
743399dfb5 Merge branch 'master' of github.com:alphagov/notifications-admin 2016-12-07 10:22:41 +00:00
Jenny Duckett
6d166f9b83 Merge pull request #1045 from alphagov/stats-toggle-test-key
Add option to exclude test key usage in stats on platform admin page
2016-12-06 14:37:20 +00:00
Jenny Duckett
93405dd56b Move day and test key messages to <p> instead of left column
We don't want large numbers in Production to start overlapping other columns
in the tables when they have less space available, and putting these messages
at the top of the page under the h1 means that we don't need an extra column
on the page yet.
2016-12-06 12:46:11 +00:00
Jenny Duckett
df265f188d Move link to providers page to the header
This link looked odd floating above the left column, and although we may want
to have admin navigation on the left we aren't sure what that would include
yet, so move this link to the header alongside the Platform admin link.
2016-12-06 12:42:27 +00:00
Jenny Duckett
3a637c8fa9 Move "Today" heading to left column on platform admin page
When we make the numbers on this page more filterable the date range will be
one of the options to change, so it makes sense to move it to the side now
instead of leaving it above the big numbers.
2016-12-06 12:42:27 +00:00
Jenny Duckett
c88a961e04 Add option to exclude test key stats on platform admin page
This page currently includes all notifications for all services, including
those sent using a test key. Stats on all other pages exclude test key usage,
though, which can lead to confusion for admins comparing numbers between
pages. Adding the option to toggle between including and excluding test key
usage on the platform admin page gives context for this difference, and allows
admins to see live usage of the platform as well as load associated with test
key usage.
2016-12-06 12:42:27 +00:00
Rebecca Law
4fd5e8a957 Merge branch 'master' of github.com:alphagov/notifications-admin 2016-12-06 09:41:41 +00:00
Chris Hill-Scott
fc2ea8aeb8 Merge pull request #1044 from alphagov/fix-alignment-usage
Fix alignment of year label on usage
2016-12-06 10:23:13 +01:00
Chris Hill-Scott
b3cb3a761a Merge pull request #1043 from alphagov/column-fix
Fix misaligned columns in CSV files
2016-12-06 10:23:08 +01:00
bandesz
f43ba1fbb9 Enable SSE for S3 upload 2016-12-05 16:53:15 +00:00
minglis
18b4ce919b Merge pull request #1041 from alphagov/add-statsd
Add statsd
2016-12-05 15:59:06 +00:00
Chris Hill-Scott
62cb7b5d53 Fix alignment of year label on usage
It got pushed down too far when we added the switch service bar in
https://github.com/alphagov/notifications-admin/pull/1029

This commit fixes it so that the text aligns with the baseline of the
`<h1>`.
2016-12-05 13:02:19 +00:00
Chris Hill-Scott
18d11aa013 Move code for rendering messages/templates → utils
Utils is better structured to handle the logic of what thing to show
for what template type, especially now that what we show for different
template types in different contexts has diverged significantly.

See https://github.com/alphagov/notifications-utils/commit/6b39c1a for
an example of this code moving into utils

Depends on and implements:
https://github.com/alphagov/notifications-utils/pull/84

The main reason for doing this is to get Paul’s fix for the misaligned
CSV columns: https://github.com/alphagov/notifications-utils/pull/87
2016-12-05 12:11:54 +00:00
Andras Ferencz-Szabo
40f30ca13a Merge pull request #1042 from alphagov/docker_build_http_proxy
Set http proxy params for Docker build
2016-12-02 15:06:52 +00:00
bandesz
4c89c8c33d Set http proxy params for Docker build 2016-12-02 14:45:01 +00:00
minglis
68dc9f1966 Merge pull request #1038 from alphagov/generate-version-file-in-bootstrap
Generate the version file in the bootstrap script
2016-12-02 10:15:07 +00:00
Martyn Inglis
eab69fd840 Statsd disabled on dev machines 2016-12-01 17:22:05 +00:00
Martyn Inglis
0bc48897f3 Adds statsd to the application
- statsd client from utils
- adds to logger an get same method based reporting as we do for the API.
2016-12-01 17:21:06 +00:00
minglis
20d9964f71 Merge pull request #1040 from alphagov/request-id-logging
Request id logging
2016-12-01 13:31:58 +00:00
Martyn Inglis
c7549d552e Bumped version of utils 2016-12-01 13:13:48 +00:00