darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-25 18:01:57 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,852 Commits 57 Branches 61 Tags
92ab4e356d8bd98288e09d881bc0d28fbe602a01
Commit Graph

1852 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Catherine Heywood
92ab4e356d formatting 2016-05-19 14:45:12 +01:00
Catherine Heywood
7d0e8d9719 add list of query string parameters 2016-05-19 14:44:09 +01:00
Catherine Heywood
a9fbb73ad1 add comma 2016-05-19 14:33:13 +01:00
Catherine Heywood
58dd6f8729 correct typo 2016-05-19 14:32:13 +01:00
Catherine Heywood
d2902b0b3c rewording 2016-05-19 14:31:11 +01:00
Catherine Heywood
375c7a0b9f rewording 2016-05-19 14:30:28 +01:00
Catherine Heywood
6b5b952694 rewording 2016-05-19 14:29:51 +01:00
Catherine Heywood
509d2d095c correct table3 2016-05-19 14:28:45 +01:00
Catherine Heywood
f6053690b3 correct table2 2016-05-19 14:27:50 +01:00
Catherine Heywood
c4efdbe925 correct table 2016-05-19 14:25:59 +01:00
Catherine Heywood
b333b1bfb5 reword integrate info - table 2016-05-19 14:24:05 +01:00
Adam Shimali
4c2ee8e8ed Updated for correct desk pro env vars 2016-05-19 11:04:45 +01:00
Adam Shimali
e608b60d93 Merge pull request #589 from alphagov/import-cleanup 
Removed unused imports
 2016-05-18 16:26:58 +01:00
Adam Shimali
3563dcc010 Merge pull request #591 from alphagov/team-id-for-deskpro 
Renamed DESKPRO_TEAM_ID to DESKPRO_DEPT_ID
 2016-05-18 16:24:19 +01:00
Adam Shimali
e181940966 Renamed DESKPRO_TEAM_ID to DESKPRO_DEPT_ID to match name of param in 
api call.

Added DESKPRO_ASSIGNED_AGENT_TEAM_ID so that tickets routed correctly.
 2016-05-18 15:03:23 +01:00
Adam Shimali
25170e7e42 Removed unused imports 2016-05-18 14:39:06 +01:00
Martyn Inglis
0172797fb5 Changed user for elb register/deregister scripts 2016-05-18 13:30:01 +01:00
minglis
a892f44696 Merge pull request #588 from alphagov/no-downtime-deploys 
No downtime deploys
 2016-05-18 13:22:24 +01:00
Martyn Inglis
664ae33108 Formatting 2016-05-18 13:10:51 +01:00
Martyn Inglis
44b0bd3092 Scripts added to deregister admin app from ELB on deploy 
- Application Stop state will deregister
- Application Start state re-registers

Ensures that the App instance is not receiving traffic before stopping the app as part of a code deploy

These scripts are from :

https://blogs.aws.amazon.com/application-management/post/Tx39X8HM93NXU47/Use-AWS-CodeDeploy-to-Deploy-to-Amazon-EC2-Instances-Behind-an-Elastic-Load-Bala

Adapted to remove notion of Autoscaling groups (which we don't use) and to use a named ELB, allows common file to be common and start/stop to be changed.
 2016-05-18 13:08:51 +01:00
Rebecca Law
613ff1a05e Merge pull request #585 from alphagov/format-failures 
Notifications page filters
 2016-05-18 12:19:10 +01:00
Rebecca Law
6c14d925c5 Fix test to use a real status 2016-05-18 12:05:26 +01:00
Rebecca Law
5e27861515 Merge branch 'format-failures' of github.com:alphagov/notifications-admin into format-failures 2016-05-18 12:00:34 +01:00
Adam Shimali
a20fc1aa47 If user clicks failed or both filters for notifications status view, 
append all other failure states to query to api.
 2016-05-18 11:44:58 +01:00
Rebecca Law
37327dfbb0 Add a filter to format notification status to a readible label. 2016-05-18 09:54:50 +01:00
Chris Hill-Scott
97b268182b Merge pull request #579 from alphagov/add-expand-collapse-to-send-guidance 
On page load, hide the instructions for uploading a file
 2016-05-17 16:30:16 +01:00
Chris Hill-Scott
2ba801ff73 Add polyfill for HTML5 <details> element 
The details element is fairly new. It doesn’t work in all browsers,
and isn’t keyboard/screenreader accessible even in some new browsers.

This commit adds the Polyfill script from GOV.UK elements[1] which
polyfills these features for browsers that don’t support them.

1. http://govuk-elements.herokuapp.com/typography/#typography-hidden-text
 2016-05-17 14:54:05 +01:00
Chris Hill-Scott
c6ab4d2c94 Hide the instructions for formatting a CSV 
> On the send pages, we have a call to action in the middle of the
> page with lots of words and placeholder buttony looking things
> above and below it....
>
> You'll also see this every time you use this page, even though you
> probably get it after a single use.
>
> So let's wrap it up under a usefully titled (?) help link that
> expands to reveal all the things.

This commit implements the above.

It also rewords the messaging to talk about various spreadsheet formats,
not just CSV.
 2016-05-17 14:52:40 +01:00
minglis
95065c436c Merge pull request #578 from alphagov/timezones 
Convert timezones using pytz.
 2016-05-17 14:52:36 +01:00
Martyn Inglis
e54c309594 Convert timezones using pytz. 2016-05-17 14:00:40 +01:00
Chris Hill-Scott
7703b87aa7 Merge pull request #574 from alphagov/add-lxml-to-req 
Add lxml 3.6.0 to requirements.
 2016-05-17 13:54:19 +01:00
Chris Hill-Scott
f4da9350dc Merge pull request #571 from alphagov/fix-blank-column-headers 
Handle CSV files with blank column headers
 2016-05-17 13:54:12 +01:00
Adam Shimali
e20ce561e9 Merge pull request #575 from alphagov/reply-to-email-surfaced 
If service has reply to show it in form
 2016-05-17 13:25:58 +01:00
Chris Hill-Scott
3944c67a0a Handle CSV files with blank column headers 
Implements https://github.com/alphagov/notifications-utils/pull/32
 2016-05-17 13:25:54 +01:00
Chris Hill-Scott
158d4d6c43 Merge pull request #566 from alphagov/refactor-sending 
Refactor and tidy up sending
 2016-05-17 11:40:09 +01:00
Adam Shimali
d141af4b94 If service has reply to show it in form 2016-05-17 11:35:10 +01:00
Chris Hill-Scott
5625ef6eee Merge pull request #558 from alphagov/template-stats-2 
Make template usage on dashboard easier to scan
 2016-05-17 11:26:49 +01:00
Rebecca Law
c4de547b74 Merge pull request #568 from alphagov/template_history_view 
Template history view
 2016-05-17 08:50:40 +01:00
Rebecca Law
93c4f37d08 Add lxml 3.6.0 to requirements. 2016-05-17 08:48:17 +01:00
Adam Shimali
ed74280044 Merge pull request #570 from alphagov/reply-to-email 
Admin app settings to save reply to email address for service.
 2016-05-16 17:51:05 +01:00
Chris Hill-Scott
37fff2da63 Revert "Install lxml first on ubuntu" 
This reverts commit 844f9c4276.
 2016-05-16 17:22:26 +01:00
Rebecca Law
844f9c4276 Install lxml first on ubuntu 2016-05-16 16:43:55 +01:00
Chris Hill-Scott
d39717d348 Merge pull request #567 from alphagov/uncomment-out-tests 
Uncomment commented-out tests
 2016-05-16 14:29:10 +01:00
Adam Shimali
18a0b94d98 Admin app settings to save reply to email address for service. 2016-05-16 13:10:51 +01:00
Chris Hill-Scott
000d630cae Use Spreadsheet class to generate example CSVs 
This means not repeating a bunch of `with StringIO` blocks all
over the place.
 2016-05-16 13:05:41 +01:00
Chris Hill-Scott
e84436d0e1 Make s3upload function return the UUID 
Generating the UUID can be can be contained within this function,
thus any other part of the code using it doesn’t have to do the
ID-generating stuff itself.
 2016-05-16 13:05:41 +01:00
Chris Hill-Scott
b35f2d7e61 Merge pull request #565 from alphagov/accept-common-spreadsheet-formats 
Accept common spreadsheet formats, not just CSV
 2016-05-16 13:05:14 +01:00
Rebecca Law
d4225de45e Update json structure for unit tests. 2016-05-16 11:53:22 +01:00
Chris Hill-Scott
f2a5d77853 Uncomment commented-out tests 
Accidentally(?) introduced in 2792bece54
 2016-05-16 10:53:15 +01:00
Chris Hill-Scott
7bbc307a3e Handle files that can’t be interpreted as spreadsheets 
There shouldn’t be a case where we see a `ValueError` on upload any
more. Our file handling should be robust enough to deal with whatever is
thrown at it.

This commit:
- adds test files with bad data (PNG files with their extensions changed to look
  like spreadsheets)
- catches whatever exceptions are raised by trying to parse these files
- returns a helpful flash message to the user

Anything else should raise a `500`, eg if the file can’t be uploaded to S3.
 2016-05-15 22:11:01 +01:00