Commit Graph

3517 Commits

Author SHA1 Message Date
Carlo Costino
f7efceba44 Fix permissions check for inviting users to a service
This changeset reverts a change we had made previously where we accidentally locked down the ability for service admins to invite other users to their own service.  This removes the platform admin user check and reverts it back to the proper permissions check (including adjusting the tests to account for this).

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2023-12-11 10:47:21 -05:00
Kenneth Kehl
d218fd2178 notify-admin-529 remove provider view 2023-12-06 13:40:15 -08:00
Carlo Costino
d226afcb3c Merge pull request #973 from GSA/notify-admin-931
Notify admin 931 add a preferred timezone widget
2023-12-05 16:47:57 -05:00
Kenneth Kehl
cee2552706 notify-admin-931 2023-12-04 14:52:48 -08:00
Carlo Costino
e26967acac Merge pull request #949 from GSA/notify-admin-901
Create UI changes to let people know of considerations when using Non-ISO character sets
2023-12-04 13:28:53 -05:00
Kenneth Kehl
417c072382 maybe fix 404 on signout 2023-11-29 10:24:09 -08:00
Kenneth Kehl
da3fa99c52 merge from main 2023-11-29 07:26:43 -08:00
Carlo Costino
86fbaee27d Adjust positional arguments flagged by flake8-bugbear
The new release of flake8-bugbear is starting to flag positional argument unpacking that comes after keyword arguments in function calls as a style warning that fails.  This is a good thing to catch because it can lead to unexpected side effects with function arguments and/or errors thrown by Python.

See the following links for more details:

- https://stackoverflow.com/questions/58961715/python-value-unpacking-order-in-method-parameters
- https://github.com/python/cpython/issues/82741

This changeset fixes a couple of instances where the positional argument unpacking was happening after keyword arguments were being provided.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2023-11-29 09:39:44 -05:00
Kenneth Kehl
65e6812385 use markup so html link renders in template 2023-11-28 14:43:12 -08:00
Kenneth Kehl
1cacd3b850 update warning message, fix tests 2023-11-28 07:42:33 -08:00
Kenneth Kehl
c74ab6ff27 fix flake8 2023-11-27 14:49:20 -08:00
Andrew Shumway
984f435075 Merge branch 'main' of https://github.com/GSA/notifications-admin into notify-786 2023-11-22 11:55:57 -07:00
Andrew Shumway
3d0460a9ee Revert missing logic 2023-11-22 11:55:40 -07:00
Kenneth Kehl
7e33178b1c Merge pull request #929 from GSA/notify-admin-861
Change timezone displays to Eastern time
2023-11-22 10:49:16 -08:00
Andrew Shumway
53a3f4c852 Remove unnecessary logic/fix tests 2023-11-22 11:06:15 -07:00
Carlo Costino
4571a8bd15 Apply suggestions from code review
Updating variable name from et to preferred_tz
2023-11-22 13:06:04 -05:00
Kenneth Kehl
e55a9273bf code review feedback 2023-11-22 08:28:07 -08:00
Kenneth Kehl
ad0ed0d6fb merge from main 2023-11-22 08:21:34 -08:00
Kenneth Kehl
425f8eb742 code review feedback 2023-11-22 08:09:28 -08:00
Andrew Shumway
e7a3b98fff Refactor list comprehension 2023-11-20 10:39:39 -07:00
Andrew Shumway
5d97856a81 Merge branch 'main' of https://github.com/GSA/notifications-admin into notify-786 2023-11-17 11:19:50 -07:00
Andrew Shumway
654b406827 Added/fixed tests to remove notify from message flow 2023-11-17 11:19:26 -07:00
Kenneth Kehl
36987e7202 notify-api-861 show eastern time 2023-11-16 12:24:27 -08:00
Carlo Costino
969ecb39af Merge pull request #920 from GSA/notify-admin-916
notify-admin-916 revert restrictions on create service
2023-11-14 17:08:44 -05:00
Kenneth Kehl
83dfdc31f2 fix flake8 2023-11-14 11:13:16 -08:00
Kenneth Kehl
31fb43e45c notify-admin-487 platform admin view errors 2023-11-14 10:39:24 -08:00
Kenneth Kehl
22d728f0f8 cleanup 2023-11-14 10:14:35 -08:00
Andrew Shumway
009773eb1b Merge branch 'main' of https://github.com/GSA/notifications-admin into notify-786 2023-11-14 09:34:33 -07:00
Kenneth Kehl
b1bd51730d notify-admin-916 revert restrictions on create service 2023-11-14 07:51:56 -08:00
Kenneth Kehl
d1682c641d fix flake 8 2023-11-14 07:14:27 -08:00
Kenneth Kehl
bc3928cb0f fix logout 2023-11-14 07:11:40 -08:00
Kenneth Kehl
bda164f2a1 fix flake8 2023-11-10 14:10:49 -08:00
Kenneth Kehl
6f9e55cba0 debug and etc 2023-11-10 11:08:52 -08:00
Kenneth Kehl
853af1040e merge from main 2023-11-10 09:10:56 -08:00
Kenneth Kehl
b50bdf2f21 merge from main 2023-11-07 07:44:37 -08:00
Andrew Shumway
5d8f3e43ea Merge branch 'main' of https://github.com/GSA/notifications-admin into notify-786 2023-11-06 12:48:18 -07:00
Kenneth Kehl
5da110ded4 merge from main 2023-11-02 14:13:43 -07:00
Kenneth Kehl
e5403a52f1 notify-admin-338 login.gov integration 2023-11-02 14:10:22 -07:00
Kenneth Kehl
1d790868f3 merge from main 2023-10-31 12:22:06 -07:00
Kenneth Kehl
222c83ebbc notify-admin-571 add platform_admin condition for create service and create user 2023-10-23 14:41:31 -07:00
Kenneth Kehl
782cff2d5f fiddle with logout 2023-10-20 09:34:39 -07:00
Kenneth Kehl
7ca258b547 work on logout 2023-10-20 08:48:04 -07:00
Kenneth Kehl
1d1e7747d0 cleanup login.gov work 2023-10-19 12:22:36 -07:00
Kenneth Kehl
86ac810fff initial for login.gov integration 2023-10-18 15:18:37 -07:00
Jonathan Bobel
167023c7a7 - Updated nav to allow for the active state throughout Service sub-nav
- Fixed test for using-notify broken link
2023-10-12 13:52:03 -04:00
Jonathan Bobel
3e7a4f78f3 Committing before merge 2023-10-12 10:21:11 -04:00
Andrew Shumway
7ec9a5a4f8 Remove notify from senders message flow 2023-10-06 11:41:43 -06:00
Jonathan Bobel
d6205bc1ff 835 - Change "new template" wording 2023-10-03 11:14:21 -04:00
Carlo Costino
02891b9b36 Merge pull request #784 from GSA/notify-admin-769
notify-admin-652 create new service does not work in demo
2023-09-21 11:48:46 -04:00
Kenneth Kehl
e3490691d3 notify-admin-762 fix tests 2023-09-19 14:30:32 -07:00