darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 10:53:28 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,369 Commits 51 Branches 59 Tags
8351d9828909e067faa9783aa0ad14f7b0e70057
Commit Graph

1369 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Adam Shimali
8351d98289 Merge pull request #387 from alphagov/template-stats-on-dashboard 
Template statistics now surfaced on dashboard.
 2016-04-05 14:19:45 +01:00
Adam Shimali
dc7964efd7 Fix service id bug in template. Use current_service instead 2016-04-05 14:12:18 +01:00
Chris Hill-Scott
c5be08380e Merge pull request #391 from alphagov/fix-hidden-trial-mode-link 
Fix hidden trial mode link
 2016-04-05 13:59:42 +01:00
Adam Shimali
eade0ef971 Added test for template stats client. 
Removed date column from recently used templates table.
 2016-04-05 13:50:42 +01:00
Chris Hill-Scott
0e22c9b2e0 Fix hidden trial mode link 
This link wasn’t styled, therefore it had, by default, the same colour
as its background (blue).

This commit explicitly sets it to be white, so it is visible against its
background.
 2016-04-05 13:44:53 +01:00
Chris Hill-Scott
94987a26c8 Merge pull request #389 from alphagov/fix-broken-links-tour 
Fix broken links on tour pages
 2016-04-05 13:30:47 +01:00
Chris Hill-Scott
98ce65b825 Fix broken links on tour pages 2016-04-05 13:24:57 +01:00
Chris Hill-Scott
53883fc162 Merge pull request #384 from alphagov/fix-heading-send-page 
Fix incorrect heading on send page
 2016-04-05 12:14:26 +01:00
Chris Hill-Scott
07709ba3c8 Merge pull request #386 from alphagov/whitelist-bug-fix 
Fix bug with whitelist
 2016-04-05 12:08:25 +01:00
Chris Hill-Scott
9327f83411 Fix bug with whitelist 
Implements https://github.com/alphagov/notifications-utils/pull/17
 2016-04-05 11:59:17 +01:00
Adam Shimali
159fe60c1a Template statistics now surfaced on dashboard. 
Job list removed.

Template statistics retrieved at same time as
notification stats.
 2016-04-05 11:47:24 +01:00
NIcholas Staples
ff3dd857ec Merge pull request #385 from alphagov/filter_history_bug 
Bug fixed, links now work. All tests passing.
 2016-04-05 11:42:00 +01:00
Nicholas Staples
359d1c29cb Bug fixed, links now work. All tests passing. 2016-04-05 11:29:24 +01:00
Chris Hill-Scott
7153be1fc6 Fix incorrect heading on send page 
Accidentally reverted here: f84797e6d5 (diff-f7abe60b3b6c55859d983b3e19008838L14)

Matches the link on the choose template page.
 2016-04-05 11:20:52 +01:00
Chris Hill-Scott
18633c0574 Force Travis to redeploy 
This is an empty commit.

Travis missed the last merge onto master because Github was having an
outage.

Seems like the only way to force it to redploy is to update the branch.
 2016-04-05 10:45:34 +01:00
Chris Hill-Scott
69e868f454 Merge pull request #380 from alphagov/svg-images-tour 
Use SVG images for tour
 2016-04-05 10:28:26 +01:00
Chris Hill-Scott
2652e6abee Merge pull request #377 from alphagov/sort-out-help-pages 
Split Help page into Trial Mode and Pricing pages
 2016-04-05 10:20:57 +01:00
Chris Hill-Scott
b912fa3f66 Merge pull request #376 from alphagov/dont-accepted-csv-with-restricted-recipients 
Show error if restricted service uploads real CSV
 2016-04-05 10:16:20 +01:00
catherineheywood
6ad3c8a6ed minor changes to doc 2016-04-05 10:16:03 +01:00
Chris Hill-Scott
a7849bf166 Merge pull request #381 from alphagov/fix-csv-reupload 
Fix re-uploading of CSV files
 2016-04-05 10:09:04 +01:00
Chris Hill-Scott
c95123914a Fix re-uploading of CSV files 
The problem
---

1. Upload a CSV with problems
2. See the validation errors on the page
3. Try to re-upload the file
4. Get this error:

> Method Not Allowed
> The method is not allowed for the requested URL.

https://www.pivotaltracker.com/story/show/116882241

The cause
---
The POST route for the check page (where you see errors in your files)
was removed here:
f3fd5f6b15 (diff-1dd8b3bf53dfd9382c7721051f3d930dR280)

The fix
---
This commit adds:
- a simple route which re-calls the initial ‘I have uploaded a file’ route
- a test to make sure that both of these routes are POSTed to
 2016-04-05 09:02:52 +01:00
Chris Hill-Scott
7a0a81c07c Show error if restricted service uploads real CSV 
Implements: https://github.com/alphagov/notifications-utils/pull/16

Also changes a bunch of the mocked phone numbers to be real-looking so
that the tests are checking for the right kind of error.
 2016-04-04 17:17:52 +01:00
NIcholas Staples
6992041027 Merge pull request #369 from alphagov/remember_last_used_service_in_session 
All tests working and home page is now dependent on the service in th…
 2016-04-04 17:09:37 +01:00
Chris Hill-Scott
0a3567ec48 Add page <title>s to tour pages 2016-04-04 17:08:30 +01:00
Nicholas Staples
c31c55666b Added current_service to flask context and template context. 
Fix all tests and conflicts.

Removed comment line.
 2016-04-04 17:01:20 +01:00
Chris Hill-Scott
47b86e70df Use SVG images for tour 
SVG images will look sharper and scale more cleanly. However they are
not supported on older browsers[1]

> The <picture> element allows for fallback images when the browser
> doesn't support a specified image format.

`<picture>` is supported in the latest versions of Chrome, Firefox, IE
(Edge), Safari and Android, so all these browsers will get the SVG
version.

Older browsers will fall back to the PNG version.

[1] http://caniuse.com/#feat=svg
[2] https://css-tricks.com/a-complete-guide-to-svg-fallbacks/#fallback-svg-as-img-picture
[3] http://caniuse.com/#feat=SVG
 2016-04-04 16:55:06 +01:00
NIcholas Staples
f444284580 Merge pull request #379 from alphagov/filter_notifications_page 
Working functionality for filtering notifications and all tests passing.
 2016-04-04 16:43:57 +01:00
Nicholas Staples
a41dda8884 Working functionality for filtering notifications and all tests passing. 2016-04-04 16:34:06 +01:00
Henry Hadlow
e51f7066e4 Merge branch 'sort-out-help-pages' of github.com:alphagov/notifications-admin into sort-out-help-pages 
* 'sort-out-help-pages' of github.com:alphagov/notifications-admin:
  Split Help page into Trial Mode and Pricing pages
 2016-04-04 16:30:55 +01:00
Henry Hadlow
19c01101c3 Remove commented content -- still in git history 2016-04-04 16:28:21 +01:00
Henry Hadlow
ac576c6529 Split Help page into Trial Mode and Pricing pages 
- Add routes
- Add footer links
- Make heading size consistent on Cookies page
 2016-04-04 16:03:52 +01:00
Henry Hadlow
c23e22a0df Fix tests -- update link on Request to go live page 2016-04-04 15:29:54 +01:00
Henry Hadlow
246023616a Split Help page into Trial Mode and Pricing pages 
- Add routes
- Add footer links
- Make heading size consistent on Cookies page
 2016-04-04 15:23:24 +01:00
catherineheywood
dc5c552f5f Doc changes 2016-04-04 14:37:35 +01:00
catherineheywood
b5565c11e7 Initial doc 2016-04-04 13:42:41 +01:00
Chris Hill-Scott
7307d77923 Merge pull request #370 from alphagov/add-tour 
Make first time use clearer
 2016-04-04 13:40:37 +01:00
Chris Hill-Scott
8e69e78bed Merge pull request #373 from alphagov/sign-in-in-header 
Put sign in in the header
 2016-04-04 12:22:54 +01:00
Chris Hill-Scott
92568e93ce Merge pull request #372 from alphagov/improve-csv-examples 
Improve csv examples
 2016-04-04 12:22:41 +01:00
Chris Hill-Scott
94e8b2a685 Use template name as file name for example CSV 
`11.csv` or `9a1d8a7f-c202-43b9-9239-68939d34fec6.csv` is not very friendly.

`Two week reminder.csv` is much nicer.
 2016-04-04 11:09:55 +01:00
Chris Hill-Scott
f84797e6d5 Show an example of a CSV on the ‘send’ page 
This should help:
- understanding of what the CSV should contain
- understanding what ‘download example’ will do
 2016-04-04 11:09:18 +01:00
Chris Hill-Scott
5fd5544a8c Use context managers for StringIO 
It’s possible that leaving a StringIO stream open could cause a memory
leak. Using a context manager closes it automatically when it’s finished
with.
 2016-04-04 11:05:17 +01:00
Chris Hill-Scott
33d9a461db Put two rows in example CSV file 
We reckon that this will help people understand that the first row is
headers and the subsequent rows are the users’ data.
 2016-04-04 11:05:17 +01:00
Chris Hill-Scott
953be15d84 Make form error messages consistent 
We were using a bunch of different styles for form error messages,
including:
- having the name of the field in the error, or not
- can not/cannot/can’t (GDS content styleguide recommends using
  contractions)
 2016-04-04 10:44:53 +01:00
Chris Hill-Scott
a653759bda Merge pull request #371 from alphagov/better-words 
Tweak some wording
 2016-04-04 10:38:08 +01:00
Chris Hill-Scott
c985e9a51c Put sign in in the header 2016-04-04 10:00:40 +01:00
Chris Hill-Scott
7625e184e2 Replace ‘send a batch’ with ‘send from a CSV file’ 
This is better. Not done enough testing to know if it’s the best, but
let’s try it.
 2016-04-04 09:38:14 +01:00
Chris Hill-Scott
95b75d8220 Add a hint to ‘Template name’ text input 
We’ve seen lots of users unsure what the ‘template name’ field is for,
especially on first use. Is it the subject line of the text message?
Will it be who the message comes from? Answer: neither.

So this commit adds a hint to make that clearer.
 2016-04-04 09:35:59 +01:00
Chris Hill-Scott
42cb4b0d99 Remove the verbs from the navigation 
Because ‘Send text messages’ isn’t very helpful if you’re looking to
edit a template.

It also helps front-load the navigation, ie ‘Team’ is the first word,
rather than the more generic ‘Manage’.
 2016-04-04 09:33:29 +01:00
Chris Hill-Scott
b9cd669439 Remove some banners which aren’t used/wanted 2016-04-04 09:25:41 +01:00
Chris Hill-Scott
6030cccb5d Remove the ‘next step’ banner from choose template 
This page should be obvious enough that this banner isn’t needed. Will
have to keep an eye on this.
 2016-04-04 09:25:41 +01:00