darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-18 16:21:49 -04:00
Code Issues Packages Projects Releases Wiki Activity
10,384 Commits 49 Branches 59 Tags
78fcf8bf353e4d94584cee5c70008f2f34ee8010
Commit Graph

10384 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
78fcf8bf35 Merge pull request #3613 from alphagov/show-international-immediately 
Show international postage as soon as address is entered
 2020-09-09 09:59:52 +01:00
Chris Hill-Scott
cd7260dd80 Show international postage as soon as address is entered 
At the moment we don’t check whether a one-off letter is international
until the user’s clicked send. It’s more accurate to show that the
letter will be sent internationally as soon as we know the address.

Depends on:
- [ ] https://github.com/alphagov/notifications-utils/pull/786
 2020-09-09 09:20:56 +01:00
Tom Byers
9e6daecba3 Merge pull request #3610 from alphagov/fix-pill-tab-problems 
Fix pill tab problems
 2020-09-08 14:51:12 +01:00
David McDonald
9664af387e Merge pull request #3608 from alphagov/more-maps 
Add map of broadcast areas to view-broadcast page
 2020-09-08 14:26:16 +01:00
Chris Hill-Scott
ed7be81181 Merge pull request #3615 from alphagov/fix-extra-tracking 
Fix extra tracking on numeric inputs
 2020-09-08 13:46:58 +01:00
Pea M. Tyczynska
88a5fd56bf Merge pull request #3609 from alphagov/send-polygons-to-api 
Send simple polygons to API along with areas
 2020-09-08 12:23:12 +01:00
Chris Hill-Scott
abdabe4571 Fix extra tracking on numeric inputs 
Since we moved to using textboxes from GOV.UK Frontend the old class
wasn’t appearing in the page.
 2020-09-08 12:02:03 +01:00
Tom Byers
58ad6fe4c7 Remove pill-item__label--selected class 
It was used to mark labels of selected items when
we thought they might need extra styling but is
now redundant.
 2020-09-08 11:46:32 +01:00
David McDonald
602386bd4e Merge pull request #3612 from alphagov/pyup-scheduled-update-2020-09-07 
Scheduled weekly dependency update for week 36
 2020-09-08 10:17:12 +01:00
Rebecca Law
7cae303104 Fix unit tests for changes to the pill component. 2020-09-08 10:12:23 +01:00
David McDonald
ef134c6b6c freeze requirments 2020-09-08 09:52:14 +01:00
pyup-bot
2fc8ce5fa0 Update eventlet from 0.26.1 to 0.27.0 2020-09-07 14:54:02 +01:00
Chris Hill-Scott
821d9f20e0 Merge pull request #3604 from alphagov/no-assert-not-called 
Remove uses of .assert_not_called
 2020-09-07 12:58:20 +01:00
Chris Hill-Scott
3af8ed521d Merge pull request #3594 from alphagov/fix-live-search-sub-areas 
Don’t filter ‘All of’ choice with live search
 2020-09-07 12:57:58 +01:00
Chris Hill-Scott
fe6feb313c Merge pull request #3611 from alphagov/line-7-address-example 
Show address line 7 not postcode in example spreadsheet
 2020-09-07 12:39:51 +01:00
Chris Hill-Scott
2a6c058c0f Merge pull request #3602 from alphagov/fix-chrome-autofill-font-size 
Fix font-size when Chrome autofills inputs
 2020-09-07 12:39:40 +01:00
Chris Hill-Scott
0459e26be9 Show address line 7 not postcode in example spreadsheet 
Since the letter preview will now show address line 7, the example
spreadsheet we give should match.
 2020-09-07 12:00:27 +01:00
Rebecca Law
5194eba076 Merge pull request #3466 from alphagov/international-letters-form 
Let users switch international letters on and off
 2020-09-07 10:02:19 +01:00
Rebecca Law
52954191fa Merge branch 'master' into international-letters-form 2020-09-07 09:45:17 +01:00
Rebecca Law
0f64d4d136 Merge pull request #3564 from alphagov/int-letters-content 
Add international letter rates to pricing page
 2020-09-07 08:13:43 +01:00
Pea Tyczynska
3bfe3a2bf7 Send simple polygons to API along with areas 
When creating broadcast message, or updating it.
We want to send simple polygons to API so we can
later relay them to the broadcast provider.

Test that update broadcast message sends polygons correctly
 2020-09-04 16:55:02 +01:00
Tom Byers
452e253e2c Make the selected pill item a link 
All other navigations have their selected item as
a link so we should match this.

Includes changes to the pill CSS so:
1. it doesn't use elements in the selectors
2. all the selectors use BEM

I did 2. because I had to change the
classes/selectors anyway, they might as well match
the style GOVUK Design System uses.
 2020-09-04 16:17:04 +01:00
karlchillmaid
f775e18361 Add price update date 
Added Monday's date, as that's when we plan to merge and deploy.
 2020-09-04 14:28:23 +01:00
David McDonald
bf5ee37d6c Add margin to area list above map as looks cleaner 2020-09-04 10:27:19 +01:00
David McDonald
be563e73c6 Add map in details to broadcast view 
Avoided using `closest` as not supported by IE8-11
https://caniuse.com/#search=closest

Used `parentElement` supported by IE9+
https://caniuse.com/#search=parentElement

Used `className` as supported by IE9+
https://caniuse.com/#search=className

Also rearranged the javascript for maps such that figuring out the
polygon array is done first and then the time when we need to have the
details component open before closing it again is kept to minimum
 2020-09-04 10:20:54 +01:00
Tom Byers
c6711a113c Update h1 on pill pages to work with new pill 
Pill pages are:
- /notifications
- /template-usage
- /monthly
- /organisations/<organisation_id>
- /templates

Includes changes to:
- the folder-path component
- the page-header component

...all their h1s have the same id.
 2020-09-04 09:02:36 +01:00
Tom Byers
48902a2bac Give all h1s an id 2020-09-04 09:02:36 +01:00
Tom Byers
9598d3a97b Change pills from tabs to navigation 
Changes the HTML to do the following:
- remove all tabs semantics
- give the list a role of navigation
- label the navigation with the h1
- mark the selected item with aria-current
 2020-09-04 09:02:36 +01:00
David McDonald
32a794aacd Move styling into separate files for reuse 2020-09-03 10:50:58 +01:00
Tom Byers
3bebb1fbfd Merge pull request #3607 from alphagov/add-missing-closing-tag 
Add missing `</span>`
 2020-09-02 16:05:59 +01:00
Tom Byers
d9655f16f5 Add missing </span> 
Missed out from this PR:

https://github.com/alphagov/notifications-admin/pull/3593
 2020-09-02 15:53:49 +01:00
Tom Byers
afb8669b2f Merge pull request #3597 from alphagov/fix-pill-spacing-2nd-attempt 
Fix spacing in pill items
 2020-09-02 11:16:40 +01:00
Tom Byers
0560066638 Change mixins-before-declarations Sass-lint rule 
We write our Sass to be mobile-first, meaning we
declare the value for a property (for mobile) and
then add all other variations (for other
viewports) afterwards.

Because of this, we need mixins that produce media
queries to be able to follow declarations.

This extension to the rule is also hinted at as
good practice in the docs:

7847511b61/docs/rules/mixins-before-declarations.md
 2020-09-02 10:59:31 +01:00
karlchillmaid
ae1dc14ff2 Update heading class and add ID 2020-09-01 18:36:33 +01:00
David McDonald
7e934a9e4a Merge pull request #3606 from alphagov/pyup-scheduled-update-2020-08-31 
Scheduled weekly dependency update for week 35
 2020-09-01 16:57:45 +01:00
David McDonald
511ed6daf0 make freeze requirements 2020-09-01 16:46:25 +01:00
Tom Byers
676a9297fe Merge pull request #3593 from alphagov/fix-link-and-button-text-across-pages 
Fix link and button text across pages
 2020-09-01 15:11:09 +01:00
pyup-bot
ec5a1cff12 Update shapely from 1.7.0 to 1.7.1 2020-08-31 14:54:04 +01:00
pyup-bot
96e2293d4d Update pyexcel-xls from 0.5.8 to 0.5.9 2020-08-31 14:54:03 +01:00
pyup-bot
7e898827d6 Update pyexcel from 0.6.3 to 0.6.4 2020-08-31 14:54:02 +01:00
Pea M. Tyczynska
84e3a7ffd5 Merge pull request #3601 from alphagov/only-govt-users-can-be-invited-to-broadcast-services 
Broadcast: only approved domain users can be invited
 2020-08-28 15:04:50 +01:00
Pea Tyczynska
e0faad6cea Only approved email domain users can be invited 
to broadcast services. This is done to improve security.
 2020-08-28 14:41:03 +01:00
Tom Byers
457c3336b9 Merge pull request #3603 from alphagov/fix-template-id-copy-to-clipboard 
Fix comparison in api_key component
 2020-08-28 13:56:58 +01:00
Chris Hill-Scott
1e55a8cbbe Remove uses of .assert_not_called 
I prefer to avoid `assert_not_called`, because if I make a typo like
this, the tests will still pass:
```
    app.invite_api_client.create_invite.asset_not_called()
```

It’s harder to have a false positive with the statement written this
way:
```
    assert app.invite_api_client.create_invite.called is False
```
 2020-08-28 13:26:14 +01:00
Tom Byers
aff584b933 Fix comparison in api_key component 
We can't control the case of either 'name' or
'thing' so the comparison should make them both
the same.
 2020-08-28 13:07:38 +01:00
Tom Byers
d446a91a8e Merge pull request #3591 from alphagov/fix-copy-to-clipboard 
Fix copy to clipboard
 2020-08-28 10:58:36 +01:00
Chris Hill-Scott
a1607ef6fa Fix font-size when Chrome autofills inputs 
For some reason Chrome decides that using its own font declaration is
preferable to keeping the input looking as it would without autofill.

This overrides that with our bigger, better font.
 2020-08-28 10:31:44 +01:00
Chris Hill-Scott
786946639b Merge pull request #3599 from alphagov/fix-autofocus 
Fix the autofocus component
 2020-08-28 10:15:58 +01:00
Chris Hill-Scott
344d8646a3 Merge pull request #3590 from alphagov/buffer-de-buffer 
Make simplification of polygons more sophisticated
 2020-08-28 10:15:49 +01:00
Chris Hill-Scott
38a95d9fdc Merge pull request #3600 from alphagov/tour-4-not-sms 
Reword title of screen 4 of broadcast tour
 2020-08-27 14:44:26 +01:00