darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-30 02:50:03 -04:00
Code Issues Packages Projects Releases Wiki Activity
7,887 Commits 58 Branches 59 Tags
6fc163526652124b5cdfb7c19877eba240efc935
Commit Graph

7887 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
6fc1635266 Rename some of the settings 
This reflects the language we use for these things when talking about
them amongst ourselves.
 2019-06-03 14:12:12 +01:00
Chris Hill-Scott
80e6c1654b Make organisation settings one table 
There’s no longer a difference between regular settings and platform
admin settings – it’s all platform admin.
 2019-06-03 14:12:12 +01:00
Chris Hill-Scott
3b22216a68 Remove redundant decorators 
`@user_has_permissions` is overridden by @user_is_platform_admin – it
doesn’t make sense to have them used together.
 2019-06-03 14:12:12 +01:00
Chris Hill-Scott
647daa6ca4 Make organisation settings platform admin only 
At the moment the only setting that a normal organisation team member
can change is the name of the organisation is its name. And we don’t
even want them to be able to change this. So this commit hides the
settings page entirely for non-platform-admin users.
 2019-06-03 14:12:11 +01:00
Pea (Malgorzata Tyczynska)
c55c2a2f56 Merge pull request #2993 from alphagov/fix_test_send_placeholders 
Fix error where sending test message flow skipped first placeholder
 2019-05-30 15:57:13 +01:00
Pea Tyczynska
bafa4e345b Change assertion for consistency 2019-05-30 15:45:17 +01:00
Chris Hill-Scott
3deff78a75 Merge pull request #2988 from alphagov/loading-spacing 
Remove spacing tweak on loading indicator
 2019-05-30 13:54:32 +01:00
Leo Hemsted
3a1282d03f Merge pull request #2987 from alphagov/org-trial-services 
move trial mode services from org dashboard to separate page
 2019-05-30 11:19:17 +01:00
Pea Tyczynska
8286e86a9e Harmonise behaviour of Change reply-to email address 
So it acts the same on inital edit and after verification failed.
And also so it does not allow to untick default address in the
latter situation.
 2019-05-29 17:02:57 +01:00
Pea Tyczynska
4905be510f Update tests so they work with the fix 2019-05-29 16:56:55 +01:00
Pea Tyczynska
21ab8638b9 Fix error where sending test message flow skipped first placeholder 
first way round and then collected placeholders again. Now the flow
collects all placeholders in one round.

Also fix the back link for step-1 for test flow so it goes back
to choosing recipient number

Also move operators around following flake8's advice :)
 2019-05-29 16:56:55 +01:00
Pea (Malgorzata Tyczynska)
378fec281a Merge pull request #2974 from alphagov/check_reply_to_address 
Verify email reply-to address
 2019-05-29 10:36:18 +01:00
Pea (Malgorzata Tyczynska)
a0c21baca9 Apply suggestions from code review 
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2019-05-28 17:20:30 +01:00
Leo Hemsted
4375c3d151 move to model based code layout 2019-05-28 16:46:12 +01:00
Leo Hemsted
9795f2b838 move trial mode services from org dashboard to separate page 
the new page is platform admin only, and also has search built in
also, split test_organisation_invites into two files
 2019-05-28 16:17:29 +01:00
Chris Hill-Scott
a65450b118 Merge pull request #2990 from alphagov/fidejoseph-patch-1 
Update email_domains.yml
 2019-05-28 15:37:17 +01:00
fidejoseph
39271d9e6a Update email_domains.yml 
Adding Scottish Qualifications Authority
 2019-05-28 10:31:30 +01:00
Pea Tyczynska
4fd9e91993 Do not verify email when updated email address did not change 2019-05-24 11:22:20 +01:00
Pea Tyczynska
934bcb919f Reduce timeout to 45 seconds following analysis by Chris H-S: 
"Failure is slower than success. So the longer a notification
takes to get a status, the more likely it is for that status
to be a failure anyway. This increases dramatically after 45 seconds.
The percentage of emails that go to delivered in less than 90 seconds
is 98.92%. To get to 99% we’d need to increase the timeout
to 178 seconds (3 minutes). We could still get 98.7% of notifications
by dropping the timeout to 45 seconds, and improve the experience
for notifications that are likely to fail by returning an error more quickly."
 2019-05-23 15:34:25 +01:00
Pea (Malgorzata Tyczynska)
44ddd287b5 Code refactor, details below: 
Apply suggestions from code review

Reduce max verification waiting time to 90 seconds

Also minor changes following peer review

Co-Authored-By: Chris Hill-Scott <me@quis.cc>

Use constants for notification status collections on verify reply-to

email address

Use a cleaner way of adding request arguments to url_for()
 2019-05-23 15:34:25 +01:00
Pea Tyczynska
200fff6c66 Different back links and form actions on verify page depending if add or change 2019-05-23 15:34:25 +01:00
Pea Tyczynska
e406be3f80 Ensure that when updating reply-to email address old address is replaced 
Also fix tests
 2019-05-23 15:34:25 +01:00
Pea Tyczynska
6cf9959058 Stop AJAX when success or failure and show form on failure 
AJAX requests stop on success or failure, as the waiting page
does not have to referesh any longer.

Also on failure a form that allows user to try again
is shown.
 2019-05-23 15:34:25 +01:00
Pea Tyczynska
06ab7a5b1f Add continue button to success page and edit back link destination 2019-05-23 15:34:24 +01:00
Pea Tyczynska
3251fc4e00 Change content for email reply-to verification journey 
Earlier commits used placeholder content while awaiting official
content.
 2019-05-23 15:34:24 +01:00
Pea Tyczynska
441c1f441b Verify email address when editing reply-to address 
Also fix the tests
 2019-05-23 15:34:24 +01:00
Pea Tyczynska
431d2162c0 Fail reply-to email verification if no delivery within 5 minutes 2019-05-23 15:34:24 +01:00
Pea Tyczynska
ea314ad75f Deal with duplicate reply-to email addresses 2019-05-23 15:34:24 +01:00
Pea Tyczynska
8f3b560a4e Use ajax to auto-refresh reply-to email verifiaction page 2019-05-23 15:34:24 +01:00
Pea Tyczynska
9d2b60b56b Show try again link when email verification fails 2019-05-23 15:34:24 +01:00
Pea Tyczynska
ed599f0c03 Save new reply-to email if test notification delivered 
Also check if it should be a default reply-to email address
 2019-05-23 15:34:24 +01:00
Pea Tyczynska
45ac0d7812 Waiting page shows correct messages 2019-05-23 15:34:23 +01:00
Pea Tyczynska
d70afddf51 Send request to api to check if reply-to address is working 2019-05-23 15:34:23 +01:00
Chris Hill-Scott
3137c5acf6 Remove spacing tweak on loading indicator 
It’s not needed when there’s no whitespace around the text.
 2019-05-23 11:34:34 +01:00
Chris Hill-Scott
238c56faec Merge pull request #2984 from alphagov/fix-double-heading-letter-branding 
Fix duplicated H1 on ‘New letter branding’ page
 2019-05-23 10:36:08 +01:00
Chris Hill-Scott
741114a9fd Merge pull request #2986 from alphagov/fidejoseph-patch-1 
Update email_domains.yml
 2019-05-22 16:07:32 +01:00
fidejoseph
efbb700cc2 Update email_domains.yml 
Adding suttonmail.org (domain provided by London Grid for Learning) - a network of state-funded schools in Sutton
 2019-05-22 15:54:47 +01:00
Chris Hill-Scott
9d1a7904a8 Fix duplicated H1 on ‘New letter branding’ page 
For accessibility reasons a page should have one (and only one) H1. This
commit fixes an instance where the H1 was duplicated as a result of the
work done to componentize our page headings.

It also adds an extra check to `client_request` so that we don’t
introduce pages with multiple or no H1s in the future.
 2019-05-21 16:09:00 +01:00
Chris Hill-Scott
0609229466 Merge pull request #2982 from alphagov/terse-org-set-text 
Make ‘you must set organisation’ text shorter
 2019-05-21 15:24:27 +01:00
Chris Hill-Scott
f0da3e877f Merge pull request #2981 from alphagov/new-new-button-manage-branding 
Use new ‘add’ buttons on branding management pages
 2019-05-21 15:24:20 +01:00
Chris Hill-Scott
0f43ed3f63 Merge pull request #2979 from alphagov/pyup-scheduled-update-2019-05-20 
Scheduled weekly dependency update for week 20
 2019-05-21 15:24:11 +01:00
Chris Hill-Scott
ee33f91621 Use new ‘add’ buttons on branding management pages 
‘Add’ buttons are generally:
- at the bottom of the page
- sticky
- grey
 2019-05-21 14:19:29 +01:00
Chris Hill-Scott
9d40986d53 Make ‘you must set organisation’ text shorter 
So it fits in the column.
 2019-05-20 16:15:47 +01:00
Chris Hill-Scott
431a966dee Freeze requirements 2019-05-20 16:08:00 +01:00
pyup-bot
4a7c0c8594 Update flask from 1.0.2 to 1.0.3 2019-05-20 14:55:06 +01:00
Chris Hill-Scott
b1df698cf7 Merge pull request #2978 from alphagov/wmca.org.uk 
Adding wmca to allowed domains
 2019-05-20 13:57:49 +01:00
Pete Herlihy
8abf8b85ca Adding wmca to allowed domains 
West Midlands Combined Authority
 2019-05-20 13:48:07 +01:00
Leo Hemsted
1b64388aee Merge pull request #2961 from alphagov/zdt-deploy 
update manifest file to use zdt-push
 2019-05-20 13:32:57 +01:00
Chris Hill-Scott
aca6f70c9e Merge pull request #2977 from alphagov/go-live-sla 
Add a line about how long it takes to go live
 2019-05-20 10:36:28 +01:00
Chris Hill-Scott
bd574e2aab Add a line about how long it takes to go live 
We keep getting questions about this.
 2019-05-20 09:59:00 +01:00