darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-28 13:11:05 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,291 Commits 49 Branches 59 Tags
57171d356b6bcda53907bf4c28a349342c756a5b
Commit Graph

9291 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
karlchillmaid
57171d356b Add anchor link and remove comma 2020-02-13 11:37:28 +00:00
Chris Hill-Scott
28314a526a Merge pull request #3294 from alphagov/update-introduction 
Update Delivery status page introduction
 2020-02-12 13:48:57 +00:00
Chris Hill-Scott
4f32258a7b Merge pull request #3293 from alphagov/cache-returned-letter-summary 
Cache returned letter summary in Redis
 2020-02-12 13:48:51 +00:00
David McDonald
e78ea10b49 Merge pull request #3292 from alphagov/pyup-scheduled-update-2020-02-10 
Scheduled weekly dependency update for week 06
 2020-02-12 13:40:54 +00:00
pyup-bot
2597a70d5f Update flask-wtf from 0.14.2 to 0.14.3 2020-02-12 13:33:25 +00:00
karlchillmaid
733af6ec2d Update introduction 2020-02-12 12:34:20 +00:00
karlchillmaid
38fd842d33 Merge pull request #3213 from alphagov/add-guidance-content 
Add first iteration of guidance content, including updating navigation menus and footer.
 2020-02-12 11:43:07 +00:00
Chris Hill-Scott
af8395956e Cache returned letter summary in Redis 
We’re going to start using the returned letters summary to show some
info on the dashboard.

This means we will be accessing it more often than it changes. And we
know exactly when it changes because it’s us manually submitting the
references we get from DVLA.

This makes it a good candidate for being cached, and Redis is where we
cache stuff that we’d otherwise go to the API for.
 2020-02-12 11:42:06 +00:00
karlchillmaid
98ccce5d90 Make click-throughs content clearer 2020-02-12 11:33:10 +00:00
karlchillmaid
d24d772cfa Reorder introduction content 2020-02-12 11:25:58 +00:00
karlchillmaid
0949fc6480 Update app/templates/views/guidance/edit-and-format-messages.html 2020-02-12 11:17:26 +00:00
karlchillmaid
4d7a41d55d Merge pull request #3289 from alphagov/change-callout-to-inset-text 
Change callout to inset text
 2020-02-12 11:17:07 +00:00
Leo Hemsted
b0ee3f22d9 Merge pull request #3283 from alphagov/pyup-scheduled-update-2020-02-03 
Scheduled weekly dependency update for week 05
 2020-02-11 16:30:04 +00:00
Tom Byers
1d0c2070db Merge pull request #3291 from alphagov/fix-pill-heights 
Make pill items match their heights
 2020-02-11 14:28:14 +00:00
Chris Hill-Scott
6b703614b9 Merge pull request #3280 from alphagov/swap-nav-order-org-users 
Swap order of usage and team members in navigation when organisation users are looking at a service
 2020-02-11 11:21:14 +00:00
Chris Hill-Scott
8a4bf1d07e Make test more robust 
Now tests:
- that the user doesn’t have the usage menu item when they’re not a
  member of the organisation (i.e. the counterfactual)
- that the user still gets a 403 when they try to view the usage page if
  they’re not a member of the organisation
 2020-02-11 11:11:18 +00:00
Tom Byers
4433db346b Center pill content using more flexbox 
Turns each pill item (already full height) into a
flex container with its content as a column. Uses
this to align the content (the pill label) to the
middle of the column.
 2020-02-07 17:42:53 +00:00
Tom Byers
c8d9625518 Merge pull request #3164 from alphagov/update-static-error-pages 
Update static error pages
 2020-02-07 12:49:47 +00:00
Tom Byers
76240d5d55 Fix issues from pull request review 
Fixes for the following:
- `<p>` tags need `govuk-body` class
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375921631
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375924387
- unused JS file
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375949386
- link to GDS has incorrect href
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375966464
  - https://github.com/alphagov/notifications-admin/pull/3164#discussion_r375966555
 2020-02-07 11:21:11 +00:00
Tom Byers
a5ea785474 Make pill items match their heights 2020-02-06 16:38:24 +00:00
karlchillmaid
f7e1e35dcb Remove commented-out content 
Co-Authored-By: Tom Byers <tombaromba@gmail.com>
 2020-02-06 16:06:00 +00:00
karlchillmaid
77590bb9d3 Remove commented-out content 
Co-Authored-By: Tom Byers <tombaromba@gmail.com>
 2020-02-06 16:05:32 +00:00
karlchillmaid
d646238a01 Remove commented-out content 
Co-Authored-By: Tom Byers <tombaromba@gmail.com>
 2020-02-06 16:03:48 +00:00
karlchillmaid
ccb783c43b Update app/templates/views/guidance/index.html 
Co-Authored-By: Tom Byers <tombaromba@gmail.com>
 2020-02-06 16:02:41 +00:00
karlchillmaid
a5c77a6fc3 Remove commented-out content 2020-02-06 16:01:23 +00:00
karlchillmaid
74874ee78d Remove commented-out content 2020-02-06 15:59:07 +00:00
karlchillmaid
79373909bd Add 'add' 2020-02-06 12:54:27 +00:00
karlchillmaid
5775ccb5b1 Change callout to inset text 2020-02-06 12:30:22 +00:00
Rebecca Law
94c9886a58 Merge pull request #3288 from alphagov/delete-template-dialog 
Delete template dialog
 2020-02-06 10:58:43 +00:00
Rebecca Law
b242467d77 Change the content for the delete template confirmation dialog. 
As per https://www.pivotaltracker.com/story/show/170796514 we want to make the delete template confirmation dialog box more consistent and clear.
The API has been updated with a new endpoint that only returns the last-used date, this date is more accurate since it goes to the ft_notification_status table, if the notification table is empty.
 2020-02-06 10:16:00 +00:00
Rebecca Law
60dd6bca44 Merge pull request #3287 from alphagov/check-current-user-is_authenticated 
Reorder the methods called in sign out
 2020-02-05 16:29:31 +00:00
Rebecca Law
039628cff7 Reorder the methods called in sign out 
We found another scenario where signing out of the db can cause a 500.
If the user archives their trial mode service, current_service.active = false, then signs out, the current user was being signed out client side first, meaning current_user is now an Anonymous user, next the call to the API is made to log out user on db, all calls to NotifyApiClient `check_inactive_service`, which is only authorised if user is platform_admin, but an AnonymousUser does not have that attribute, so a 500 is raise.
Seemed a bit cleaner to change the User.signout method to rather than the `check_inactive_service` method for current_user.is_authenticated.
 2020-02-05 15:58:15 +00:00
Matt Hobbs
a4a6ad04f7 Merge pull request #3279 from alphagov/image-optimisation 
Image optimisation
 2020-02-05 10:46:42 +00:00
Tom Byers
2bb651865a Remove unused images 
As per @quis's comment:

https://github.com/alphagov/notifications-admin/pull/3279#issuecomment-581902125
 2020-02-05 10:37:57 +00:00
Leo Hemsted
636a702d19 Merge pull request #3286 from alphagov/remove-api-keys 
cleanup
 2020-02-05 10:11:47 +00:00
karlchillmaid
c7983c2396 Update app/templates/views/get-started.html 
Fix b tag

Co-Authored-By: Tom Byers <tombaromba@gmail.com>
 2020-02-05 09:24:59 +00:00
Leo Hemsted
4eeddb40f8 bump reqs 2020-02-04 17:16:58 +00:00
Pea M. Tyczynska
b5723a1aef Merge pull request #3285 from alphagov/uploads-fix-letter-link 
Fix bug where job url type was constructed for letter on uploads page
 2020-02-04 16:26:49 +00:00
Tom Byers
fbff4beef5 Update app/assets/error_pages/5xx.html 
Remove unneeded GOV.UK suffix from page title on error page.

Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2020-02-04 16:07:33 +00:00
Tom Byers
0d80a4cc8b Update paas-failwhale/index.html 
Remove unneeded GOV.UK suffix from page title.

Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>
 2020-02-04 16:07:17 +00:00
Rebecca Law
143564c7f0 Update message seen when deleting a template. 2020-02-04 16:00:51 +00:00
Pea Tyczynska
9ebd18ea85 Add upload_type property to Job class 2020-02-04 15:36:55 +00:00
Leo Hemsted
5b868ff268 remove api keys from codebase 
these are just used for tests so don't need to look like real api keys.
 2020-02-04 14:44:19 +00:00
Rebecca Law
fd59491d19 Merge pull request #3284 from alphagov/fix-sign-out-bug 
Check if user is authenticated before signing out
 2020-02-04 14:37:08 +00:00
Pea Tyczynska
46292949cd Fix bug where job url type was constructed for letter on uploads page 2020-02-04 14:19:07 +00:00
karlchillmaid
ca5a92c682 Comment out 'Upload your own letters' 
Comment out 'Upload your own letters'  because this feature is not available to all users yet.
 2020-02-04 13:51:43 +00:00
karlchillmaid
92ad395fca Comment out and update content 
Comment out and update content because Upload a letter is not available to all users yet.
 2020-02-04 13:50:29 +00:00
karlchillmaid
5314ba72cc Remove 'Upload a letter' 
Remove 'Upload a letter' from navigation because it's not available to all users yet.
 2020-02-04 13:48:45 +00:00
karlchillmaid
238fcd4652 Fix spacing 2020-02-04 13:45:55 +00:00
karlchillmaid
faf983356e Add status page and email 
Add status page and email instructions to the 5xx error.

These match what we show on the 500 error page.
 2020-02-04 13:44:55 +00:00