Commit Graph

4548 Commits

Author SHA1 Message Date
Pea (Malgorzata Tyczynska)
55279c91b5 Merge pull request #2646 from alphagov/cancelled_letters
Cancelled notifications do not show as failures on dashboard stats
2019-01-11 16:04:34 +00:00
Chris Hill-Scott
3f507bfcd5 Merge pull request #2652 from alphagov/parliament.scot
Add Scottish Parliament to list of government email addresses
2019-01-11 10:35:17 +00:00
Chris Hill-Scott
f4fb2ad06b Mark agreement signed by West Lothian 2019-01-11 10:19:37 +00:00
Chris Hill-Scott
a89b0825d8 Add Scottish Parliament to list of government email addresses
We have the Welsh and UK parliaments already.

Northern Ireland’s devolved legislature use `niassembly.gov.uk`, so they’re covered by virtue of their domain ending in .gov.uk
2019-01-10 17:35:47 +00:00
Pea Tyczynska
bb1e9d2a0f Add validation-failed status to FAILURE_STATUSES in admin utils 2019-01-10 15:54:31 +00:00
Pea Tyczynska
9f99ebd53b notifications page title for failed letters is titled 'Failed letters' 2019-01-10 15:27:05 +00:00
Pea Tyczynska
dcc590ec96 Cancelled notifications do not show as failures on dashboard stats
Also update tests after we no longer show cancelled letters
2019-01-10 15:27:04 +00:00
Pete Herlihy
4c8225406c Updated Essex Council contract status and added aliases 2019-01-10 14:00:54 +00:00
Chris Hill-Scott
63cd0a7908 Mark agreement signed by Comhairle nan Eilean Siar 2019-01-10 10:03:59 +00:00
Katie Smith
1c6a71700d Update error messages for validation-failed precompiled letters 2019-01-09 13:10:36 +00:00
Katie Smith
da50f77538 Show error message if precompiled PDF cannot be opened
If PDF files have a validation error which means that they can't be
opened by PyPDF2 we would previously show the 500 status error page. We
now catch PyPDF2.utils.PdfReadErrors so that we can display a custom
error message on the notification page instead.
2019-01-09 13:10:36 +00:00
Katie Smith
bb7e9726d3 Stop showing validation-failed letters as cancelled in table
Changed the table for displaying all notifications to show letters which
have the status of 'validation-failed' as 'Validation failed' instead of
'Cancelled'.

The individual notification page for a letter which has failed
validation has not been changed since this already has a description
(letter has content outside the printable area).
2019-01-09 13:10:36 +00:00
Chris Hill-Scott
8b39bc14d1 Merge pull request #2643 from alphagov/dont-count-pages-api-message-log
Don't request pagination links for API Message log page
2019-01-09 12:27:35 +00:00
Chris Hill-Scott
606641a35e Merge pull request #2645 from alphagov/cne-siar.gov.uk
Add Comhairle nan Eilean Siar to domains list
2019-01-09 12:26:46 +00:00
Chris Hill-Scott
a34e1ea1f0 Merge pull request #2638 from alphagov/copy-template-from-folders
Allow users to navigate folders when copying
2019-01-09 12:26:29 +00:00
Chris Hill-Scott
668b0a91b2 Add Comhairle nan Eilean Siar to domains list
Comhairle nan Eilean Siar (Scottish Gaelic pronunciation: [ˈkʰõ.ərˠʎə nə ˈɲelan ˈʃiəɾ]) is the local government council for Na h-Eileanan Siar council area of Scotland, comprising the Outer Hebrides.
2019-01-09 12:02:02 +00:00
Chris Hill-Scott
30886c3cdb Merge pull request #2626 from alphagov/empty-service-state-folders
Use grey buttons to add templates when service is new
2019-01-09 10:26:43 +00:00
Alexey Bezhan
6cd18f87de Don't request pagination links for API Message log page
Counting pages for API notifications takes a long time for services
with a lot of sent messages (since it issues a `count(*)` query for
the given filter). Since API message log doesn't have a "Next page"
link we can skip the count by setting a flag on the API request.
2019-01-08 15:35:44 +00:00
Chris Hill-Scott
2ef4d1c401 Resolve aliases for Ayrshire 2019-01-08 15:12:44 +00:00
Pete Herlihy
59f260c785 And South Ayrshire... 2019-01-08 13:59:40 +00:00
Chris Hill-Scott
61b902554f …and Aberdeenshire 2019-01-08 13:03:06 +00:00
Chris Hill-Scott
206a7806d4 Allow users to navigate folders when copying
We already have a pattern for navigation folders and searching for
templates – let’s use it for the copy page too. And I reckon we can
represent services as folders if the user has multiple services they
could copy a template from.
2019-01-08 12:21:32 +00:00
Chris Hill-Scott
a1e02d1fec Mark agreement signed by North Lincs, Walsall and East Dunbartonshire 2019-01-08 11:54:14 +00:00
Pea (Malgorzata Tyczynska)
0b22fff751 Merge pull request #2639 from alphagov/quick_fix_letter_status
Format letter statuses so they make more sense to our users
2019-01-08 11:06:35 +00:00
Chris Hill-Scott
cbe5e77e69 Mark agreement signed by Hounslow council 2019-01-07 15:46:32 +00:00
Chris Hill-Scott
933dd1245b Merge pull request #2637 from alphagov/doncaster.gov.uk
Mark agreement signed by Doncaster Council
2019-01-07 15:42:23 +00:00
Pea Tyczynska
b8318c491b Format letter statuses so they make more sense to our users 2019-01-07 15:17:09 +00:00
Chris Hill-Scott
d13c071431 Mark agreement signed by Doncaster Council 2019-01-07 10:22:28 +00:00
Chris Hill-Scott
f5321346c4 Add left padding to nested radios
This makes them align horizontally with the label of their parent, so
that the layout is a bit calmer.
2019-01-04 15:30:39 +00:00
Chris Hill-Scott
3be03072a7 Reflect expanded scope of radio SASS file 2019-01-04 15:15:59 +00:00
Chris Hill-Scott
4aa4970fc9 Add grey lines to visually show level of nesting
Uses some CSS to draw some grey lines to show which radios descend from
which.

I don’t feel like the intentation is enough, and it looks a bit messy
because the circles of the radio buttons don’t have straight edges
easily suggest visual alignment.

Copies the design from conditionally revealing content in the design
system:
https://design-system.service.gov.uk/components/radios/#conditionally-revealing-content

Implementation is done with pseudo elements, because borders can’t be
positionned exactly enough.
2019-01-04 15:15:59 +00:00
Chris Hill-Scott
39506c4794 Rename ‘All templates’ 2019-01-04 15:15:58 +00:00
Tom Byers
33800c5f27 Add styles for nested lists of radios
Assumes lists that are descendants of a radio
control should be indented at the same amount as
their label text.
2019-01-04 11:59:25 +00:00
Tom Byers
9bce22f766 Swap order of move_to validators
If Optional runs before required_for_ops, it stops
the validation chain so it doesn't get to
required_for_ops. The move_to field isn't required
for the 'move-to-new-folder' operation, so this has
been removed.

This also adds comments explaining why we set
default to an empty string when instantiating the
move_to field.
2019-01-03 17:09:00 +00:00
Katie Smith
3cf36c592f Change move folder form to not have default radio btn and to show hint
Updated the move folder form to add a hint for the radio button for the
current folder saying 'current folder'. This hint does not get shown if
you are viewing all folders (so you are not inside a folder).

Also stopped a default radio button from being selected on the form.
2019-01-03 16:51:47 +00:00
Tom Byers
501ec2a534 Make all options descend from 'all templates' 2019-01-03 16:51:47 +00:00
Tom Byers
3c4a186a25 Display the template folders nested on the move template/folder form
Before, all the folders were displayed in a list which was ordered but
not nested. This changes the move form to nest the template folders.
2019-01-03 16:51:47 +00:00
Chris Hill-Scott
36656fd6ba Merge pull request #2628 from alphagov/hide-postage-for-those-who-cant-choose
Don’t show postage to users who can’t choose it
2019-01-03 16:26:45 +00:00
Chris Hill-Scott
c02a5800c3 And Midlothian 2019-01-03 16:12:58 +00:00
Chris Hill-Scott
5b6f53ffd1 Mark agreement signed by Stoke on Trent council 2019-01-03 16:07:50 +00:00
Chris Hill-Scott
3a2cfda8b2 Don’t show postage to users who can’t choose it
If you can’t choose postage on a per-template basis, you shouldn’t be
see the thing that indicates that postage can be changed.
2019-01-03 16:04:16 +00:00
Katie Smith
ed84e0958a Stop Redis exception by not passing Redis an empty set to delete
We use `redis_client.delete` to delete multiple keys at once, but this
raises a `redis.exceptions.ResponseError` if it is called with an empty list
or set. We should only call `redis_client.delete` when there is at least
one item to delete.
2019-01-03 15:11:31 +00:00
Chris Hill-Scott
ecf6ebb126 Equalise space before/after paragraph 2019-01-03 11:19:32 +00:00
Chris Hill-Scott
a9baa36005 Hide ‘nothing selected’ if nothing to select
It’s doesn’t make sense to show the state if the state can’t change.
This is especially true when you’re in a brand new, empty service.
2019-01-03 11:16:56 +00:00
Chris Hill-Scott
aaf3322662 Use folder buttons in empty state
It’s confusing to have one way of adding things when your service is new
(green button) but a different way once you’ve added your first thing
(the new grey buttons).

For services that have a `edit_folders` permission, this commit
standardises on the grey buttons for a consistent experience.
2019-01-03 11:14:22 +00:00
Chris Hill-Scott
bbaa51443a Merge pull request #2624 from alphagov/knowsley.gov.uk
Mark agreement signed by Knowsley Council
2019-01-02 16:09:02 +00:00
Pea (Malgorzata Tyczynska)
5d99b2d2f6 Merge pull request #2616 from alphagov/choose_postage
Choose and display postage on template
2019-01-02 15:39:15 +00:00
Chris Hill-Scott
c37bcf3084 Mark agreement signed by Knowsley Council 2019-01-02 15:05:25 +00:00
Chris Hill-Scott
adca4622e4 Fix copypaste 2019-01-02 13:14:23 +00:00
Chris Hill-Scott
b55e0ee392 Mark agreement signed by Newham council 2019-01-02 13:13:01 +00:00