Commit Graph

5659 Commits

Author SHA1 Message Date
Chris Hill-Scott
39bb0ecbf7 Make permission checking a method
Having a function that takes an instance as its only argument suggests
that it should instead be a method on that instance.
2018-07-05 11:47:30 +01:00
Chris Hill-Scott
1f0003903f Refactor form classes for future reuse
There are three parts to a ‘user’ form:
- the email address
- the permissions
- the auth type setting

This commit breaks them up into abstract classes so that they can be
composed more flexibly in future commits.
2018-07-05 11:47:29 +01:00
Chris Hill-Scott
a220ab7877 Encapsulate view_activity logic within the form
This means that:
- we don’t have to manually set it after processing the form
- we can set it dynamically based on some other attribute later on
2018-07-05 11:47:29 +01:00
Chris Hill-Scott
650f4cc3d8 Add platform admin button to enable caseworking
Eventually the ability to have the caseworking view for your service
will be self-service. But while we’re still building it only we should
be able to enable it, for our own testing purposes.

So this commit adds platform admin functionality to switch the feature
on and off for our services.
2018-07-05 11:47:29 +01:00
Chris Hill-Scott
97d40028de Merge pull request #2142 from alphagov/pyup-update-pytest-3.6.2-to-3.6.3
Update pytest to 3.6.3
2018-07-05 11:02:48 +01:00
Chris Hill-Scott
e9fbf14f10 Merge pull request #2138 from alphagov/bump-utils-accessible-letters
Bump utils to make letters screenreader-accessible
2018-07-05 11:01:55 +01:00
Chris Hill-Scott
239a43127d Merge pull request #2137 from alphagov/save-same-service-name
Don’t error if a user keeps same service name
2018-07-05 11:01:48 +01:00
pyup-bot
a90a04200f Update pytest from 3.6.2 to 3.6.3 2018-07-04 23:44:06 +01:00
Katie Smith
9cff9ca801 Merge pull request #2141 from alphagov/paginate-complaints-page
Paginate complaints page
2018-07-04 15:46:19 +01:00
Katie Smith
b27d29805b Raise error if getting complaints page with invalid page param
If the `page` parameter passed to the `platform-admin/complaints`
pageis not an integer, we should return a `404` error page.
2018-07-04 10:38:46 +01:00
Katie Smith
6c27a17e1e Paginate complaints page
The API now returns paginated complaint data, so the
`/platform-admin/complaints` page can now be paginated.
2018-07-03 11:09:33 +01:00
Katie Smith
f5bb2efc72 Merge pull request #2130 from alphagov/new-platform-admin-stats
Add new platform admin stats page
2018-07-03 08:57:47 +01:00
Rebecca Law
87e8f91b06 Merge pull request #2140 from alphagov/increase-page-size
Try increasing the page size
2018-07-02 15:58:15 +01:00
Chris Hill-Scott
1312641240 Merge pull request #2139 from alphagov/cabinetoffice
Add alternative cabinet office domain name
2018-07-02 15:52:06 +01:00
Rebecca Law
05caa102f0 Increasing the page size to see if we get more rows back the downloaded csv. 2018-07-02 15:48:00 +01:00
Chris Hill-Scott
6cc6b9d4da Add alternative cabinet office domain name 2018-07-02 14:26:12 +01:00
Chris Hill-Scott
34abfa0390 Bump utils to make letters screenreader-accessible
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/497
2018-07-02 13:54:56 +01:00
Chris Hill-Scott
d86291cb7a Don’t error if a user keeps same service name
Sometimes a user will hit the green button without actually changing
the service name (we saw this in a usability testing session).

Currently this gives an error saying ‘service name already in use’,
which is technically true (it’s in use by the current service) but
practically just annoying.

This commit adds some logic to silently ignore such requests.
2018-07-02 11:00:02 +01:00
Katie Smith
9c5fd5f23c Validate date format on new platform admin page
Check that the format of the dates entered is in the `YYYY-MM-DD` as
specified and show an error message if it is not. If the date was not in
the specified format, there would be no error message but the content of
the page would change which was misleading.
2018-06-29 15:31:41 +01:00
Katie Smith
ca16bef7f7 Add PlatformStatsAPIClient
In API, the endpoint for the new platform admin stats page has been
moved to a platform stats blueprint. This means we now need a platform
stats client.
2018-06-29 15:31:41 +01:00
Katie Smith
d9aeac4dca Add new platform admin page
Added a new platform admin page, at '/plaform-admin-new' which shows
different data. This no longer offers the option to filter by test-key,
only by date, and also gives a more detailed break-down of the
notifications and failures sent with a normal / research key.

The existing platform admin stats page ('/platform-admin') has not been
deleted yet so that both pages can be compared.
2018-06-29 15:31:40 +01:00
Katie Smith
7a40ad6ac0 Add new methods to Service and Complaint api clients
* Added a new method to the ComplaintApiClient to get the total
complaints by date range from the API.
* Added a new method to the ServiceAPIClient to get the new platform
admin stats data from the API.
2018-06-29 15:31:40 +01:00
Chris Hill-Scott
aba9cf0ff3 Merge pull request #2135 from alphagov/sch.uk
Adding sch.uk to the email domain list...
2018-06-29 15:05:36 +01:00
Pete Herlihy
f829725d80 Adding sch.uk to the email domain list...
The DfE (Department for Education) has allocated every school in the country a domain name of the form of: www.schoolname.county.sch.uk.
2018-06-29 13:49:54 +01:00
Chris Hill-Scott
199c3cb923 Merge pull request #2134 from alphagov/pyup-update-pytz-2018.4-to-2018.5
Update pytz to 2018.5
2018-06-29 09:46:13 +01:00
Chris Hill-Scott
89d5674c12 Merge pull request #2133 from alphagov/ofgem.gov.uk
Mark agreement signed by Ofgem
2018-06-29 09:42:37 +01:00
pyup-bot
fd3043b45a Update pytz from 2018.4 to 2018.5 2018-06-29 08:34:52 +01:00
Chris Hill-Scott
9cc5fd4713 Mark agreement signed by Ofgem 2018-06-28 17:15:14 +01:00
Chris Hill-Scott
a9e27b5619 Merge pull request #2132 from alphagov/hr
Add guidance about horizontal lines
2018-06-28 16:14:18 +01:00
Chris Hill-Scott
adf1493fb5 Add guidance about horizontal lines
We’ve supported this for a while but don’t tell anyone how to do it.

This commit also alters the spacing of things so the description groups
better with the example.
2018-06-28 16:06:04 +01:00
Chris Hill-Scott
418a744283 Merge pull request #2129 from alphagov/gov.scot
Mark agreement signed by Scottish Government
2018-06-28 14:38:45 +01:00
Chris Hill-Scott
e86b4ca34e Merge pull request #2131 from alphagov/🙀
Fix untypographic apostrophe
2018-06-28 11:51:03 +01:00
Chris Hill-Scott
276047b1d6 Fix untypographic apostrophe 2018-06-28 10:53:27 +01:00
Chris Hill-Scott
61e0e7e24e Merge pull request #2117 from alphagov/bump-utils-autolink-sms
Bump utils to link URLs in text message previews
2018-06-28 09:32:29 +01:00
Chris Hill-Scott
22bffe779d Bump utils to link URLs in text message previews 2018-06-28 09:18:17 +01:00
Rebecca Law
8deef9ada9 Merge pull request #2127 from alphagov/download-activity
Add the download activity link for notifications
2018-06-27 14:57:33 +01:00
Sakis
f8eb6c9437 Merge pull request #2128 from alphagov/gunicorn-accesslog
Remove GUNICORN_CMD_ARGS before we start our app
2018-06-25 17:07:09 +01:00
Rebecca Law
472f87b325 Fix order of imports 2018-06-25 16:57:49 +01:00
Chris Hill-Scott
18b20574e1 Mark agreement signed by Scottish Government
We have it for the whole organisation now.
2018-06-25 16:48:03 +01:00
Athanasios Voutsadakis
b56addb4ff Remove GUNICORN_CMD_ARGS before we start our app
Cloudfoundry adds this env var which forces gunicorn to print
its access log to stdout because reasons.

This also takes precedence over *anything* we put in our config file,
including disabling the access logs.

Related commit:
7b350f292a (diff-153f90501612878d9c6fcd50247547bcR526)
2018-06-25 16:39:18 +01:00
Rebecca Law
72b0637f92 Add the download activity link for notifications.
This works locally for a long running request and a large number of messages. However I suspect that nginx may be timing out the request. I'd like to try this on staging.
2018-06-25 16:29:40 +01:00
Leo Hemsted
b554077961 Merge pull request #2126 from alphagov/gunicorn-logs
disable gunicorn access logs
2018-06-25 11:40:23 +01:00
Leo Hemsted
4adee9cc43 Merge pull request #2125 from alphagov/handle-405s
handle 405 METHOD NOT ALLOWEDs
2018-06-25 11:40:17 +01:00
Leo Hemsted
cc3b2f1ab9 disable gunicorn access logs
they're turning up in syslog, which means they're getting into kibana now

also move config settings from manifest to gunicorn_config.py
2018-06-25 11:24:31 +01:00
Leo Hemsted
e81f302084 handle 405 METHOD NOT ALLOWEDs
(show the "something went wrong" error page).

also catch any other werkzeug http exceptions and show an appropriate
template, if it exists
2018-06-22 18:07:18 +01:00
Chris Hill-Scott
6354ddc6f7 Merge pull request #2120 from alphagov/pyup-update-pytest-3.6.1-to-3.6.2
Update pytest to 3.6.2
2018-06-21 14:59:21 +01:00
Chris Hill-Scott
a25f8207f7 Merge pull request #2122 from alphagov/kent.gov.uk
Mark agreement signed by Kent County Council
2018-06-21 14:59:02 +01:00
Chris Hill-Scott
1d7eb06a1d Merge pull request #2124 from alphagov/27691
Update count of services and organisations
2018-06-21 14:58:11 +01:00
Chris Hill-Scott
3b0b090b22 Update count of services and organisations 2018-06-21 14:46:32 +01:00
Chris Hill-Scott
1a50650144 Merge pull request #2118 from alphagov/264-270
Updated service and org count on as at 18 June 2018
2018-06-21 14:39:20 +01:00