Commit Graph

786 Commits

Author SHA1 Message Date
Chris Hill-Scott
382cfa2907 Make page titles consistent
This commit modifies the HTML `<title>` tags for all the pages. It makes two
main changes:
- make the title tag match the `<h1>` of the page, for better or worse
- put the service name after the page title, seperated by an en dash, as per
  GOV.UK
2016-02-08 09:23:51 +00:00
Adam Shimali
4338bc9aaf Merge pull request #156 from alphagov/skip-choose-service
Skip ‘choose service’ page if user has one service
2016-02-05 15:20:34 +00:00
Chris Hill-Scott
d5656a4dc2 Add mocked get_services to test_client.login
Because the redirect after logging in checks the number of services a user has,
this now needs to be mocked.

Right now this means adding `mock_get_login` to any tests that need a login.
This must be one of the first mocks, so that it can be overridden by any use
of `mock_get_services`, for tests that specifically want to rely on a quantity
of mocked services, or their contents.

This is a bit fragile, but there’s already a TODO in the code to make it better
so ¯\_(ツ)_/¯
2016-02-05 15:11:44 +00:00
Chris Hill-Scott
939954cd64 Skip ‘choose service’ page if user has one service
We used to do this by redirecting on the choose service page. However when we
lost the dropdown and this page also became the page for adding a new service
(in 3617f2e936) the redirect was removed.

This commit re-adds the redirect on the two factor page, so that it only happens
on first login.

So the flows are:

**Multiple services**
```
`Sign in` → `Enter two factor code` → `Choose service` → `Service dashboard`
```

**One service**
```
`Sign in` → `Enter two factor code` → `Service dashboard`
```

**No services (you’ve deleted all your services)**
`Sign in` → `Enter two factor code` → `Choose service` → `Add new service`
2016-02-05 14:50:55 +00:00
NIcholas Staples
7854617453 Merge pull request #155 from alphagov/fixes-to-front-end-patterns
Fixes to front end patterns
2016-02-05 11:39:46 +00:00
Adam Shimali
5555e07b32 Merge pull request #154 from alphagov/jobs-on-dashboard
Limit number of jobs on dashboard to 5
2016-02-05 11:22:17 +00:00
Adam Shimali
0c3c91f5fb Merge pull request #153 from alphagov/send-started-flash
Add a flash message to confirm sending has started
2016-02-05 11:21:53 +00:00
Chris Hill-Scott
7dc5d76b98 Use banners appropriately
We’ve fiddled around with the banners quite a lot in the last few days. This
commit reviews some of the older examples and makes sure that they’re:

a) not broken
b) using the most appropriate banner for the context
2016-02-05 10:43:49 +00:00
Chris Hill-Scott
9c1e47d594 Fix wrapping of API key 2016-02-05 10:43:49 +00:00
Chris Hill-Scott
0fc927b458 Review usage of secondary/back links
This commit examines all the pages that use the page footer component, and
determines whether they should have a back button, a secondary link, both or
neither.
2016-02-05 10:43:49 +00:00
Chris Hill-Scott
f5807d939a Add secondary link pattern to page footer
This commit brings back the ‘link under the green button’ bit of the page footer
component.

Previous it had been changed to be a grey button. But there are use cases for
both, maybe even simultaneously.
2016-02-05 10:34:26 +00:00
Chris Hill-Scott
eba03d0bb5 Remove job ID from jobs table
Don’t think it’s something we need to surface to users.
2016-02-04 17:26:58 +00:00
Chris Hill-Scott
7e670d9662 Limit number of jobs on dashboard to 5
…and add a link to view the rest of the jobs if there are more than 5.
2016-02-04 17:25:29 +00:00
Chris Hill-Scott
7399c3c6c0 Add a flash message to confirm sending has started 2016-02-04 15:29:36 +00:00
NIcholas Staples
cf08f4ef2a Merge pull request #150 from alphagov/send-text-flow-revised
Send text flow revised
2016-02-04 14:57:43 +00:00
NIcholas Staples
984e6946ca Merge pull request #152 from alphagov/wider-texts-register
Make textboxes wider on create account
2016-02-04 14:57:29 +00:00
Chris Hill-Scott
a7d6d85d8b Make first page of ‘send texts’ use links not form
This doesn’t need to be a form—it’s not changing any data.

And having the primary action on the page as ‘Use this template’ it makes it
clear what the page is for.
2016-02-04 14:13:57 +00:00
Chris Hill-Scott
7516ec6aba Fake phone number on job page
To show what kind of data we want to surface here.
2016-02-04 14:08:57 +00:00
Chris Hill-Scott
26adcc64c1 Updates to ‘send SMS’ page
Based on discussion with Pete.

Make the blue banner an ‘important’ banner (copied from Register to Vote, used
because it’s not as boxy and fits on the page better).

Remove the back button because you haven’t changed any data yet. If you need to
go back you can just press back or start again.

Make the filename stand out more.

Remove the ‘download example’ link. Will need to revist the best way of doing
this.

Make text messages consistently 2/3rd width.
2016-02-04 14:06:19 +00:00
Chris Hill-Scott
e37123f083 Make textboxes wider on create account 2016-02-04 12:41:39 +00:00
Rebecca Law
4c461b9dbe Merge pull request #151 from alphagov/job-id-bug-fix
Service and job id were incorrectly in bucket name.
2016-02-04 12:16:07 +00:00
Adam Shimali
6c5dfcddb1 Merge pull request #149 from alphagov/add-manage-users
Populate manage users page with fake data
2016-02-04 12:12:26 +00:00
Adam Shimali
90a17bc0a7 Service and job id were incorrectly in bucket name. 2016-02-04 12:06:06 +00:00
Chris Hill-Scott
51208a9eb2 Make banner on template page real 2016-02-04 11:31:33 +00:00
Chris Hill-Scott
54cad9cf24 Remove dummy content 2016-02-04 11:07:33 +00:00
Chris Hill-Scott
48df622aba Add two steps to onboarding banner
It’s not obvious what the first steps are when you’ve just signed up.

This commit changes the banner on the dashboard to make it obvious.
2016-02-04 10:59:18 +00:00
Chris Hill-Scott
28f700366c Fix spacing of first page headers
This commit customises the margins of the first header on each page so that it
lines up with the navigation.
2016-02-04 10:59:18 +00:00
Chris Hill-Scott
4280c21b23 Updates to send and check SMS pages
Adds a back button instead of a back link (more prominent, you’re likely to
go back on these pages if you’ve made a mistake)

Tweaks to wording
2016-02-04 10:59:18 +00:00
Chris Hill-Scott
856296df5d Updates to display of jobs
This commit:
- adds the template to the jobs page (and puts it at the top of the send SMS
  page) so that it consistently appears in the same place throughout the
  journey
- put the real data about a job on the jobs page and on the dashboard
2016-02-04 10:59:03 +00:00
Chris Hill-Scott
3e7bb42323 Replace message previews on check page with table
The first 3/last 3 messages didn’t test well, it wasn’t immediately obvious what
was going on.

This commit replaces it with just a preview of the first message, and a table
showing the details of the subsequent messages.
2016-02-04 10:44:20 +00:00
Adam Shimali
2e4e354680 Merge pull request #148 from alphagov/file-uploader
File uploader
2016-02-03 17:25:58 +00:00
Chris Hill-Scott
0b47656ebc Add custom file upload to the send SMS page
This is the only place we’re doing file upload at the moment.
2016-02-03 17:16:29 +00:00
Chris Hill-Scott
4447af3fec Add custom file upload component
The default browser file upload control is difficult to style, but looks totally
out of place.

This commit replaces it with one that has a GOV.UK style button, as a first
step.

Based heavily on this example:
http://tympanus.net/codrops/2015/09/15/styling-customizing-file-inputs-smart-way/
2016-02-03 17:16:17 +00:00
Henry Hadlow
091694415b Add manage users page 2016-02-03 17:08:58 +00:00
Adam Shimali
44045b2d09 Merge pull request #147 from alphagov/split-sms
Split ‘send SMS’ page into two pages
2016-02-03 17:08:45 +00:00
Henry Hadlow
b1eadaedcd Tidy up README 2016-02-03 15:18:57 +00:00
Chris Hill-Scott
c774b82ba9 Don’t allow user to send texts without template 2016-02-03 13:38:55 +00:00
Chris Hill-Scott
9bdce7007d Merge pull request #146 from alphagov/ph-nav-labels
Updated main nav to group things more sensibly
2016-02-03 11:33:40 +00:00
Chris Hill-Scott
8d3e3e6943 Change wording on the banner
We can ignore any mention of trial/test/mode if we just talk about ‘not live’.

It also feels sensible to link through to the page where you can make that
change, rather than dig through the navigation.
2016-02-03 11:18:02 +00:00
Chris Hill-Scott
394a9db3f7 Split ‘send SMS’ page into two pages
This commit just splits the existing page into two. It doesn’t do any
substantive changes to how the two parts of the page work.
2016-02-03 11:14:20 +00:00
Pete Herlihy
808d8d507f Updated main nav to group things more sensibly
Adding more verbs than nouns too.... so it's clear what you do at each view.

No ticket for this, as off-piste.

Naughty.
2016-02-03 10:53:22 +00:00
NIcholas Staples
24cdfd9f64 Merge pull request #145 from alphagov/bucket-creation
Bucket creation needed correct region to be set.
2016-02-03 09:50:20 +00:00
Adam Shimali
c05a4b2059 Bucket creation needed correct region to be set.
That resulted in non-idempotent create_bucket in non us east 1
location, so needed to check for bucket existence first.
2016-02-02 22:26:49 +00:00
Adam Shimali
dd07a00e68 Merge pull request #144 from alphagov/error_headers_fix
Update error handlers to include appropriate headers.
2016-02-02 17:24:43 +00:00
Adam Shimali
b95e08a3a6 Merge pull request #141 from alphagov/update_version_status_info
Updated status endpoint info from travis build time and commit.
2016-02-02 17:23:37 +00:00
NIcholas Staples
bcd89371fe Merge pull request #143 from alphagov/autofocus-two-factor
Autofocus two factor
2016-02-02 16:51:33 +00:00
NIcholas Staples
aeb884b9a9 Merge pull request #142 from alphagov/clearer-verify-page
Clearer verify page
2016-02-02 16:51:20 +00:00
Nicholas Staples
7fc1db9d19 Update error handlers to include appropriate headers. 2016-02-02 16:50:13 +00:00
Nicholas Staples
c7ab8bd957 Status structure updated. 2016-02-02 16:44:42 +00:00
Nicholas Staples
5d88ecc866 Bug fix for mis-spelled func names. 2016-02-02 16:42:57 +00:00