darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-17 21:20:32 -04:00
Code Issues Packages Projects Releases Wiki Activity
4,995 Commits 59 Branches 61 Tags
34f1b40dbcc03b2d7769c50d4a2d31896aa2cc46
Commit Graph

4995 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Waszczuk
34f1b40dbc Merge pull request #1858 from gov-cjwaszczuk/link-service-to-organisation 
Link services to organisations (Admin)
 2018-02-14 12:30:15 +00:00
Katie Smith
8bbfde5845 Merge pull request #1861 from alphagov/let-service-change-punctuation-in-name 
Pass service_id through to API '/service/unique' endpoint
 2018-02-14 11:53:03 +00:00
Katie Smith
a4145a6a13 Merge pull request #1866 from alphagov/leohemsted-patch-2 
Update requirements.txt
 2018-02-14 11:52:52 +00:00
Leo Hemsted
9716983f83 Update requirements.txt 
email validation
 2018-02-14 11:31:29 +00:00
Katie Smith
84d810b981 Pass service_id through to API '/service/unique' endpoint 
Notifications-api now needs the service_id to check the uniqueness of
the service name when trying to change it. This is to allow a user to
successfully change the pluralization or the case of their service name.
 2018-02-13 15:57:19 +00:00
Leo Hemsted
0f20cfe8bc Merge pull request #1857 from alphagov/logging 
don't log 404s as ERROR
 2018-02-13 14:17:03 +00:00
chrisw
1450138b9c link-services-to-organisations 2018-02-13 12:49:57 +00:00
Leo Hemsted
08fb149b5f don't log 404s as ERROR 2018-02-12 16:02:33 +00:00
Chris Hill-Scott
01a2852a69 Merge pull request #1849 from alphagov/pyup-update-pytz-2017.3-to-2018.3 
Update pytz to 2018.3
 2018-02-12 15:07:16 +00:00
Chris Hill-Scott
bf8ba544d1 Merge pull request #1836 from alphagov/pyup-update-notifications-python-client-4.7.1-to-4.7.2 
Update notifications-python-client to 4.7.2
 2018-02-12 15:03:05 +00:00
Chris Hill-Scott
1f9025caa0 Merge pull request #1855 from alphagov/pyup-update-flake8-print-3.0.1-to-3.1.0 
Update flake8-print to 3.1.0
 2018-02-12 14:17:19 +00:00
kentsanggds
9401703a0d Merge pull request #1846 from alphagov/add-organisations 
Add organisations
 2018-02-12 13:25:03 +00:00
Ken Tsang
35571e741c Refactor manage-organisation.html, organisations.html 2018-02-12 12:27:06 +00:00
Ken Tsang
11a7fc49b7 Renamed create to add for organisations 2018-02-12 12:27:06 +00:00
Ken Tsang
a200f1a17e Go to organisation stub page which will eventually show list of services 2018-02-12 12:27:06 +00:00
Ken Tsang
d4c6491c93 Add title 2018-02-12 12:27:06 +00:00
Ken Tsang
f0e8661e34 Add organisations pages to show orgs and create/edit them 2018-02-12 12:27:06 +00:00
Ken Tsang
b11bfd49e3 Add Organisations API Client 2018-02-12 12:27:06 +00:00
Ken Tsang
4eea97c83b Add organisation to platform admin navigation 2018-02-12 12:27:06 +00:00
Chris Hill-Scott
3f5d9f418b Merge pull request #1856 from alphagov/diff-dom-update 
Fix bug with disappearing AJAX content in IE 9/10
 2018-02-12 12:17:50 +00:00
Chris Hill-Scott
35e7260d6f Fix bug with disappearing AJAX content in IE 9/10 
We had a user report that the ‘inbound messages’ part of their dashboard
was appearing for a split second then disappearing.

This was caused by the Javascript on the page throwing an exception as
it was trying to re-render this part of the page. This meant it gave up
and rendered nothing.

The exception was caused by passing `undefined` as the second argument
to `.insertBefore`. This is acceptable in most browsers, but not older
versions of IE. This is fixed in the latest version of diffDOM (the 3rd
party library we use to do the AJAX stuff) by defaulting the second
argument to `.insertBefore` to `null`, which is acceptable in old IE
versions.

See the fix here: 8833d87e9d
 2018-02-12 11:39:38 +00:00
Chris Hill-Scott
5efc86bbcc Remove flag from flake8 command 
This flag was only needed because of a bug in flake8. This bug is fixed
now.
 2018-02-12 10:26:55 +00:00
pyup-bot
4058a9f45f Update flake8-print from 3.0.1 to 3.1.0 2018-02-11 16:39:14 +00:00
Chris Hill-Scott
13f3e8d933 Merge pull request #1850 from alphagov/email-auth-host 
Tell API what URL to use for email auth links
 2018-02-09 17:02:46 +00:00
Chris Hill-Scott
52241b8f3e Use client from app in tests 
Means we don’t have to instantiate it in every test, keeps things
consistent with parent commit.
 2018-02-09 15:04:52 +00:00
Chris Hill-Scott
1908e7b091 Tell API what URL to use for email auth links 
So that we can keep people on the prototype URL when doing user
research.

Depends on:
- [ ] https://github.com/alphagov/notifications-api/pull/1645
 2018-02-09 15:01:20 +00:00
pyup-bot
6c22cd0446 Update pytz from 2017.3 to 2018.3 2018-02-09 08:18:09 +00:00
Chris Waszczuk
5254aa6765 Merge pull request #1817 from gov-cjwaszczuk/manage-api-keys-users-can-see-reply-tos 
manage api keys permission should be able to see senders
 2018-02-08 11:38:49 +00:00
chrisw
5d26d4457f manage api keys permission should be able to see senders 2018-02-08 11:25:49 +00:00
Chris Waszczuk
7f8e53ee96 Merge pull request #1843 from gov-cjwaszczuk/organisations-to-email-branding 
Change organisations to email branding
 2018-02-08 10:37:15 +00:00
chrisw
9ad4435d94 Change organisations to email branding 2018-02-07 17:41:23 +00:00
Pete Herlihy
d466de3405 Merge pull request #1845 from alphagov/144-147 
144 - 147 services
 2018-02-07 15:52:20 +00:00
Pete Herlihy
f36d284b6a 144 - 147 services 
* Home Office – Notifying Sponsors - Curtailment Considerations Beta
* Cabinet Office – Register to vote
* Milton Keynes Council – MK MASH

No new orgs.
 2018-02-07 13:28:39 +00:00
Chris Waszczuk
c2136b0ffb Merge pull request #1768 from gov-cjwaszczuk/add-letters-to-monthly-messages-sent 
Include letters on monthly messages sent
 2018-02-07 10:52:52 +00:00
Chris Hill-Scott
a819b30d35 Merge pull request #1837 from alphagov/minus-mou 
Removed reference to MOU now that we have contracts and MOUs.
 2018-02-05 11:56:38 +00:00
Chris Hill-Scott
711ec5d0f8 Remove quotation marks 2018-02-05 11:46:16 +00:00
Chris Hill-Scott
edac271dbf Update request to go live form too 
We have an MOU and a contract now, not just an MOU.
 2018-02-05 11:14:20 +00:00
Pete Herlihy
bbe26580ff Removed reference to MOU now that we have contracts and MOUs. 2018-02-05 10:32:23 +00:00
Chris Hill-Scott
30f89a0041 Merge pull request #1834 from alphagov/button-not-input 
Use `<button>` not `<input>`s for form submission
 2018-02-02 13:22:36 +00:00
pyup-bot
04b6d6eda3 Update notifications-python-client from 4.7.1 to 4.7.2 2018-02-01 16:23:57 +00:00
Leo Hemsted
2856b8709d Merge pull request #1835 from alphagov/eventlet 
run gunicorn with eventlet
 2018-02-01 15:40:00 +00:00
Leo Hemsted
31112c9ecf run gunicorn with eventlet 
this massively increases the horizontal parallellability by using async workers
 2018-02-01 14:56:52 +00:00
Chris Hill-Scott
9aa4a7267a Use <button> not <input>s for form submission 
Both `<button type='submit'>Submit<button>` and
`<input type='submit' value='Submit'>` can be used to submit a form.

We have historically[1] used `<input>` because it’s better-supported by
IE6 in that:
- the `submit` attribute is mandatory on `<button>`, not on `<input>`
- the `innerHTML` of a button will be submitted to the server, not the
  value (as in other browsers)

Reasons to now use `<button>` instead:
- IE6/7 support is no longer a concern (especially with deprecation of
  TLS 1.0 on the way)
- Because an `<input>` element can’t have children, the pseudo-element
  hack[2] used to ensure the top edge of the button is clickable doesn’t
  work. We’re seeing this bug[3] affect real users in research.

1. We inhereted our buttons from Digital Marketplace, here is me making
   that change in their code:  8df7e2e79e (diff-b1420f7b7a25657d849edf90a70ef541)
2. 24e1906c0d (diff-ef0e4eb6f1e90b44b0c3fe39dce274a4R79)

3. https://github.com/alphagov/govuk_elements/issues/545
 2018-02-01 13:53:45 +00:00
Rebecca Law
6cc83b903d Merge pull request #1833 from alphagov/inbox-page-performance 
Inbox page performance fix
 2018-02-01 13:50:27 +00:00
Rebecca Law
5dedeaa89c Remove reversed in favour of reverse=True 2018-02-01 13:43:16 +00:00
Rebecca Law
07e5e67bd0 The performance of the inbox page had degraded to the point of failing to load. 
We pin pointed the problem to a bad loop that was calling the format_phone_number_human_readable 216 for 25 rows, yikes.

This PR fixes that performance problem.
 2018-02-01 13:26:28 +00:00
Pete Herlihy
0d23775a62 Adding a note about how to pay to the pricing page 2018-02-01 10:40:29 +00:00
Chris Hill-Scott
aca5004b62 Merge pull request #1831 from alphagov/doc-new-tab 
Open links to client documentation in a new tab
 2018-01-31 14:04:16 +00:00
Chris Hill-Scott
e97e3faced Merge pull request #1828 from alphagov/142-144 
142-144 for Home Office Bus Continuity and CO Public Appointments
 2018-01-31 13:47:02 +00:00
Chris Hill-Scott
a334ff804d Merge pull request #1829 from alphagov/pyup-update-pytest-3.3.2-to-3.4.0 
Update pytest to 3.4.0
 2018-01-31 13:46:53 +00:00