Commit Graph

2990 Commits

Author SHA1 Message Date
Imdad Ahad
343bf9ab98 Show delivered+failed on platform admin sent totals 2017-01-23 11:59:37 +00:00
Chris Hill-Scott
3b1c0c3e02 Merge pull request #1078 from alphagov/sanitize-html-in-templates-using-utils
Sanitize HTML in templates using utils
2017-01-20 13:44:52 +00:00
imdadahad
18b2936223 Merge pull request #1077 from alphagov/fix-row-number-issue-on-report-download
Fix issue where row_number starts from 3 on a job report download
2017-01-20 12:38:50 +00:00
imdadahad
f8cb5e59a9 Merge pull request #1074 from alphagov/show-last-updated-on-view-providers
Add last updated column (formatted) in view providers table
2017-01-20 12:38:29 +00:00
Leo Hemsted
44eedfb8bf Merge pull request #1081 from alphagov/send-back-in-help
send users back to beginning of tour if they hit back at end
2017-01-20 11:43:12 +00:00
Leo Hemsted
ef91c374a5 send users back to beginning of tour if they hit back at end
(previously it would have sent them to the choose template page)
if the user has added new templates or deleted the example one,
they're clearly competent enough to use the app so don't worry
(we wouldn't know what URL the tour starts on since the UUID of
the example template is random)
2017-01-20 10:45:29 +00:00
Chris Hill-Scott
04966e4051 Test that template content passed to API is dirty
We don’t want sanitized content going into the database, because
sometimes we need the content unsanitised. The path from admin to the
API is where the template goes on it’s way to the database. So let’s
make sure we’re not sanitizing it at this stage.
2017-01-19 16:51:53 +00:00
Chris Hill-Scott
597c6da857 Sanitize HTML in templates using utils
We can no longer trust that the content of templates stored in the
database is safe.

Utils now has code to sanitise the content of templates.

This commit:
- updates utils to bring this code in
- modifies some integration tests to make sure everything is working
  (there are more extensive unit tests in utils)
2017-01-19 16:34:34 +00:00
Leo Hemsted
689c199b8c Merge pull request #1079 from alphagov/send-back-button
when pressing back after sending CSV redirect properly
2017-01-19 16:26:25 +00:00
Imdad Ahad
b7099ebb3c Modify stub providers with default values for consistency 2017-01-19 15:41:09 +00:00
Leo Hemsted
9e414ef3c0 when pressing back after sending CSV redirect properly
previously we were issuing a flask redirect (302) from the function,
which we then attempted to unpack as a dict further down the line.

raise a werkzeug.routing.RequestRedirect (301 MOVED PERMANENTLY)
instead. note: only use this pattern when the URL they attempted to
access will *NEVER* be valid, as 301s are cached by browsers.
2017-01-19 15:20:30 +00:00
Imdad Ahad
5365015adf Optimise the check 2017-01-19 10:57:11 +00:00
Imdad Ahad
6a48325b3b Fix issue where row_number starts from 3 on a job report download 2017-01-19 10:42:58 +00:00
Rebecca Law
810aaf50e8 Merge pull request #1076 from alphagov/change-select-to-radio
Change the selectField on the edit template form to a radio field.
2017-01-19 10:00:29 +00:00
Rebecca Law
d0c762325d remove comment 2017-01-19 09:50:27 +00:00
Rebecca Law
b372ab7ba1 Change the selectField on the edit template form to a radio field.
It's more stylish
2017-01-19 09:35:34 +00:00
Rebecca Law
134190332f Merge pull request #1075 from alphagov/update-template-with-priority-if-platform-admin
Create or update templates with priority as platform admin
2017-01-18 16:14:18 +00:00
Rebecca Law
babafd8dc9 Change the drop down to read Use priority queue? yes|no 2017-01-18 16:03:30 +00:00
Rebecca Law
3dfb3806d2 Add a selectField to edit and create templates that is only visible for platform admins that makes the template a priority template.
There is a check that the template can not be created as priority if the user is not a platform admin.
There is a check that the template can not change the `priority` unless they are a platform admin.
2017-01-18 15:11:34 +00:00
Chris Hill-Scott
a40cfa4682 Merge pull request #1069 from alphagov/update-utils-nimbus
Bump utils
2017-01-18 14:35:15 +00:00
bandesz
74536530b0 Install libjpeg62 in the Docker image 2017-01-18 14:30:49 +00:00
Chris Hill-Scott
e73629be2e Bump utils
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/107
2017-01-18 14:22:30 +00:00
bandesz
f5b0add361 Do not exclude docker files from the codedeploy build 2017-01-18 13:49:23 +00:00
Imdad Ahad
ac3467c1b5 Add last updated column (formatted) in view providers table 2017-01-17 15:21:05 +00:00
Chris Hill-Scott
dfc751ef02 Merge pull request #1073 from alphagov/service-count-update
Update count of services on product page
2017-01-17 14:41:07 +00:00
Chris Hill-Scott
ac2e143584 Update count of services
Two new services, from a department who are already using Notify.
2017-01-17 12:27:34 +00:00
Andras Ferencz-Szabo
80433b5d12 Merge pull request #1049 from alphagov/cloudfoundry
Run on Paas
2017-01-17 12:17:23 +00:00
bandesz
ed17b68330 Jenkinsfile: retry functional tests 2017-01-17 11:44:42 +00:00
bandesz
536d9a975d Don't build wheelhouse files for PAAS 2017-01-17 11:44:42 +00:00
bandesz
0d4e55d33a Add Jenkinsfile 2017-01-17 11:44:42 +00:00
bandesz
7eab0f411f Run Docker container with host user and group 2017-01-17 11:44:42 +00:00
Leo Hemsted
88b848a4a3 bump utils to 13.1.0
brings in changes to allow logging json to sdout on cloudfoundry boxes
2017-01-17 11:44:42 +00:00
bandesz
54af97767f Add quotes around Docker volume definitions 2017-01-17 11:44:42 +00:00
bandesz
10950bb8a6 Run on Paas 2017-01-17 11:44:42 +00:00
minglis
7853817f07 Merge pull request #1071 from alphagov/pentester-as-valid-domain
This PR allows the pentesters to operate as part of white listed root…
2017-01-17 09:01:24 +00:00
bandesz
d523ccf0d6 Fix typo: procecces -> processes 2017-01-16 17:51:46 +00:00
Andras Ferencz-Szabo
05d4c0f27d Merge pull request #1072 from alphagov/codedeploy_autoscaling
Add Makefile commands to control autoscaling processes
2017-01-16 17:38:04 +00:00
bandesz
568032bd28 Add Makefile commands to control autoscaling processes 2017-01-16 17:29:35 +00:00
Martyn Inglis
d333e5a8a8 Escape the period 2017-01-16 16:49:50 +00:00
Martyn Inglis
d45484feb5 This PR allows the pentesters to operate as part of white listed root domains. Needed for full app testing. 2017-01-16 14:18:46 +00:00
imdadahad
b5cb34c368 Merge pull request #1070 from alphagov/return-streamed-csv
Fix timeout on download of large CSV reports
2017-01-16 10:34:25 +00:00
Imdad Ahad
e04dd02c14 Fix blank lines issue 2017-01-13 11:45:09 +00:00
Imdad Ahad
50e0227480 Fairly large refactor of tests related to getting/viewing notifications 2017-01-13 11:37:14 +00:00
Imdad Ahad
59c7bc2e6f Refactor get notifications streaming including formatting 2017-01-13 11:35:27 +00:00
Imdad Ahad
d170c97cec Refactor existing tests to expect csv stream with helper method 2017-01-06 17:49:20 +00:00
Imdad Ahad
1036f365fa Refactor generate csv test to expect a stream (generator) 2017-01-06 17:43:46 +00:00
Imdad Ahad
e28d009fa7 Return csv download stream instead of all-in-memory 2017-01-06 17:41:24 +00:00
Chris Hill-Scott
2f9b9f24f5 Merge pull request #1066 from alphagov/folded-letter
Restrict letter previews to their folded height
2017-01-04 16:10:41 +00:00
Chris Hill-Scott
28b18bdac8 Thin the borders around the letter preview
1px borders match the keylines that we use on email template previews.
2017-01-04 15:53:13 +00:00
Chris Hill-Scott
6271b427aa Don’t skew bottom half of letter in folded state
Skewing the letter results in a bunch of slightly-off-vertical diagonal
lines. This is a bit visually jarring when everything else on the page
lines up vertically or horizontally.

This commit makes the bottom half of the letter straight, by offsetting
it instead of transforming it. The ‘fold’ now has depth, so it has to
be drawn in somehow, that’s what the `:before` is doing.
2017-01-04 15:53:13 +00:00